From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from new3-smtp.messagingengine.com (new3-smtp.messagingengine.com [66.111.4.229]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0A6752FB6 for ; Tue, 17 Aug 2021 07:38:15 +0000 (UTC) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 24740580ACF; Tue, 17 Aug 2021 03:38:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 17 Aug 2021 03:38:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=+bMu1Ljjo2MZK0+5p6uccJMVSlW iMcV687SCKmX/GLE=; b=kV5vwKjn6g+KeJYoI57epVjPe13hYg+w8CWomo+8A8q cXCS3mO4Xi27cHrGwpGnFxk7D7tRRbzkMaW9x56X8lowgHLvOOa9lL8tXWjoplTL Pj3HwH0PFXD4pKMjvAmsy6354tS0IfZ12qur05BbTOPAYgF3oKnBuaHhXKSYTP+B n1sxSFvqyxcHPjLWOQ/hW/796vc0KD86gMO4vz7XaCtt76zfbTA6r3V+QaZBIEoe rAZwnH2aRvRpqCiRjup9gG0lzfqwYrLnWeZraU7Slv9gG5tOv4mg/d5BC1JYt76H fvpucFXs/k3rAJJBO9QT4JwK+IDFgtEBuYQTVJBuLtg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=+bMu1L jjo2MZK0+5p6uccJMVSlWiMcV687SCKmX/GLE=; b=ALlhFNv0fEY/sYD+d1JLtz f4gvXXBcIp3M2SmqW6PeJ7fcwKWC96ME7+J9z055sEfPh6/PikvBo5yFQhx4T7MU AJ90l9QYUnD0iT/RAjHlJxBV48PeqF/3pb8O2W7FRzljGToFZR0Tn9T2XHt+gIz8 louw0ee2Grur0Zjg/QEUzD3Apby+KlezZrcVVdYZ2sznGBjcgWSyVc2ygKn1pMyf F17AJHEOMBtnwFCiDFHA5QJVx1/aa/bse5dBrs4rprNZWS6xCqE+uSOTotJ+5gQe 0ATFip6Gw5KQo5FIW26HdbS4zauIdiyl1Y5yDg+DXwi04Df5kxrxCDTfkLh7o/eg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrledvgdduvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 17 Aug 2021 03:38:11 -0400 (EDT) Date: Tue, 17 Aug 2021 09:38:10 +0200 From: Maxime Ripard To: Andre Przywara Cc: Chen-Yu Tsai , Jernej Skrabec , Rob Herring , Icenowy Zheng , Samuel Holland , linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Ondrej Jirman , devicetree@vger.kernel.org, Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org Subject: Re: [PATCH v8 02/11] dt-bindings: rtc: sun6i: Add H616 compatible string Message-ID: <20210817073810.7stuzrppyjf4spab@gilmour> References: <20210723153838.6785-1-andre.przywara@arm.com> <20210723153838.6785-3-andre.przywara@arm.com> <20210726144137.6dauuxdssu7yszox@gilmour> <20210802013938.29fa18ed@slackpad.fritz.box> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ggkfv7hwuuflnmjz" Content-Disposition: inline In-Reply-To: <20210802013938.29fa18ed@slackpad.fritz.box> --ggkfv7hwuuflnmjz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Aug 02, 2021 at 01:39:38AM +0100, Andre Przywara wrote: > On Mon, 26 Jul 2021 16:41:37 +0200 > Maxime Ripard wrote: >=20 > > Hi, > >=20 > > On Fri, Jul 23, 2021 at 04:38:29PM +0100, Andre Przywara wrote: > > > Add the obvious compatible name to the existing RTC binding. > > > The actual RTC part of the device uses a different day/month/year > > > storage scheme, so it's not compatible with the previous devices. > > > Also the clock part is quite different, as there is no external 32K L= OSC > > > oscillator input. > > >=20 > > > Signed-off-by: Andre Przywara > > > > > > --- > > > .../bindings/rtc/allwinner,sun6i-a31-rtc.yaml | 14 ++++++++++++= ++ > > > 1 file changed, 14 insertions(+) > > >=20 > > > diff --git a/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a3= 1-rtc.yaml b/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.= yaml > > > index beeb90e55727..d8a6500e5840 100644 > > > --- a/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.y= aml > > > +++ b/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.y= aml > > > @@ -26,6 +26,7 @@ properties: > > > - const: allwinner,sun50i-a64-rtc > > > - const: allwinner,sun8i-h3-rtc > > > - const: allwinner,sun50i-h6-rtc > > > + - const: allwinner,sun50i-h616-rtc > > > =20 > > > reg: > > > maxItems: 1 > > > @@ -104,6 +105,19 @@ allOf: > > > minItems: 3 > > > maxItems: 3 > > > =20 > > > + - if: > > > + properties: > > > + compatible: > > > + contains: > > > + const: allwinner,sun50i-h616-rtc > > > + > > > + then: > > > + properties: > > > + clock-output-names: > > > + minItems: 3 > > > + maxItems: 3 =20 > >=20 > > You don't need both of them when they are equal > >=20 > > > + clocks: false > > > + =20 > >=20 > > It's not entirely clear to me what those clocks are about though. If we > > look at the clock output in the user manual, it looks like there's only > > two clocks that are actually being output: the 32k "fanout" clock and > > the losc. What are the 3 you're talking about?] >=20 > I see three: the raw SYSTEM "CLK32K_LOSC", the RTC input + debounce > clock (/32), and the multiplexed PAD. But the input and debounce clock is only for the RTC itself right? So it should be local to the driver and doesn't need to be made available to the other drivers Either way, what this list is must be documented. > > Also, it looks like the 32k fanout clock needs at least the hosc or > > pll-periph in input, so we probably don't want to ask for no parent > > clock? >=20 > Well, we never seem to reference the HOSC this way, this was always > somewhat explicit. And yes, there is PLL-PERIPH as an input, but we > don't support this yet. So I went with 0 input clocks *for now*: the > driver can then ignore all clocks, so any clock referenced in the DT > later won't cause any harm. This will all be addressed by Samuel's RTC > clock patch, which will also touch the H6, IIRC. And it looks like we > will need to touch the binding anyway then, but can then just *extend* > this. You mentioned that series several times already and never provided an explanation for what it was supposed to be doing except fixing everything. What's the general plan for that series? Maxime --ggkfv7hwuuflnmjz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYRtnYgAKCRDj7w1vZxhR xa/CAP9hbwXj022ukapaHrTpQ2r92mfnkV387OMFnrGF9gS4IgD/YU6D6Z6bzoG4 DqHj9PzBXYYPYXEmg4uN6r7bDdNT+QU= =0frR -----END PGP SIGNATURE----- --ggkfv7hwuuflnmjz-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DEDCDC4338F for ; Tue, 17 Aug 2021 07:40:19 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id A7B2D60524 for ; Tue, 17 Aug 2021 07:40:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org A7B2D60524 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=UvZVmdia0aWPa9g5kGxV5zy1afmmwZUf0d917n6meOg=; b=fCTsBLOxDJsG4dCOIjX8PlPXBq iDb8Jc2r+flWsmafRauOM/swTL207AVRV/6URhxpo55/pKf8fA7KAuvZfh+LPM4TWa7YGU3jkAG+9 vQmyMKrWfuTNAXmBvzpueyX7Jj7Ec3ZtTXnOdMGR9udV0H8Tlq/DOpQh5n8/11JHCLRGZtSnemM3A W3oYzIskHXPTKuV4H7j61YSQtujS98WbYaoCylNhJzz0e+6+3lmzfA0XXye6M4KknhRDkmQirU0Kx Pa8PPJ3JhIqAi9Irv/jsB9N87Svl9mRfhWAfeZl1bM/pUHFQE+/F5cbfXvt5/9ruIq2TnsNb3TR1+ 2T8ncnPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFtfz-001LXc-F9; Tue, 17 Aug 2021 07:38:23 +0000 Received: from new3-smtp.messagingengine.com ([66.111.4.229]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mFtfs-001LW1-U0 for linux-arm-kernel@lists.infradead.org; Tue, 17 Aug 2021 07:38:21 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailnew.nyi.internal (Postfix) with ESMTP id 24740580ACF; Tue, 17 Aug 2021 03:38:15 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute4.internal (MEProxy); Tue, 17 Aug 2021 03:38:15 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=+bMu1Ljjo2MZK0+5p6uccJMVSlW iMcV687SCKmX/GLE=; b=kV5vwKjn6g+KeJYoI57epVjPe13hYg+w8CWomo+8A8q cXCS3mO4Xi27cHrGwpGnFxk7D7tRRbzkMaW9x56X8lowgHLvOOa9lL8tXWjoplTL Pj3HwH0PFXD4pKMjvAmsy6354tS0IfZ12qur05BbTOPAYgF3oKnBuaHhXKSYTP+B n1sxSFvqyxcHPjLWOQ/hW/796vc0KD86gMO4vz7XaCtt76zfbTA6r3V+QaZBIEoe rAZwnH2aRvRpqCiRjup9gG0lzfqwYrLnWeZraU7Slv9gG5tOv4mg/d5BC1JYt76H fvpucFXs/k3rAJJBO9QT4JwK+IDFgtEBuYQTVJBuLtg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=+bMu1L jjo2MZK0+5p6uccJMVSlWiMcV687SCKmX/GLE=; b=ALlhFNv0fEY/sYD+d1JLtz f4gvXXBcIp3M2SmqW6PeJ7fcwKWC96ME7+J9z055sEfPh6/PikvBo5yFQhx4T7MU AJ90l9QYUnD0iT/RAjHlJxBV48PeqF/3pb8O2W7FRzljGToFZR0Tn9T2XHt+gIz8 louw0ee2Grur0Zjg/QEUzD3Apby+KlezZrcVVdYZ2sznGBjcgWSyVc2ygKn1pMyf F17AJHEOMBtnwFCiDFHA5QJVx1/aa/bse5dBrs4rprNZWS6xCqE+uSOTotJ+5gQe 0ATFip6Gw5KQo5FIW26HdbS4zauIdiyl1Y5yDg+DXwi04Df5kxrxCDTfkLh7o/eg == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrledvgdduvddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpeforgigihhm vgcutfhiphgrrhguuceomhgrgihimhgvsegtvghrnhhordhtvggthheqnecuggftrfgrth htvghrnhepleekgeehhfdutdeljefgleejffehfffgieejhffgueefhfdtveetgeehieeh gedunecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhepmh grgihimhgvsegtvghrnhhordhtvggthh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 17 Aug 2021 03:38:11 -0400 (EDT) Date: Tue, 17 Aug 2021 09:38:10 +0200 From: Maxime Ripard To: Andre Przywara Cc: Chen-Yu Tsai , Jernej Skrabec , Rob Herring , Icenowy Zheng , Samuel Holland , linux-arm-kernel@lists.infradead.org, linux-sunxi@googlegroups.com, linux-sunxi@lists.linux.dev, linux-kernel@vger.kernel.org, Ondrej Jirman , devicetree@vger.kernel.org, Alessandro Zummo , Alexandre Belloni , linux-rtc@vger.kernel.org Subject: Re: [PATCH v8 02/11] dt-bindings: rtc: sun6i: Add H616 compatible string Message-ID: <20210817073810.7stuzrppyjf4spab@gilmour> References: <20210723153838.6785-1-andre.przywara@arm.com> <20210723153838.6785-3-andre.przywara@arm.com> <20210726144137.6dauuxdssu7yszox@gilmour> <20210802013938.29fa18ed@slackpad.fritz.box> MIME-Version: 1.0 In-Reply-To: <20210802013938.29fa18ed@slackpad.fritz.box> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210817_003817_086089_6DFCC8ED X-CRM114-Status: GOOD ( 35.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============6771618284671115179==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============6771618284671115179== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ggkfv7hwuuflnmjz" Content-Disposition: inline --ggkfv7hwuuflnmjz Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi, On Mon, Aug 02, 2021 at 01:39:38AM +0100, Andre Przywara wrote: > On Mon, 26 Jul 2021 16:41:37 +0200 > Maxime Ripard wrote: >=20 > > Hi, > >=20 > > On Fri, Jul 23, 2021 at 04:38:29PM +0100, Andre Przywara wrote: > > > Add the obvious compatible name to the existing RTC binding. > > > The actual RTC part of the device uses a different day/month/year > > > storage scheme, so it's not compatible with the previous devices. > > > Also the clock part is quite different, as there is no external 32K L= OSC > > > oscillator input. > > >=20 > > > Signed-off-by: Andre Przywara > > > > > > --- > > > .../bindings/rtc/allwinner,sun6i-a31-rtc.yaml | 14 ++++++++++++= ++ > > > 1 file changed, 14 insertions(+) > > >=20 > > > diff --git a/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a3= 1-rtc.yaml b/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.= yaml > > > index beeb90e55727..d8a6500e5840 100644 > > > --- a/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.y= aml > > > +++ b/Documentation/devicetree/bindings/rtc/allwinner,sun6i-a31-rtc.y= aml > > > @@ -26,6 +26,7 @@ properties: > > > - const: allwinner,sun50i-a64-rtc > > > - const: allwinner,sun8i-h3-rtc > > > - const: allwinner,sun50i-h6-rtc > > > + - const: allwinner,sun50i-h616-rtc > > > =20 > > > reg: > > > maxItems: 1 > > > @@ -104,6 +105,19 @@ allOf: > > > minItems: 3 > > > maxItems: 3 > > > =20 > > > + - if: > > > + properties: > > > + compatible: > > > + contains: > > > + const: allwinner,sun50i-h616-rtc > > > + > > > + then: > > > + properties: > > > + clock-output-names: > > > + minItems: 3 > > > + maxItems: 3 =20 > >=20 > > You don't need both of them when they are equal > >=20 > > > + clocks: false > > > + =20 > >=20 > > It's not entirely clear to me what those clocks are about though. If we > > look at the clock output in the user manual, it looks like there's only > > two clocks that are actually being output: the 32k "fanout" clock and > > the losc. What are the 3 you're talking about?] >=20 > I see three: the raw SYSTEM "CLK32K_LOSC", the RTC input + debounce > clock (/32), and the multiplexed PAD. But the input and debounce clock is only for the RTC itself right? So it should be local to the driver and doesn't need to be made available to the other drivers Either way, what this list is must be documented. > > Also, it looks like the 32k fanout clock needs at least the hosc or > > pll-periph in input, so we probably don't want to ask for no parent > > clock? >=20 > Well, we never seem to reference the HOSC this way, this was always > somewhat explicit. And yes, there is PLL-PERIPH as an input, but we > don't support this yet. So I went with 0 input clocks *for now*: the > driver can then ignore all clocks, so any clock referenced in the DT > later won't cause any harm. This will all be addressed by Samuel's RTC > clock patch, which will also touch the H6, IIRC. And it looks like we > will need to touch the binding anyway then, but can then just *extend* > this. You mentioned that series several times already and never provided an explanation for what it was supposed to be doing except fixing everything. What's the general plan for that series? Maxime --ggkfv7hwuuflnmjz Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYRtnYgAKCRDj7w1vZxhR xa/CAP9hbwXj022ukapaHrTpQ2r92mfnkV387OMFnrGF9gS4IgD/YU6D6Z6bzoG4 DqHj9PzBXYYPYXEmg4uN6r7bDdNT+QU= =0frR -----END PGP SIGNATURE----- --ggkfv7hwuuflnmjz-- --===============6771618284671115179== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============6771618284671115179==--