All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Pali Rohár" <pali@kernel.org>
To: Heinrich Schuchardt <xypron.glpk@gmx.de>
Cc: "Tom Rini" <trini@konsulko.com>,
	"Marek Behún" <marek.behun@nic.cz>, "Stefan Roese" <sr@denx.de>,
	"Chris Packham" <judge.packham@gmail.com>,
	u-boot@lists.denx.de
Subject: Re: [PATCH 1/1] kwbimage: check fopen() return value
Date: Tue, 17 Aug 2021 10:31:47 +0200	[thread overview]
Message-ID: <20210817083147.c2h2bbj5wo5y7dj6@pali> (raw)
In-Reply-To: <20210817050320.11983-1-xypron.glpk@gmx.de>

On Tuesday 17 August 2021 07:03:20 Heinrich Schuchardt wrote:
> Always check the return value of fopen().
> 
> This resolves Coverity CID 338491:
> Null pointer dereferences (NULL_RETURNS)
> 
> Signed-off-by: Heinrich Schuchardt <xypron.glpk@gmx.de>

Reviewed-by: Pali Rohár <pali@kernel.org>

> ---
>  tools/kwbimage.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/tools/kwbimage.c b/tools/kwbimage.c
> index 00cb338d64..2a10df773b 100644
> --- a/tools/kwbimage.c
> +++ b/tools/kwbimage.c
> @@ -832,6 +832,12 @@ static int kwb_dump_fuse_cmds(struct secure_hdr_v1 *sec_hdr)
>  	if (!strcmp(e->name, "a38x")) {
>  		FILE *out = fopen("kwb_fuses_a38x.txt", "w+");
> 
> +		if (!out) {
> +			fprintf(stderr, "Couldn't open eFuse settings: '%s': %s\n",
> +				"kwb_fuses_a38x.txt", strerror(errno));
> +			return -ENOENT;
> +		}
> +
>  		kwb_dump_fuse_cmds_38x(out, sec_hdr);
>  		fclose(out);
>  		goto done;
> @@ -1060,6 +1066,11 @@ int export_pub_kak_hash(RSA *kak, struct secure_hdr_v1 *secure_hdr)
>  	int res;
> 
>  	hashf = fopen("pub_kak_hash.txt", "w");
> +	if (!hashf) {
> +		fprintf(stderr, "Couldn't open hash file: '%s': %s\n",
> +			"pub_kak_hash.txt", strerror(errno));
> +		return 1;
> +	}
> 
>  	res = kwb_export_pubkey(kak, &secure_hdr->kak, hashf, "KAK");
> 
> --
> 2.30.2
> 

  parent reply	other threads:[~2021-08-17  8:31 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17  5:03 [PATCH 1/1] kwbimage: check fopen() return value Heinrich Schuchardt
2021-08-17  6:46 ` Stefan Roese
2021-08-17  8:31 ` Pali Rohár [this message]
2021-09-01  9:14 ` Stefan Roese

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210817083147.c2h2bbj5wo5y7dj6@pali \
    --to=pali@kernel.org \
    --cc=judge.packham@gmail.com \
    --cc=marek.behun@nic.cz \
    --cc=sr@denx.de \
    --cc=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    --cc=xypron.glpk@gmx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.