From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 22363C4338F for ; Tue, 17 Aug 2021 11:02:56 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 32B5360E76 for ; Tue, 17 Aug 2021 11:02:55 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 32B5360E76 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 3235C81BC8; Tue, 17 Aug 2021 13:02:53 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="cH/muE5P"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 3B1F282051; Tue, 17 Aug 2021 13:02:51 +0200 (CEST) Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D6FBD801FD for ; Tue, 17 Aug 2021 13:02:45 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: by mail.kernel.org (Postfix) with ESMTPSA id D146E60E76; Tue, 17 Aug 2021 11:02:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629198164; bh=agkcCaFXHlVV5KKKYJFLbZunhnc0iUHlGjdr0Ulu3bo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=cH/muE5P1ahfFltQ3sEKE7WelhvLoiVfHy0rYqfMC80xY1OOhYdqfGThNLrb7y50p 6QBYjFjJ9TcIMVL0vLls7xPa37Dumf2dZMS1PyEXvE9tcdfY06fuDxXQzWb5uVMenX E6cmX9n78VfOtx0kZFCqEQaIumrVO4YNPWwfH0JLk5c9mxkPRU7ECOC//5xw71lF58 or1z348XZoKPwvZiwvuHEtBlxkARMySF3cYFLCv47gNb1N609gDVX+2MfddxwhCjEU 4T5pyw6SnFX63OqovnpVeNJ8amjpAY2aKXSqu0b3ndYA60xlfqMvQWZf+ytskwc98S y8iwdEM3w33jg== Received: by pali.im (Postfix) id 8E0A1842; Tue, 17 Aug 2021 13:02:41 +0200 (CEST) Date: Tue, 17 Aug 2021 13:02:41 +0200 From: Pali =?utf-8?B?Um9ow6Fy?= To: Simon Glass , Heinrich Schuchardt , Alexander Graf , Huan Wang , Angelo Dureghello , Wolfgang Denk , Priyanka Jain , Christophe Leroy , Bin Meng , Marek =?utf-8?B?QmVow7pu?= , Tom Rini Cc: u-boot@lists.denx.de Subject: Re: [PATCH 00/11] Reduce usage of timestamp macros Message-ID: <20210817110241.bzqk5sr44kmcmkc4@pali> References: <20210802131838.21097-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20210802131838.21097-1-pali@kernel.org> User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Monday 02 August 2021 15:18:27 Pali Rohár wrote: > Including timestamp.h (either directly or transitionally) cause build > system to recompile binaries at every 'make' run. This has disadvantage > in U-Boot development as for every small change 'make' recompiles lot of > other irrelevant files which were not touched / changed. > > This patch series eliminate transitional / indirect usage of > timestamp.h by removing unneeded inclusion of header files, moving > timestamp values from macros to global variables, etc... > > After these patches, U-Boot tools are not recompiled by every 'make' run, > which decrease time for incremental U-Boot recompilation. > > Please test these patches, specially m68k and powerpc parts as I do not > have any of these boards. > > Patch series depend on this patch (now marked as accepted): > http://patchwork.ozlabs.org/project/uboot/patch/20210710111001.32325-1-pali@kernel.org/ Hello! Is there anything else needed for this patch series? > Pali Rohár (11): > Remove #include from files which do not need it > Remove #include from files which do not need it > efi_loader: Use directly version_string variable > version: Move version_string[] from version.h to version_string.h > m68k: mcf: Remove overloading version_string > version: Put version_string[] variable into section > .text_version_string > powerpc: mpc: Put U-Boot version string at correct place by linker > script > version: Do not make version_string[] variable as a weak > x86: quark: MRC: Remove U_BOOT_DATE and U_BOOT_TIME from debug log > version: Remove global macro U_BOOT_VERSION_STRING from version.h > Remove including timestamp.h in version.h > > arch/arm/mach-rockchip/px30-board-tpl.c | 1 - > arch/arm/mach-rockchip/tpl.c | 4 ++++ > arch/m68k/cpu/mcf5227x/start.S | 6 ------ > arch/m68k/cpu/mcf523x/start.S | 6 ------ > arch/m68k/cpu/mcf52x2/start.S | 6 ------ > arch/m68k/cpu/mcf530x/start.S | 8 ------- > arch/m68k/cpu/mcf532x/start.S | 6 ------ > arch/m68k/cpu/mcf5445x/start.S | 7 ------- > arch/nios2/cpu/start.S | 1 - > arch/powerpc/cpu/mpc83xx/start.S | 10 +++------ > arch/powerpc/cpu/mpc83xx/u-boot.lds | 3 +++ > arch/powerpc/cpu/mpc85xx/start.S | 10 ++++----- > arch/powerpc/cpu/mpc85xx/u-boot-nand.lds | 4 ++++ > arch/powerpc/cpu/mpc85xx/u-boot-spl.lds | 4 ++++ > arch/powerpc/cpu/mpc85xx/u-boot.lds | 4 ++++ > arch/powerpc/cpu/mpc8xx/start.S | 9 ++++---- > arch/x86/cpu/quark/mrc.c | 4 +--- > arch/x86/lib/acpi_table.c | 1 - > board/atmel/sama5d2_ptc_ek/sama5d2_ptc_ek.c | 1 - > board/cssi/MCR3000/u-boot.lds | 2 ++ > board/ge/b1x5v2/b1x5v2.c | 2 +- > board/ge/bx50v3/bx50v3.c | 2 +- > board/ge/mx53ppd/mx53ppd.c | 2 +- > board/l+g/vinco/vinco.c | 1 - > board/renesas/grpeach/lowlevel_init.S | 1 - > .../work_92105/work_92105_display.c | 1 + > cmd/version.c | 7 ++++++- > common/main.c | 2 +- > common/spl/spl.c | 4 ++++ > doc/develop/version.rst | 21 +++++++++++-------- > drivers/rtc/emul_rtc.c | 2 +- > drivers/usb/gadget/f_rockusb.c | 1 - > drivers/video/cfb_console.c | 3 +-- > include/configs/bcmstb.h | 1 - > include/version.h | 8 ------- > include/version_string.h | 8 +++++++ > lib/display_options.c | 2 +- > lib/efi_loader/efi_tcg2.c | 7 +++---- > net/cdp.c | 3 --- > test/print_ut.c | 2 +- > 40 files changed, 75 insertions(+), 102 deletions(-) > create mode 100644 include/version_string.h > > -- > 2.20.1 >