From: "Russell King (Oracle)" <linux@armlinux.org.uk>
To: Jie Luo <luoj@codeaurora.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
hkallweit1@gmail.com, davem@davemloft.net, kuba@kernel.org,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
sricharan@codeaurora.org
Subject: Re: [PATCH] net: phy: add qca8081 ethernet phy driver
Date: Tue, 17 Aug 2021 15:32:26 +0100 [thread overview]
Message-ID: <20210817143226.GL22278@shell.armlinux.org.uk> (raw)
In-Reply-To: <6856a839-0fa0-1240-47cd-ae8536294bcd@codeaurora.org>
On Tue, Aug 17, 2021 at 09:10:44PM +0800, Jie Luo wrote:
>
> On 8/16/2021 9:56 PM, Andrew Lunn wrote:
> > On Mon, Aug 16, 2021 at 07:34:40PM +0800, Luo Jie wrote:
> > > qca8081 is industry’s lowest cost and power 1-port 2.5G/1G Ethernet PHY
> > > chip, which implements SGMII/SGMII+ for interface to SoC.
> > Hi Luo
> >
> > No Marketing claims in the commit message please. Even if it is
> > correct now, it will soon be wrong with newer generations of
> > devices.
> >
> > And what is SGMII+? Please reference a document. Is it actually
> > 2500BaseX?
>
> Hi Andrew,
>
> thanks for the comments, will remove the claims in the next patch.
>
> SGMII+ is for 2500BaseX, which is same as SGMII, but the clock frequency of
> SGMII+ is 2.5 times SGMII.
Bah. Sounds like more industry wide misunderstanding of what SGMII
vs 1000Base-X is to me... or just plain abuse of the term "SGMII"!
I think you'll find that "SGMII+" is nothing but a term Qualcomm use
to refer to 2500BASE-X without the 16-bit in-band control word to
the host.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
next prev parent reply other threads:[~2021-08-17 14:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-16 11:34 [PATCH] net: phy: add qca8081 ethernet phy driver Luo Jie
2021-08-16 13:56 ` Andrew Lunn
2021-08-17 13:10 ` Jie Luo
2021-08-17 13:33 ` Andrew Lunn
2021-08-18 13:21 ` Jie Luo
2021-08-17 14:32 ` Russell King (Oracle) [this message]
2021-08-18 7:41 ` Michael Walle
2021-08-18 13:34 ` Jie Luo
2021-08-18 17:09 ` Andrew Lunn
2021-08-19 10:30 ` Jie Luo
2021-08-16 14:01 ` Russell King (Oracle)
2021-08-17 13:16 ` Jie Luo
2021-08-16 15:27 ` Heiner Kallweit
2021-08-17 14:27 ` Jie Luo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210817143226.GL22278@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luoj@codeaurora.org \
--cc=netdev@vger.kernel.org \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.