From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 28E62C432BE for ; Tue, 17 Aug 2021 15:13:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DA7CD60FA0 for ; Tue, 17 Aug 2021 15:13:27 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DA7CD60FA0 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0B1826E041; Tue, 17 Aug 2021 15:13:25 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6CB076E03C; Tue, 17 Aug 2021 15:13:23 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10079"; a="196381182" X-IronPort-AV: E=Sophos;i="5.84,329,1620716400"; d="scan'208";a="196381182" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2021 08:13:22 -0700 X-IronPort-AV: E=Sophos;i="5.84,329,1620716400"; d="scan'208";a="680397106" Received: from jons-linux-dev-box.fm.intel.com (HELO jons-linux-dev-box) ([10.1.27.20]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2021 08:13:22 -0700 Date: Tue, 17 Aug 2021 08:08:09 -0700 From: Matthew Brost To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, daniel.vetter@ffwll.ch Subject: Re: [PATCH 06/22] drm/i915/execlists: Do not propagate errors to dependent fences Message-ID: <20210817150809.GA19163@jons-linux-dev-box> References: <20210816135139.10060-1-matthew.brost@intel.com> <20210816135139.10060-7-matthew.brost@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" On Tue, Aug 17, 2021 at 11:21:27AM +0200, Daniel Vetter wrote: > On Mon, Aug 16, 2021 at 06:51:23AM -0700, Matthew Brost wrote: > > Progagating errors to dependent fences is wrong, don't do it. Selftest > > in following patch exposes this bug. > > Please explain what "this bug" is, it's hard to read minds, especially at > a distance in spacetime :-) > Not a very good explaination. > > Fixes: 8e9f84cf5cac ("drm/i915/gt: Propagate change in error status to children on unhold") > > I think it would be better to outright revert this, instead of just > disabling it like this. > I tried revert and git did some really odd things that I couldn't resolve, hence the new patch. > Also please cite the dma_fence error propagation revert from Jason: > > commit 93a2711cddd5760e2f0f901817d71c93183c3b87 > Author: Jason Ekstrand > Date: Wed Jul 14 14:34:16 2021 -0500 > > Revert "drm/i915: Propagate errors on awaiting already signaled fences" > > Maybe in full, if you need the justification. > Will site. > > Signed-off-by: Matthew Brost > > Cc: > > Unless "this bug" is some real world impact thing I wouldn't put cc: > stable on this. Got it. Matt > -Daniel > > --- > > drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c > > index de5f9c86b9a4..cafb0608ffb4 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c > > +++ b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c > > @@ -2140,10 +2140,6 @@ static void __execlists_unhold(struct i915_request *rq) > > if (p->flags & I915_DEPENDENCY_WEAK) > > continue; > > > > - /* Propagate any change in error status */ > > - if (rq->fence.error) > > - i915_request_set_error_once(w, rq->fence.error); > > - > > if (w->engine != rq->engine) > > continue; > > > > -- > > 2.32.0 > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 77C97C4338F for ; Tue, 17 Aug 2021 15:13:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0CA1F60524 for ; Tue, 17 Aug 2021 15:13:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 0CA1F60524 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.freedesktop.org Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 749016E03C; Tue, 17 Aug 2021 15:13:24 +0000 (UTC) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6CB076E03C; Tue, 17 Aug 2021 15:13:23 +0000 (UTC) X-IronPort-AV: E=McAfee;i="6200,9189,10079"; a="196381182" X-IronPort-AV: E=Sophos;i="5.84,329,1620716400"; d="scan'208";a="196381182" Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga107.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2021 08:13:22 -0700 X-IronPort-AV: E=Sophos;i="5.84,329,1620716400"; d="scan'208";a="680397106" Received: from jons-linux-dev-box.fm.intel.com (HELO jons-linux-dev-box) ([10.1.27.20]) by fmsmga005-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 17 Aug 2021 08:13:22 -0700 Date: Tue, 17 Aug 2021 08:08:09 -0700 From: Matthew Brost To: Daniel Vetter Cc: intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, daniel.vetter@ffwll.ch Message-ID: <20210817150809.GA19163@jons-linux-dev-box> References: <20210816135139.10060-1-matthew.brost@intel.com> <20210816135139.10060-7-matthew.brost@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Subject: Re: [Intel-gfx] [PATCH 06/22] drm/i915/execlists: Do not propagate errors to dependent fences X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" On Tue, Aug 17, 2021 at 11:21:27AM +0200, Daniel Vetter wrote: > On Mon, Aug 16, 2021 at 06:51:23AM -0700, Matthew Brost wrote: > > Progagating errors to dependent fences is wrong, don't do it. Selftest > > in following patch exposes this bug. > > Please explain what "this bug" is, it's hard to read minds, especially at > a distance in spacetime :-) > Not a very good explaination. > > Fixes: 8e9f84cf5cac ("drm/i915/gt: Propagate change in error status to children on unhold") > > I think it would be better to outright revert this, instead of just > disabling it like this. > I tried revert and git did some really odd things that I couldn't resolve, hence the new patch. > Also please cite the dma_fence error propagation revert from Jason: > > commit 93a2711cddd5760e2f0f901817d71c93183c3b87 > Author: Jason Ekstrand > Date: Wed Jul 14 14:34:16 2021 -0500 > > Revert "drm/i915: Propagate errors on awaiting already signaled fences" > > Maybe in full, if you need the justification. > Will site. > > Signed-off-by: Matthew Brost > > Cc: > > Unless "this bug" is some real world impact thing I wouldn't put cc: > stable on this. Got it. Matt > -Daniel > > --- > > drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 4 ---- > > 1 file changed, 4 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c > > index de5f9c86b9a4..cafb0608ffb4 100644 > > --- a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c > > +++ b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c > > @@ -2140,10 +2140,6 @@ static void __execlists_unhold(struct i915_request *rq) > > if (p->flags & I915_DEPENDENCY_WEAK) > > continue; > > > > - /* Propagate any change in error status */ > > - if (rq->fence.error) > > - i915_request_set_error_once(w, rq->fence.error); > > - > > if (w->engine != rq->engine) > > continue; > > > > -- > > 2.32.0 > > > > -- > Daniel Vetter > Software Engineer, Intel Corporation > http://blog.ffwll.ch