All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Paul E. McKenney" <paulmck@kernel.org>
To: Akira Yokosawa <akiyks@gmail.com>
Cc: perfbook@vger.kernel.org
Subject: Re: [PATCH -perfbook 04/11] Add \ignorespaces command to \IfEbookSize and \IfSansSerif
Date: Tue, 17 Aug 2021 11:29:51 -0700	[thread overview]
Message-ID: <20210817182951.GP4126399@paulmck-ThinkPad-P17-Gen-1> (raw)
In-Reply-To: <82871fad-83e9-6d46-7e6c-d01a558d8dd5@gmail.com>

On Tue, Aug 17, 2021 at 07:21:27PM +0900, Akira Yokosawa wrote:
> Using \IfEbookSize or \IfSansSerif macro in the middle of a paragraph
> can cause extra white spaces around it.
> Fix this by adding the \ignorespaces command in their definitions.
> 
> Also update the conditional text in styleguide.
> 
> As the other conditional macros aren't used in this manner, they are
> not modified for the moment.
> 
> Signed-off-by: Akira Yokosawa <akiyks@gmail.com>
> ---
>  appendix/styleguide/styleguide.tex | 5 +++--
>  perfbook-lt.tex                    | 6 ++++--
>  2 files changed, 7 insertions(+), 4 deletions(-)
> 
> diff --git a/appendix/styleguide/styleguide.tex b/appendix/styleguide/styleguide.tex
> index 9bb9683f..24e891a3 100644
> --- a/appendix/styleguide/styleguide.tex
> +++ b/appendix/styleguide/styleguide.tex
> @@ -1013,8 +1013,9 @@ namely \qco{$-$}.\footnote{This rule assumes that math mode uses the
>    same upright glyph as text mode.
>    Our default font choice meets the assumption.
>  \IfSansSerif{
> -  One of the experimental targets ``1csf'' \emph{does} use a differnt font
> -  for math mode figures as of October 2017.}{}
> +  Experimental targets with sans-serif fonts such as
> +  ``1csf'' and ``ebsf'' \emph{do} use a differnt font

I did s/differnt/different/ here.  This looks like the sort of typo
that I would make!  ;-)

							Thanx, Paul

> +  for math mode figures as of August 2021.}{}
>  }
>  For example,
>  
> diff --git a/perfbook-lt.tex b/perfbook-lt.tex
> index 62959e04..b1c4f780 100644
> --- a/perfbook-lt.tex
> +++ b/perfbook-lt.tex
> @@ -117,13 +117,15 @@
>  \newcommand{\IfHardCover}[2]{\ifthenelse{\boolean{hardcover}}{#1}{#2}}
>  \newboolean{ebooksize}
>  \setboolean{ebooksize}{false}
> -\newcommand{\IfEbookSize}[2]{\ifthenelse{\boolean{ebooksize}}{#1}{#2}}
> +\newcommand{\IfEbookSize}[2]{\ifthenelse{\boolean{ebooksize}}%
> +  {\ignorespaces#1\ignorespaces}{\ignorespaces#2\ignorespaces}}
>  \newboolean{afourpaper}
>  \setboolean{afourpaper}{false}
>  \newcommand{\IfAfourPaper}[2]{\ifthenelse{\boolean{afourpaper}}{#1}{#2}}
>  \newboolean{sansserif}
>  \setboolean{sansserif}{false}
> -\newcommand{\IfSansSerif}[2]{\ifthenelse{\boolean{sansserif}}{#1}{#2}}
> +\newcommand{\IfSansSerif}[2]{\ifthenelse{\boolean{sansserif}}%
> +  {\ignorespaces#1\ignorespaces}{\ignorespaces#2\ignorespaces}}
>  \newboolean{lmttforcode}
>  \setboolean{lmttforcode}{true}
>  \newcommand{\IfLmttForCode}[2]{\ifthenelse{\boolean{lmttforcode}}{#1}{#2}}
> -- 
> 2.17.1
> 
> 

  reply	other threads:[~2021-08-17 18:30 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17 10:14 [PATCH -perfbook 00/11] Break and capitalize after colon, take four Akira Yokosawa
2021-08-17 10:16 ` [PATCH -perfbook 01/11] appendix, glossary: Break and capitalize after colon Akira Yokosawa
2021-08-17 10:18 ` [PATCH -perfbook 02/11] glossary: Put missing question mark Akira Yokosawa
2021-08-17 10:19 ` [PATCH -perfbook 03/11] treewide: Adjust punctuation convention Akira Yokosawa
2021-08-17 10:21 ` [PATCH -perfbook 04/11] Add \ignorespaces command to \IfEbookSize and \IfSansSerif Akira Yokosawa
2021-08-17 18:29   ` Paul E. McKenney [this message]
2021-08-17 20:22     ` Paul E. McKenney
2021-08-17 23:31     ` Akira Yokosawa
2021-08-17 23:50       ` Paul E. McKenney
2021-08-17 10:23 ` [PATCH -perfbook 05/11] datastruct: Use \tco{} inside inline enumerate list Akira Yokosawa
2021-08-17 10:29 ` [PATCH -perfbook 06/11] periodcheck: Add colon-related checks Akira Yokosawa
2021-08-17 10:33 ` [PATCH -perfbook 07/11] cleverefcheck: Check lower-case word after \item Akira Yokosawa
2021-08-17 10:35 ` [PATCH -perfbook 08/11] periodcheck: Improve regex Akira Yokosawa
2021-08-17 10:37 ` [PATCH -perfbook 09/11] periodcheck: Use counter to prevent false negatives Akira Yokosawa
2021-08-17 10:39 ` [PATCH -perfbook 10/11] cleverefcheck: Add pattern to catch typo in indexing macros Akira Yokosawa
2021-08-17 10:40 ` [PATCH -perfbook 11/11] Makefile: Rename periodcheck --> punctcheck Akira Yokosawa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210817182951.GP4126399@paulmck-ThinkPad-P17-Gen-1 \
    --to=paulmck@kernel.org \
    --cc=akiyks@gmail.com \
    --cc=perfbook@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.