From: fankaixi.li@bytedance.com
To: dev@openvswitch.org, netdev@vger.kernel.org
Cc: "kaixi . fan" <fankaixi.li@bytedance.com>,
xiexiaohui <xiexiaohui.xxh@bytedance.com>,
Cong Wang <cong.wang@bytedance.com>
Subject: [PATCH] ovs: clear skb->tstamp in forwarding path
Date: Wed, 18 Aug 2021 10:22:15 +0800 [thread overview]
Message-ID: <20210818022215.5979-1-fankaixi.li@bytedance.com> (raw)
From: kaixi.fan <fankaixi.li@bytedance.com>
fq qdisc requires tstamp to be cleared in the forwarding path. Now ovs
doesn't clear skb->tstamp. We encountered a problem with linux
version 5.4.56 and ovs version 2.14.1, and packets failed to
dequeue from qdisc when fq qdisc was attached to ovs port.
Signed-off-by: kaixi.fan <fankaixi.li@bytedance.com>
Signed-off-by: xiexiaohui <xiexiaohui.xxh@bytedance.com>
Reviewed-by: Cong Wang <cong.wang@bytedance.com>
---
net/openvswitch/vport.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/net/openvswitch/vport.c b/net/openvswitch/vport.c
index 88deb5b41429..cf2ce5812489 100644
--- a/net/openvswitch/vport.c
+++ b/net/openvswitch/vport.c
@@ -507,6 +507,7 @@ void ovs_vport_send(struct vport *vport, struct sk_buff *skb, u8 mac_proto)
}
skb->dev = vport->dev;
+ skb->tstamp = 0;
vport->ops->send(skb);
return;
--
2.20.1
next reply other threads:[~2021-08-18 2:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 2:22 fankaixi.li [this message]
2021-08-18 9:32 ` [PATCH] ovs: clear skb->tstamp in forwarding path Eric Dumazet
2021-08-19 2:06 ` [External] " 范开喜
2021-08-18 10:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210818022215.5979-1-fankaixi.li@bytedance.com \
--to=fankaixi.li@bytedance.com \
--cc=cong.wang@bytedance.com \
--cc=dev@openvswitch.org \
--cc=netdev@vger.kernel.org \
--cc=xiexiaohui.xxh@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.