From: Adrian Huang <adrianhuang0701@gmail.com>
To: linux-acpi@vger.kernel.org
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
Adrian Huang <adrianhuang0701@gmail.com>,
Zhang Rui <rui.zhang@intel.com>,
Adrian Huang <ahuang12@lenovo.com>
Subject: [PATCH 1/1] ACPI: tables: FPDT: Do not print FW_BUG message if subtable types are reserved
Date: Wed, 18 Aug 2021 14:38:31 +0800 [thread overview]
Message-ID: <20210818063831.1349-1-adrianhuang0701@gmail.com> (raw)
From: Adrian Huang <ahuang12@lenovo.com>
Table 5.90 "Runtime Performance Record Types" in ACPI 6.4 spec [1] says:
These type values "0x0003-0xFFFF" of Runtime Performance Record Types
are reserved for ACPI spec usage, platform vendor usage, hardware
vendor usage, platform firmware vendor usage and future use.
Users might be confused with the FW_BUG message, and they think this
is the FW issue. Here is the example in a Lenovo box:
ACPI: FPDT 0x00000000A820A000 000044 (v01 LENOVO THINKSYS 00000100 01000013)
ACPI: Reserving FPDT table memory at [mem 0xa820a000-0xa820a043]
ACPI FPDT: [Firmware Bug]: Invalid record 4113 found
So, remove the FW_BUG message to avoid confusion since those subtable
types are reserved in ACPI 6.4 spec.
[1] https://uefi.org/specs/ACPI/6.4/05_ACPI_Software_Programming_Model/ACPI_Software_Programming_Model.html#firmware-performance-data-table-fpdt
Cc: Zhang Rui <rui.zhang@intel.com>
Signed-off-by: Adrian Huang <ahuang12@lenovo.com>
---
drivers/acpi/acpi_fpdt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/acpi/acpi_fpdt.c b/drivers/acpi/acpi_fpdt.c
index 4ee2ad234e3d..568f26a7490a 100644
--- a/drivers/acpi/acpi_fpdt.c
+++ b/drivers/acpi/acpi_fpdt.c
@@ -220,8 +220,8 @@ static int fpdt_process_subtable(u64 address, u32 subtable_type)
break;
default:
- pr_err(FW_BUG "Invalid record %d found.\n", record_header->type);
- return -EINVAL;
+ /* Other types are reserved in ACPI 6.4 spec. */
+ break;
}
}
return 0;
--
2.25.1
next reply other threads:[~2021-08-18 6:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-18 6:38 Adrian Huang [this message]
2021-08-19 2:56 ` [PATCH 1/1] ACPI: tables: FPDT: Do not print FW_BUG message if subtable types are reserved Zhang Rui
2021-08-19 3:40 ` Huang Adrian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210818063831.1349-1-adrianhuang0701@gmail.com \
--to=adrianhuang0701@gmail.com \
--cc=ahuang12@lenovo.com \
--cc=linux-acpi@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.