From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from wnew1-smtp.messagingengine.com (wnew1-smtp.messagingengine.com [64.147.123.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BA472168 for ; Wed, 18 Aug 2021 09:08:14 +0000 (UTC) Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id C6E882B0094B; Wed, 18 Aug 2021 05:08:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 18 Aug 2021 05:08:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=u9bG+4wNqQW8Q6ftF5wHQm+W0Hy eApI0kU8bT7jSU/c=; b=m1Adjwfyy82QgScHp5ILIDVbEAsjmFORFv9pNabBwPJ F1/P+tk4/cU8T3soyPdWUKm4JQ/iq21hmkUwP1pAlKaA7P3cVrAgATLPi0hczis8 UKs86hdgn7GnPslnnFqoJdLgQ96c02uDzPcsiaeeH8oocsH8Pj90PfDEtkrVj5pH Ndn6xSVUIjVeKIYNc84kt7Nqdx7Dg/f1fg8kRTvfKe7+60PUzkZTO6BneE7fsRSd sKoqPANqKN+mp5D1SJn+qbOoczQHr/MLq/RytpzIRceLjfRHCzpHvFrqm6EqV1kw 1BDpZ5dchtjnRZ1Rs6Xs+eQCDOy6Sx7uehvJAWuCeEQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=u9bG+4 wNqQW8Q6ftF5wHQm+W0HyeApI0kU8bT7jSU/c=; b=YDs2dIaOKPv/sslas828D5 kvFzgLVrgGzXTYZ5oXjIaLf4ddCH+L756U2tcFu5WTXMRniVIQV8ERt405RfMbMc lXc/gi9xKEIkGuKA8RtvvG5AlIoXdsUIRpr5Sh4rdvoL/dJxMZ6jIUBOYoMR8yei Go5smI8B0r7DzmUzMoQosTplEZOO7rT++WDiheThaJmAVpZs3WEfVbnhUiBIfmMh 9SxO1O6nXlrTfKKJ7hYnV8yzd8Vd7w84Igx6o6Hq0aa12XhhO78+BDFHcDO8Oocf 2+ICa5PtP8G2Oa1i+Gj2JAZQqm0VTe2bIoK/kdRKRQXBZmzlR1wMyFyHKPiiACFQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrleehgdduvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg igihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 18 Aug 2021 05:08:12 -0400 (EDT) Date: Wed, 18 Aug 2021 11:08:11 +0200 From: Maxime Ripard To: Samuel Holland Cc: Wim Van Sebroeck , Guenter Roeck , Rob Herring , Chen-Yu Tsai , Jernej Skrabec , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] watchdog: sunxi_wdt: Add support for D1 Message-ID: <20210818090811.fl7u4jtxh4ko7j3c@gilmour> References: <20210805045716.46141-1-samuel@sholland.org> <20210805045716.46141-3-samuel@sholland.org> Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4cs6fzq5kbpskuj3" Content-Disposition: inline In-Reply-To: <20210805045716.46141-3-samuel@sholland.org> --4cs6fzq5kbpskuj3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 04, 2021 at 11:57:16PM -0500, Samuel Holland wrote: > D1 adds a key field to the "CFG" and "MODE" registers, that must be set > to change the other bits. Add logic to set the key when updating those > registers. >=20 > Reviewed-by: Guenter Roeck > Signed-off-by: Samuel Holland Acked-by: Maxime Ripard Maxime --4cs6fzq5kbpskuj3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYRzN+wAKCRDj7w1vZxhR xYLRAPoC8/IXiSXIcg2lYUl8qma4+EbErj5NI79KPiJaHThQRQD/Xiy5hmEcNhit wILOH0oJ88MjIB57FIGoZGAHDBETIQg= =999a -----END PGP SIGNATURE----- --4cs6fzq5kbpskuj3-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5E2FEC4338F for ; Wed, 18 Aug 2021 09:10:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2E32760FDA for ; Wed, 18 Aug 2021 09:10:39 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2E32760FDA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=cerno.tech Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=DFxdP7qj5kmIwOPlYnG+snpbdyUViP1GOrueireJLRE=; b=UCL6UZoBU+4w1aUp3x7KSzAF/4 jAVQi0ulhP8G5ojrSEo7dNDg2husr9J1ywuf2LUlfHlEWfDbohb6svBTu13FYjqBjYMW3a0y8156s /N0DUopwvQaKaZmVMQ2amudsnfhcEusI5zvBdOP4FLL/W2X5dvDnSHBmHWnOczHbgZuktHlDAbqRe GlyuyRnnYx+LRS3adFTBDBKb1TNwCu8gm5Jgn7rYgFdFGJ16eDvvh9z5phTelgwLnIBnO85pw7ETW cwacbBABY5lfxDLxjZx+EyG62eqY7PIFue9fhtN4q4ml4imo+Cam2tf3eQSWOZ2c2COpSWczp+JnD Cbwri2xg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGHYc-004n5a-O7; Wed, 18 Aug 2021 09:08:22 +0000 Received: from wnew1-smtp.messagingengine.com ([64.147.123.26]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGHYU-004n3z-TW for linux-arm-kernel@lists.infradead.org; Wed, 18 Aug 2021 09:08:19 +0000 Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailnew.west.internal (Postfix) with ESMTP id C6E882B0094B; Wed, 18 Aug 2021 05:08:13 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 18 Aug 2021 05:08:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cerno.tech; h= date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=fm3; bh=u9bG+4wNqQW8Q6ftF5wHQm+W0Hy eApI0kU8bT7jSU/c=; b=m1Adjwfyy82QgScHp5ILIDVbEAsjmFORFv9pNabBwPJ F1/P+tk4/cU8T3soyPdWUKm4JQ/iq21hmkUwP1pAlKaA7P3cVrAgATLPi0hczis8 UKs86hdgn7GnPslnnFqoJdLgQ96c02uDzPcsiaeeH8oocsH8Pj90PfDEtkrVj5pH Ndn6xSVUIjVeKIYNc84kt7Nqdx7Dg/f1fg8kRTvfKe7+60PUzkZTO6BneE7fsRSd sKoqPANqKN+mp5D1SJn+qbOoczQHr/MLq/RytpzIRceLjfRHCzpHvFrqm6EqV1kw 1BDpZ5dchtjnRZ1Rs6Xs+eQCDOy6Sx7uehvJAWuCeEQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; bh=u9bG+4 wNqQW8Q6ftF5wHQm+W0HyeApI0kU8bT7jSU/c=; b=YDs2dIaOKPv/sslas828D5 kvFzgLVrgGzXTYZ5oXjIaLf4ddCH+L756U2tcFu5WTXMRniVIQV8ERt405RfMbMc lXc/gi9xKEIkGuKA8RtvvG5AlIoXdsUIRpr5Sh4rdvoL/dJxMZ6jIUBOYoMR8yei Go5smI8B0r7DzmUzMoQosTplEZOO7rT++WDiheThaJmAVpZs3WEfVbnhUiBIfmMh 9SxO1O6nXlrTfKKJ7hYnV8yzd8Vd7w84Igx6o6Hq0aa12XhhO78+BDFHcDO8Oocf 2+ICa5PtP8G2Oa1i+Gj2JAZQqm0VTe2bIoK/kdRKRQXBZmzlR1wMyFyHKPiiACFQ == X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvtddrleehgdduvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepofgrgihimhgv ucftihhprghrugcuoehmrgigihhmvgestggvrhhnohdrthgvtghhqeenucggtffrrghtth gvrhhnpeelkeeghefhuddtleejgfeljeffheffgfeijefhgfeufefhtdevteegheeiheeg udenucevlhhushhtvghrufhiiigvpedunecurfgrrhgrmhepmhgrihhlfhhrohhmpehmrg igihhmvgestggvrhhnohdrthgvtghh X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 18 Aug 2021 05:08:12 -0400 (EDT) Date: Wed, 18 Aug 2021 11:08:11 +0200 From: Maxime Ripard To: Samuel Holland Cc: Wim Van Sebroeck , Guenter Roeck , Rob Herring , Chen-Yu Tsai , Jernej Skrabec , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-sunxi@lists.linux.dev, linux-watchdog@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/3] watchdog: sunxi_wdt: Add support for D1 Message-ID: <20210818090811.fl7u4jtxh4ko7j3c@gilmour> References: <20210805045716.46141-1-samuel@sholland.org> <20210805045716.46141-3-samuel@sholland.org> MIME-Version: 1.0 In-Reply-To: <20210805045716.46141-3-samuel@sholland.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210818_020815_041489_45C85AD0 X-CRM114-Status: GOOD ( 11.82 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============8203212670446364011==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============8203212670446364011== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="4cs6fzq5kbpskuj3" Content-Disposition: inline --4cs6fzq5kbpskuj3 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Aug 04, 2021 at 11:57:16PM -0500, Samuel Holland wrote: > D1 adds a key field to the "CFG" and "MODE" registers, that must be set > to change the other bits. Add logic to set the key when updating those > registers. >=20 > Reviewed-by: Guenter Roeck > Signed-off-by: Samuel Holland Acked-by: Maxime Ripard Maxime --4cs6fzq5kbpskuj3 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEABYIAB0WIQRcEzekXsqa64kGDp7j7w1vZxhRxQUCYRzN+wAKCRDj7w1vZxhR xYLRAPoC8/IXiSXIcg2lYUl8qma4+EbErj5NI79KPiJaHThQRQD/Xiy5hmEcNhit wILOH0oJ88MjIB57FIGoZGAHDBETIQg= =999a -----END PGP SIGNATURE----- --4cs6fzq5kbpskuj3-- --===============8203212670446364011== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============8203212670446364011==--