All of lore.kernel.org
 help / color / mirror / Atom feed
From: "jay.xu@rock-chips.com" <jay.xu@rock-chips.com>
To: "Mark Brown" <broonie@kernel.org>
Cc: lgirdwood <lgirdwood@gmail.com>,
	"ulf.hansson" <ulf.hansson@linaro.org>,
	"Lee Jones" <lee.jones@linaro.org>,
	"Zhang Changzhong" <zhangchangzhong@huawei.com>,
	"Heiko Stübner" <heiko@sntech.de>,
	"open list:ARM/Rockchip SoC..."
	<linux-rockchip@lists.infradead.org>,
	"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: Re: [PATCH v2 3/3] soc: rockchip: io-domain: do more thing about regulator notify
Date: Wed, 18 Aug 2021 09:16:15 +0800	[thread overview]
Message-ID: <2021081809161536216322@rock-chips.com> (raw)
In-Reply-To: 20210817143612.GB4290@sirena.org.uk

Hi Mark
--------------
jay.xu@rock-chips.com
>On Tue, Aug 17, 2021 at 11:38:48AM +0800, Jianqun Xu wrote:
>
>> +	} else if (event & REGULATOR_EVENT_ENABLE) {
>> +	uV = regulator_get_voltage(supply->reg);
>>  } else {
>
>I am very surprised this doesn't cause locking issues given that we
>might call notifiers with the regulator API's locks held.  Have you
>tested this with lockdep on? 
Thanks for your reply, there really has locking issue, our test team fail to find out it
but get a pass result.

So, if the voltage cannot get here by driver, can the notify  pass it, like pre-version patch?
_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

  reply	other threads:[~2021-08-18  1:16 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-17  3:38 [PATCH v2 0/3] regulator pre-enable Jianqun Xu
2021-08-17  3:38 ` Jianqun Xu
2021-08-17  3:38 ` [PATCH v2 1/3] regulator: add PRE_ENABLE event define Jianqun Xu
2021-08-17  3:38   ` Jianqun Xu
2021-08-18 12:56   ` Mark Brown
2021-08-18 12:56     ` Mark Brown
2021-08-17  3:38 ` [PATCH v2 2/3] regulator: core: add pre-enable event notify to regulator Jianqun Xu
2021-08-17  3:38   ` Jianqun Xu
2021-08-17  3:38 ` [PATCH v2 3/3] soc: rockchip: io-domain: do more thing about regulator notify Jianqun Xu
2021-08-17  3:38   ` Jianqun Xu
2021-08-17 14:36   ` Mark Brown
2021-08-17 14:36     ` Mark Brown
2021-08-18  1:16     ` jay.xu [this message]
2021-08-18  2:24       ` jay.xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2021081809161536216322@rock-chips.com \
    --to=jay.xu@rock-chips.com \
    --cc=broonie@kernel.org \
    --cc=heiko@sntech.de \
    --cc=lee.jones@linaro.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=ulf.hansson@linaro.org \
    --cc=zhangchangzhong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.