From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.2 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE3C2C4320A for ; Wed, 18 Aug 2021 10:26:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AD2A360BD3 for ; Wed, 18 Aug 2021 10:26:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233798AbhHRK1W (ORCPT ); Wed, 18 Aug 2021 06:27:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233868AbhHRK1V (ORCPT ); Wed, 18 Aug 2021 06:27:21 -0400 Received: from mail-pl1-x631.google.com (mail-pl1-x631.google.com [IPv6:2607:f8b0:4864:20::631]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2F966C061796 for ; Wed, 18 Aug 2021 03:26:47 -0700 (PDT) Received: by mail-pl1-x631.google.com with SMTP id f3so1525770plg.3 for ; Wed, 18 Aug 2021 03:26:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ZNayMdDzsTU4VQhyOZa4GnMMXCUMiePI+13ZGnlmmzg=; b=Jp/CDseKWqk8INe784MZtJm/kuPSCITNFKon/NYIe2U0JVPLMLOPgxLpNl3PIJlNHJ WjJqtALcc6aUc3zlFm5BcOPXapgBXE5V6p3C9NckTD/rH2mhhhGYY1kmFFp5YZ+aLpTi UzTYdY9ycuCsmTZ44Cl4fBZewPS1vS2DRCNq4NCrq228zueWF+PwnfsJOJND3ByZ7mWv B8jKa/DjvGoKGDyOy7Ze/lT6B7GLgHGVoN3AMXnepTPS4oLCSTcF7NUJ7ewUkHtRPV7t DuzEwtEunJF09D7d2XcdQkh6BBUb2xb+DAgMNpXKo9v4Ga/0UsKX/ohYovhkSldE6mCz 71Jg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ZNayMdDzsTU4VQhyOZa4GnMMXCUMiePI+13ZGnlmmzg=; b=FvC/fj4rwmCEufkUc1ZMI94sm9h9rrocP63Qa5D/hvXW8VwULHDMYmF4cpEq9H5kKq WcfO4RjRjlTZ75qCphh0u/mydLmga6vnXE/vNBRh0El5j1AVcCRGTbZj7SMhV6u6HkfZ 793uUhZMa6sHELsy+pPk06U2GmNJ6Xo/1detT3i5S8YEWCs6kyJ10o4B746AfwBGRWl5 bTPacrYmGJMnO/ySM3LQLg4/WbclCMC5A6iY/XGXOmLXY/kwRMnShpMTUW1k6n2nm+JP Z6tHYD+ijDYf6dkPI4Bq2tRckAifxY7MGamzG8a+2on3mBjSLyP1FCv6xx88qzrIQUfT Vfhg== X-Gm-Message-State: AOAM532OOrDjEinQrd9iySXZPgtvfrsOY+IJHJEvqhKOXzU2w5Vp9CfA tZLsZecG+KDbjhLiCULWZ9b6Xg== X-Google-Smtp-Source: ABdhPJzBj/LQChQPW3D7Z6q670orrn218cjqru6OfG4Kj8M0CWWcYYzlWDZddjbT1OvCf3GKyFPeoQ== X-Received: by 2002:a17:902:8bc4:b029:12b:8470:e29e with SMTP id r4-20020a1709028bc4b029012b8470e29emr6805469plo.2.1629282406597; Wed, 18 Aug 2021 03:26:46 -0700 (PDT) Received: from localhost ([122.172.201.85]) by smtp.gmail.com with ESMTPSA id r16sm4998664pje.10.2021.08.18.03.26.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Aug 2021 03:26:46 -0700 (PDT) Date: Wed, 18 Aug 2021 15:56:44 +0530 From: Viresh Kumar To: Taniya Das Cc: Doug Anderson , "Rafael J . Wysocki" , Linux PM , linux-arm-msm , LKML , Rajendra Nayak , Stephen Boyd Subject: Re: [PATCH v2] cpufreq: qcom-hw: Set dvfs_possible_from_any_cpu cpufreq driver flag Message-ID: <20210818102644.v2ob46azq47beeqg@vireshk-i7> References: <1628777955-7198-1-git-send-email-tdas@codeaurora.org> <77dde5fa-6b12-d970-ac3e-0d3f6c352fbe@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <77dde5fa-6b12-d970-ac3e-0d3f6c352fbe@codeaurora.org> User-Agent: NeoMutt/20180716-391-311a52 Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 18-08-21, 15:33, Taniya Das wrote: > Hi Doug, > > Thanks for your review. > > On 8/13/2021 2:03 AM, Doug Anderson wrote: > > Hi, > > > > On Thu, Aug 12, 2021 at 7:19 AM Taniya Das wrote: > > > > > > As remote cpufreq updates are supported on QCOM platforms, set > > > dvfs_possible_from_any_cpu cpufreq driver flag. > > > > > > Signed-off-by: Taniya Das > > > --- > > > > > > [v2] > > > * update the dvfs_possible_from_any_cpu always. > > > > > > drivers/cpufreq/qcom-cpufreq-hw.c | 2 ++ > > > 1 file changed, 2 insertions(+) > > > > > > diff --git a/drivers/cpufreq/qcom-cpufreq-hw.c b/drivers/cpufreq/qcom-cpufreq-hw.c > > > index f86859b..53d3898 100644 > > > --- a/drivers/cpufreq/qcom-cpufreq-hw.c > > > +++ b/drivers/cpufreq/qcom-cpufreq-hw.c > > > @@ -223,6 +223,8 @@ static int qcom_cpufreq_hw_read_lut(struct device *cpu_dev, > > > > > > table[i].frequency = CPUFREQ_TABLE_END; > > > policy->freq_table = table; > > > + policy->dvfs_possible_from_any_cpu = true; > > > + > > > > Why is this in the qcom_cpufreq_hw_read_lut() function? Shouldn't it > > be straight in qcom_cpufreq_hw_cpu_init()? > > > All CPU policy related data is updated here, thus wanted to keep it > together. This function should only be updating freq table, please do it in qcom_cpufreq_hw_cpu_init() itself, around where you set policy->driver_data. -- viresh