From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 653FAC4338F for ; Wed, 18 Aug 2021 09:02:34 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4C1EA6108D for ; Wed, 18 Aug 2021 09:02:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4C1EA6108D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 6A55282C6B; Wed, 18 Aug 2021 11:02:31 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=denx.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1629277351; bh=zLW24rlYbZHnnm2K+9WRoHMv/eauhklzHDtjZpEMpeo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From; b=sjnC52fYYlRfwgeDx/aG8NFFSkq0jTta+su+hxnJbIDpAC/NDBPvzmusV9kh0VwJD YL5IM20vUKlMjS6M57dalEMJeX7v1j+gbadnKnZTFTSayhgkutepK6fLIRB48MR+Af V4bXcaY3a5wx5FI24FB1UeGxP6MSDhctBVMtkf6qcfCbXwmsmClYaCf44NreyKms4N nn6ez+EtMNvmJ6SRELTF51GGEuC5nDa6MjcMmPBTF1JtYhJMhYovwMDmNQxG3LqHPK /NrzNEunETFXYo0KFKbzkjlRMGhaarh4NfGUzykFCHg0QmJfenWcuxriMi3ptXBCm4 LevTCDXFrPX0w== Received: from crub (p508b6186.dip0.t-ipconnect.de [80.139.97.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: agust@denx.de) by phobos.denx.de (Postfix) with ESMTPSA id 3B8FD82C6B; Wed, 18 Aug 2021 11:02:29 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=denx.de; s=phobos-20191101; t=1629277349; bh=zLW24rlYbZHnnm2K+9WRoHMv/eauhklzHDtjZpEMpeo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=m+311PGoHYTVj8zjGJMv61EwPZo2+11BqxDibXtSKEiAIzphmr2JN1JF88RLgvK0X DMUEq/XYy+ooFX+aVDuNIJWgdmfEBfIzTtdAxWABYPDKCEO/yF9a7CpOnfUTKDkrkZ cSx0vGPdIpRYJCLFxz54O+2Imiw/nxypQOuvauCsCV/UKyMguB6iY90lGFILrCv5/e 5yCcvTLLe1A7jF13NFaKDEoP/tG3eJon4GBPkOFSjPAyv0QLpfn/vkQbVKnJU9KVQq YDGlE40m+iOUAU+YqO0/cxbZJe21C5Gy0T7aqgTZhxermtK7k90uRdM+c7bvm75iGf 6B+4+NIxZAcXQ== Date: Wed, 18 Aug 2021 11:02:28 +0200 From: Anatolij Gustschin To: Tom Rini Cc: u-boot@lists.denx.de, Samuel Egli , Heiko Schocher Subject: Re: [PATCH 05/13] siemens: Move CONFIG_SYS_I2C_EEPROM_ADDR usage out of CONFIG namespace Message-ID: <20210818110228.74958771@crub> In-Reply-To: <20210817220009.22721-6-trini@konsulko.com> References: <20210817220009.22721-1-trini@konsulko.com> <20210817220009.22721-6-trini@konsulko.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean On Tue, 17 Aug 2021 17:59:40 -0400 Tom Rini trini@konsulko.com wrote: > The instances of CONFIG_SYS_I2C_EEPROM_ADDR on these platforms doesn't > match up with the rest of the EERPOM related defines in U-Boot. Move > these out of the CONFIG namespace rather than make complex Kconfig > logic. > > Cc: Samuel Egli > Cc: Anatolij Gustschin > Cc: Heiko Schocher > Signed-off-by: Tom Rini Reviewed-by: Anatolij Gustschin But probably some more cleanup in other board config headers needed, see comment below. ... > diff --git a/include/configs/draco.h b/include/configs/draco.h > index 396eb7ded500..7c1f071d99ec 100644 > --- a/include/configs/draco.h > +++ b/include/configs/draco.h > @@ -32,10 +32,6 @@ > /* I2C Configuration */ > #define CONFIG_SYS_I2C_SPEED 100000 > > -#define CONFIG_SYS_I2C_EEPROM_ADDR 0x50 > -#define EEPROM_ADDR_DDR3 0x90 > -#define EEPROM_ADDR_CHIP 0x120 these defines are also in include/configs/etamin.h include/configs/rastaban.h include/configs/thuban.h -- Anatolij