From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A051C4320A for ; Wed, 18 Aug 2021 12:19:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 06ABF6103A for ; Wed, 18 Aug 2021 12:19:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235869AbhHRMTr (ORCPT ); Wed, 18 Aug 2021 08:19:47 -0400 Received: from mail.kernel.org ([198.145.29.99]:48292 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233634AbhHRMTn (ORCPT ); Wed, 18 Aug 2021 08:19:43 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C9AA26103E; Wed, 18 Aug 2021 12:19:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629289149; bh=8ktxnAXgo0Y8fZiDQP9McWgd+yggDijrLt0O/GE7g4g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Smy5CjjU8ZEY0tW7BAvTw//U/uF7nuT8moUBCzWyP4fw7jgQUVwkiA7zQ40j2Anfc ubu+AY8gZL6Oa+GP2iE3JR8v0rtRpQT2Hp9Z4brwznzhUpMOi/WdWOt3XWraDTfb7/ FgfSVs4YYvIfnaqoucgUw/HLxyrGpaNQKHXS1pDQiOLQDWIAaENcmaDHS584Q1LiHN ShIjsMksXt4NCSlkQNMddKQoog+WABpmbSkew04Au4fg7P3+tFH7cr9viKwaXGpM5F ZeH467hUwi+gXgq6g8paJ0C90tZccOZx9Wgcynxfvqi07VIg0xnPKt4ETsogt637Te lVwFxPMMmgyyA== Date: Wed, 18 Aug 2021 13:19:01 +0100 From: Will Deacon To: Peter Zijlstra Cc: linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin Marinas , Marc Zyngier , Greg Kroah-Hartman , Morten Rasmussen , Qais Yousef , Suren Baghdasaryan , Quentin Perret , Tejun Heo , Johannes Weiner , Ingo Molnar , Juri Lelli , Vincent Guittot , "Rafael J. Wysocki" , Dietmar Eggemann , Daniel Bristot de Oliveira , Valentin Schneider , Mark Rutland , kernel-team@android.com Subject: Re: [PATCH v11 08/16] sched: Allow task CPU affinity to be restricted on asymmetric systems Message-ID: <20210818121900.GC14107@willie-the-truck> References: <20210730112443.23245-1-will@kernel.org> <20210730112443.23245-9-will@kernel.org> <20210818104227.GA13828@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 18, 2021 at 01:53:28PM +0200, Peter Zijlstra wrote: > On Wed, Aug 18, 2021 at 12:56:41PM +0200, Peter Zijlstra wrote: > > On Wed, Aug 18, 2021 at 11:42:28AM +0100, Will Deacon wrote: > > > > I think the idea looks good, but perhaps we could wrap things up a bit: > > > > > > /* Comment about why this is useful with RT */ > > > static cpumask_t *clear_user_cpus_ptr(struct task_struct *p) > > > { > > > struct cpumask *user_mask = NULL; > > > > > > swap(user_mask, p->user_cpus_ptr); > > > return user_mask; > > > } > > > > > > void release_user_cpus_ptr(struct task_struct *p) > > > { > > > kfree(clear_user_cpus_ptr(p)); > > > } > > > > > > Then just use clear_user_cpus_ptr() in sched/core.c where we know what > > > we're doing (well, at least one of us does!). > > > > OK, I'll go make it like that. > > Something like so then? Looks good to me, thanks! Will From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 921EBC4338F for ; Wed, 18 Aug 2021 12:21:35 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 597636104F for ; Wed, 18 Aug 2021 12:21:35 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 597636104F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=3V4O7e4LmxmCPZY8EaTTet9qwqWck6Ebq+YkzNR9qWg=; b=BjV/z9mlpQKhrd YRGv1ZTlJlpd6XDFqjTBZS+UzjX3un2j6cJ6B3PrprPOQkPkeCbKWL2faXZcigjJvNvXVqdSM4Ohx Ir3RXy/H+32Oj2Dk2AAJGBkF/dSjRhWTDVRQK3JX7rR3Kc8bPrPSv3dFQv2AtQBfOp1IHgStZiYKX Gd22VQ5fY8sjagpqfFNuAuySorSyubNwFfa5qlO4S580W7AT96nBEOgi8DkWmyju+cHBB4yZlwNdp F7Yg2R5H2XLjlm83dxEKy3cjsWm/AnHBVNf085XVL/985itTlt1FQ4a3zJeRhHeG9aZ5gT2Cf0F54 HSmHvTY1Bmn+FSGBYJjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGKXJ-005TWY-8o; Wed, 18 Aug 2021 12:19:13 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGKXF-005TVb-Ia for linux-arm-kernel@lists.infradead.org; Wed, 18 Aug 2021 12:19:10 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id C9AA26103E; Wed, 18 Aug 2021 12:19:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629289149; bh=8ktxnAXgo0Y8fZiDQP9McWgd+yggDijrLt0O/GE7g4g=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=Smy5CjjU8ZEY0tW7BAvTw//U/uF7nuT8moUBCzWyP4fw7jgQUVwkiA7zQ40j2Anfc ubu+AY8gZL6Oa+GP2iE3JR8v0rtRpQT2Hp9Z4brwznzhUpMOi/WdWOt3XWraDTfb7/ FgfSVs4YYvIfnaqoucgUw/HLxyrGpaNQKHXS1pDQiOLQDWIAaENcmaDHS584Q1LiHN ShIjsMksXt4NCSlkQNMddKQoog+WABpmbSkew04Au4fg7P3+tFH7cr9viKwaXGpM5F ZeH467hUwi+gXgq6g8paJ0C90tZccOZx9Wgcynxfvqi07VIg0xnPKt4ETsogt637Te lVwFxPMMmgyyA== Date: Wed, 18 Aug 2021 13:19:01 +0100 From: Will Deacon To: Peter Zijlstra Cc: linux-arm-kernel@lists.infradead.org, linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, Catalin Marinas , Marc Zyngier , Greg Kroah-Hartman , Morten Rasmussen , Qais Yousef , Suren Baghdasaryan , Quentin Perret , Tejun Heo , Johannes Weiner , Ingo Molnar , Juri Lelli , Vincent Guittot , "Rafael J. Wysocki" , Dietmar Eggemann , Daniel Bristot de Oliveira , Valentin Schneider , Mark Rutland , kernel-team@android.com Subject: Re: [PATCH v11 08/16] sched: Allow task CPU affinity to be restricted on asymmetric systems Message-ID: <20210818121900.GC14107@willie-the-truck> References: <20210730112443.23245-1-will@kernel.org> <20210730112443.23245-9-will@kernel.org> <20210818104227.GA13828@willie-the-truck> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210818_051909_698527_6E38E4E3 X-CRM114-Status: GOOD ( 17.15 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Aug 18, 2021 at 01:53:28PM +0200, Peter Zijlstra wrote: > On Wed, Aug 18, 2021 at 12:56:41PM +0200, Peter Zijlstra wrote: > > On Wed, Aug 18, 2021 at 11:42:28AM +0100, Will Deacon wrote: > > > > I think the idea looks good, but perhaps we could wrap things up a bit: > > > > > > /* Comment about why this is useful with RT */ > > > static cpumask_t *clear_user_cpus_ptr(struct task_struct *p) > > > { > > > struct cpumask *user_mask = NULL; > > > > > > swap(user_mask, p->user_cpus_ptr); > > > return user_mask; > > > } > > > > > > void release_user_cpus_ptr(struct task_struct *p) > > > { > > > kfree(clear_user_cpus_ptr(p)); > > > } > > > > > > Then just use clear_user_cpus_ptr() in sched/core.c where we know what > > > we're doing (well, at least one of us does!). > > > > OK, I'll go make it like that. > > Something like so then? Looks good to me, thanks! Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel