All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Sterba <dsterba@suse.cz>
To: Sidong Yang <realwakka@gmail.com>
Cc: dsterba@suse.cz, linux-btrfs <linux-btrfs@vger.kernel.org>,
	Qu Wenruo <quwenruo.btrfs@gmx.com>
Subject: Re: [PATCH v4 2/2] btrfs-progs: cmds: Add subcommand that dumps file extents
Date: Wed, 18 Aug 2021 18:59:24 +0200	[thread overview]
Message-ID: <20210818165924.GV5047@twin.jikos.cz> (raw)
In-Reply-To: <20210818003819.GA2365@realwakka>

On Wed, Aug 18, 2021 at 12:38:19AM +0000, Sidong Yang wrote:
> On Tue, Aug 17, 2021 at 03:30:22PM +0200, David Sterba wrote:
> > On Sun, Jul 18, 2021 at 06:46:01AM +0000, Sidong Yang wrote:
> > > This patch adds an subcommand in inspect-internal. It dumps file extents of
> > > the file that user provided. It helps to show the internal information
> > > about file extents comprise the file.
> > 
> > Do you have an example of the output? That's the most interesting part.
> > Thanks.
> 
> Thanks for reply.
> This is an example of the output below.
> 
> # ./btrfs inspect-internal dump-file-extent /mnt/test1
> type = regular, start = 2097152, len = 3227648, disk_bytenr = 0, disk_num_bytes = 0, offset = 0, compression = none
> type = regular, start = 5324800, len = 16728064, disk_bytenr = 0, disk_num_bytes = 0, offset = 0, compression = none
> type = regular, start = 22052864, len = 8486912, disk_bytenr = 0, disk_num_bytes = 0, offset = 0, compression = none
> type = regular, start = 30572544, len = 36540416, disk_bytenr = 0, disk_num_bytes = 0, offset = 0, compression = none
> type = regular, start = 67112960, len = 5299630080, disk_bytenr = 0, disk_num_bytes = 0, offset = 0, compression = none

This resembles a debugging output, something like we have for
tracepoints but I think this should be more human readable, with
possiblity of parsing by scripts/tools.

So to not just duplicate what filefrag or xfs_io -c fiemap do, we can
optionally enhance the information with the specifics of btrfs, like on
which devices the extents are, which compression is there etc. But the
basic output should be more or less like filefrag.

  reply	other threads:[~2021-08-18 17:02 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-18  6:45 [PATCH v4 0/2] Add subcommand that dumps file extents Sidong Yang
2021-07-18  6:46 ` [PATCH v4 1/2] btrfs-progs: export util functions about file extent items Sidong Yang
2021-07-18  6:46 ` [PATCH v4 2/2] btrfs-progs: cmds: Add subcommand that dumps file extents Sidong Yang
2021-08-17 13:30   ` David Sterba
2021-08-18  0:38     ` Sidong Yang
2021-08-18 16:59       ` David Sterba [this message]
2021-08-19  3:44         ` Sidong Yang
2021-08-19  6:03       ` Qu Wenruo
2021-08-19  6:05         ` Qu Wenruo
2021-08-19 15:27           ` Sidong Yang
2021-08-19 22:16             ` Qu Wenruo
2021-08-20 15:23               ` Sidong Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210818165924.GV5047@twin.jikos.cz \
    --to=dsterba@suse.cz \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=quwenruo.btrfs@gmx.com \
    --cc=realwakka@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.