From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f54.google.com (mail-pj1-f54.google.com [209.85.216.54]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 81E1C168 for ; Thu, 19 Aug 2021 06:17:29 +0000 (UTC) Received: by mail-pj1-f54.google.com with SMTP id j1so4231787pjv.3 for ; Wed, 18 Aug 2021 23:17:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Z7TQEkkTOfvT3y1VcK9cbeGmLxLBDuWce4oY9e31CIQ=; b=n8Z7pceL3Q1hHrYhRGbE2Ft6ysYoV2T29GwsgsIk5zym7iZcje0CXVg1jI36aNnFP1 wEt31EiA2dUBQwlv5rK6Pb4jBRjUZnVnX9lq3yYWlZnsAiqoC84b2+sIg5qRcoOEikt2 Bl5OLXFHBLycojOK68FIhPW3b2fskqhF3vr/eyYOYKdL7QspG0UOJAgIVnJ/rUe4LZFr 9Mx+8O2v0d2rHrH3yazUPQGMQQQiYdzhDIVBgB1HMOdlKqueyQlS0Pa++oE7KDNseaKY ZqQcskpZ4qIHBPun+Nz8BNcPrFRsCGUIgrdD9AWMNWaoX41LuxEow35zOBfD0rRFPHfn o2nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Z7TQEkkTOfvT3y1VcK9cbeGmLxLBDuWce4oY9e31CIQ=; b=N9D5KMOlkdIFuQ1fay6Zu8Vukrla/PyX6/lAairzJqOBLrSbOIzsSaYnSSkqNNNgbL Ucz+2iw4IM6KK01hSHVTRCGo+upMJLh6tdTRER2Xhg32VAHw5Q82T9OSruCSWaGb20Cg JC9YL9FIrtIwtdtPViDWgisiJA7N4o21P7EWAPCY8zc/nFUZur6JWuYSNRtp1zn1E5JY 5bQnFbMLQdDStoQWA1Wd3wCNv8p9TNag6X9YacnohQMafwK9NsTy0iNFnfgGPvSeFlkc h2xqENpPWlzqGhllQI9rUNmU6potsK8U59nrmeDSM6pDADjhCwZ7dM1wV9/VVyYnSRT+ H+QA== X-Gm-Message-State: AOAM530agzw6CxdA010+b0cIzk+8JkYuJLXLckyfcqTTgiIJCpTYvO4Z W/IKvKYUbnTunzY2NUD79QgcIA== X-Google-Smtp-Source: ABdhPJwi8ECnFjz7ftlBUkQP1U01xvcbaFwYmCvSxRCVadF/ZCBCreA9Xq0KVJGpteNV1tSqbtF8Eg== X-Received: by 2002:a17:90a:ce88:: with SMTP id g8mr13456163pju.116.1629353849006; Wed, 18 Aug 2021 23:17:29 -0700 (PDT) Received: from localhost ([122.172.201.85]) by smtp.gmail.com with ESMTPSA id r18sm2222724pgk.54.2021.08.18.23.16.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Aug 2021 23:16:53 -0700 (PDT) Date: Thu, 19 Aug 2021 11:46:17 +0530 From: Viresh Kumar To: Dmitry Osipenko Cc: Ulf Hansson , Thierry Reding , Jonathan Hunter , Viresh Kumar , Stephen Boyd , Peter De Schrijver , Mikko Perttunen , Peter Chen , Mark Brown , Lee Jones , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Nishanth Menon , Vignesh Raghavendra , Richard Weinberger , Miquel Raynal , Lucas Stach , Stefan Agner , Adrian Hunter , Mauro Carvalho Chehab , Rob Herring , Michael Turquette , Linux Kernel Mailing List , linux-tegra , Linux PM , Linux USB List , linux-staging@lists.linux.dev, linux-spi@vger.kernel.org, linux-pwm@vger.kernel.org, linux-mtd@lists.infradead.org, linux-mmc , Linux Media Mailing List , dri-devel , DTML , linux-clk Subject: Re: [PATCH v8 01/34] opp: Add dev_pm_opp_sync() helper Message-ID: <20210819061617.r4kuqxafjstrv3kt@vireshk-i7> References: <20210818045307.4brb6cafkh3adjth@vireshk-i7> <080469b3-612b-3a34-86e5-7037a64de2fe@gmail.com> <20210818055849.ybfajzu75ecpdrbn@vireshk-i7> <20210818062723.dqamssfkf7lf7cf7@vireshk-i7> <20210818091417.dvlnsxlgybdsn76x@vireshk-i7> Precedence: bulk X-Mailing-List: linux-staging@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 On 18-08-21, 18:55, Dmitry Osipenko wrote: > 18.08.2021 12:41, Ulf Hansson пишет: > > Either way gives the equal result. The new callback allows to remove the > boilerplate dev_pm_opp_set_rate(clk_get_rate() code from the rpm-resume > of consumer devices, that's it. It may not be equal, as dev_pm_opp_set_rate() may do additional stuff, now or in a later implementation. Currently it only does regulator_enable() as a special case, but it can be clk_enable() as well. Also, this tries to solve the problem in a tricky/hacky way, while all you wanted was to make the genpd aware of what the performance state should be. Your driver can break tomorrow if we started to do more stuff from this API at another time. > > dev_pm_opp_set_rate() is best called from consumer drivers, as they > > need to be in control. > >> What we need here is just configure. So something like this then: > The intent wasn't to use dev_pm_opp_set_rate() from > __genpd_dev_pm_attach(), but to set genpd->rpm_pstate in accordance to > the h/w configuration. Right. > On Tegra we have a chain of PDs and it's not trivial to convert the > device's OPP into pstate because only the parent domain can translate > the required OPP. The driver should just be required to make a call, and OPP/genpd core should return it a value. This is already done today while setting the pstate for a device. The same frameworks must be able to supply a value to be used for the device. > Viresh, please take a look at what I did in [1]. Maybe it could be done > in another way. I looked into this and looked like too much trouble. The implementation needs to be simple. I am not sure I understand all the problems you faced while doing that, would be better to start with a simpler implementation of get_performance_state() kind of API for genpd, after the domain is attached and its OPP table is initialized. Note, that the OPP table isn't required to be fully initialized for the device at this point, we can parse the DT as well if needed be. -- viresh From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E314C4338F for ; Thu, 19 Aug 2021 06:18:37 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7F06C61106 for ; Thu, 19 Aug 2021 06:18:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7F06C61106 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=sI6qUhyJ2faT+sfJbfFtehQxZRtXszTHTXH3OwQ0TxA=; b=1u1UCNNbxJraj2 tjz1AWIBgodYx94elykdBbRT4CpUrQ1agPNykhnJ+kybG/fsXbXcooSdDsqyQ7ZowX12T+Yl1QV7K xuGP34+nOm+iAuVMxSqnsgHe0QBhRPwgeJiTj/snnN0hbUvva67BDLo59BpLLbcwsTps49WIA7aRr zS2+1CbbKSweyVbYFviGEpODFDUspCdtmhv/W23lNvG0yFrC0HJvHPdGQ3DsWC5lXkTeEFndOjUiF 7aklZLJ8ICfdGv+QPjC7J1FRR5/J0ldgB/Ne8+E3PzRxN6fss8U4yhqZYVg8fyaieYj0TKQoqDz4O 1zNDgkCavZX+ZzRdEDeQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGbMu-007KDo-I3; Thu, 19 Aug 2021 06:17:36 +0000 Received: from mail-pj1-x1034.google.com ([2607:f8b0:4864:20::1034]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGbMo-007KCF-MC for linux-mtd@lists.infradead.org; Thu, 19 Aug 2021 06:17:34 +0000 Received: by mail-pj1-x1034.google.com with SMTP id n5so4230876pjt.4 for ; Wed, 18 Aug 2021 23:17:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=Z7TQEkkTOfvT3y1VcK9cbeGmLxLBDuWce4oY9e31CIQ=; b=n8Z7pceL3Q1hHrYhRGbE2Ft6ysYoV2T29GwsgsIk5zym7iZcje0CXVg1jI36aNnFP1 wEt31EiA2dUBQwlv5rK6Pb4jBRjUZnVnX9lq3yYWlZnsAiqoC84b2+sIg5qRcoOEikt2 Bl5OLXFHBLycojOK68FIhPW3b2fskqhF3vr/eyYOYKdL7QspG0UOJAgIVnJ/rUe4LZFr 9Mx+8O2v0d2rHrH3yazUPQGMQQQiYdzhDIVBgB1HMOdlKqueyQlS0Pa++oE7KDNseaKY ZqQcskpZ4qIHBPun+Nz8BNcPrFRsCGUIgrdD9AWMNWaoX41LuxEow35zOBfD0rRFPHfn o2nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=Z7TQEkkTOfvT3y1VcK9cbeGmLxLBDuWce4oY9e31CIQ=; b=judULIvuODAl6r8aTc1SjVr2JvZ7409qcAbs11aG2eajKeKmQLlmmgtwc3obwuGOP0 jLmjiiyFrAIq61dy68a10OM8kO19vxCFe5xe8oXFwh0qTWdPWr0mehfHTdrdGe/9/4uK vXqBQoDZRmggeQRlhBqJ97BA8P/BZgld7wMsngY0eoeMEqrSI1EiaRMOXP+207ByS728 aezZqqEwz1hSfGp6Y2V4uUiDPtXA0EHiLiQCvNqh8JgmqK7sPbGgxChQtV5gtPd7Vy7K WvtZGodOhnXYaPmpSgEUPRN9FTmsgjxT+Hh30ykHo5EI3Z4WK0pS44Wiqd1RGFPfcR6M LfgA== X-Gm-Message-State: AOAM5328x4axU7c+dttDvpJqRbboAsGT27sEJFqrtXRRRGFzpFr7623N t3QpHH18RMhtfVGZmy7nBf5r3A== X-Google-Smtp-Source: ABdhPJwi8ECnFjz7ftlBUkQP1U01xvcbaFwYmCvSxRCVadF/ZCBCreA9Xq0KVJGpteNV1tSqbtF8Eg== X-Received: by 2002:a17:90a:ce88:: with SMTP id g8mr13456163pju.116.1629353849006; Wed, 18 Aug 2021 23:17:29 -0700 (PDT) Received: from localhost ([122.172.201.85]) by smtp.gmail.com with ESMTPSA id r18sm2222724pgk.54.2021.08.18.23.16.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Aug 2021 23:16:53 -0700 (PDT) Date: Thu, 19 Aug 2021 11:46:17 +0530 From: Viresh Kumar To: Dmitry Osipenko Cc: Ulf Hansson , Thierry Reding , Jonathan Hunter , Viresh Kumar , Stephen Boyd , Peter De Schrijver , Mikko Perttunen , Peter Chen , Mark Brown , Lee Jones , Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= , Nishanth Menon , Vignesh Raghavendra , Richard Weinberger , Miquel Raynal , Lucas Stach , Stefan Agner , Adrian Hunter , Mauro Carvalho Chehab , Rob Herring , Michael Turquette , Linux Kernel Mailing List , linux-tegra , Linux PM , Linux USB List , linux-staging@lists.linux.dev, linux-spi@vger.kernel.org, linux-pwm@vger.kernel.org, linux-mtd@lists.infradead.org, linux-mmc , Linux Media Mailing List , dri-devel , DTML , linux-clk Subject: Re: [PATCH v8 01/34] opp: Add dev_pm_opp_sync() helper Message-ID: <20210819061617.r4kuqxafjstrv3kt@vireshk-i7> References: <20210818045307.4brb6cafkh3adjth@vireshk-i7> <080469b3-612b-3a34-86e5-7037a64de2fe@gmail.com> <20210818055849.ybfajzu75ecpdrbn@vireshk-i7> <20210818062723.dqamssfkf7lf7cf7@vireshk-i7> <20210818091417.dvlnsxlgybdsn76x@vireshk-i7> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716-391-311a52 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210818_231730_761709_23EACECC X-CRM114-Status: GOOD ( 25.12 ) X-BeenThere: linux-mtd@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Linux MTD discussion mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "linux-mtd" Errors-To: linux-mtd-bounces+linux-mtd=archiver.kernel.org@lists.infradead.org T24gMTgtMDgtMjEsIDE4OjU1LCBEbWl0cnkgT3NpcGVua28gd3JvdGU6Cj4gMTguMDguMjAyMSAx Mjo0MSwgVWxmIEhhbnNzb24g0L/QuNGI0LXRgjoKPiAKPiBFaXRoZXIgd2F5IGdpdmVzIHRoZSBl cXVhbCByZXN1bHQuIFRoZSBuZXcgY2FsbGJhY2sgYWxsb3dzIHRvIHJlbW92ZSB0aGUKPiBib2ls ZXJwbGF0ZSBkZXZfcG1fb3BwX3NldF9yYXRlKGNsa19nZXRfcmF0ZSgpIGNvZGUgZnJvbSB0aGUg cnBtLXJlc3VtZQo+IG9mIGNvbnN1bWVyIGRldmljZXMsIHRoYXQncyBpdC4KCkl0IG1heSBub3Qg YmUgZXF1YWwsIGFzIGRldl9wbV9vcHBfc2V0X3JhdGUoKSBtYXkgZG8gYWRkaXRpb25hbCBzdHVm ZiwKbm93IG9yIGluIGEgbGF0ZXIgaW1wbGVtZW50YXRpb24uIEN1cnJlbnRseSBpdCBvbmx5IGRv ZXMKcmVndWxhdG9yX2VuYWJsZSgpIGFzIGEgc3BlY2lhbCBjYXNlLCBidXQgaXQgY2FuIGJlIGNs a19lbmFibGUoKSBhcwp3ZWxsLiBBbHNvLCB0aGlzIHRyaWVzIHRvIHNvbHZlIHRoZSBwcm9ibGVt IGluIGEgdHJpY2t5L2hhY2t5IHdheSwKd2hpbGUgYWxsIHlvdSB3YW50ZWQgd2FzIHRvIG1ha2Ug dGhlIGdlbnBkIGF3YXJlIG9mIHdoYXQgdGhlCnBlcmZvcm1hbmNlIHN0YXRlIHNob3VsZCBiZS4K CllvdXIgZHJpdmVyIGNhbiBicmVhayB0b21vcnJvdyBpZiB3ZSBzdGFydGVkIHRvIGRvIG1vcmUg c3R1ZmYgZnJvbQp0aGlzIEFQSSBhdCBhbm90aGVyIHRpbWUuCgo+ID4gZGV2X3BtX29wcF9zZXRf cmF0ZSgpIGlzIGJlc3QgY2FsbGVkIGZyb20gY29uc3VtZXIgZHJpdmVycywgYXMgdGhleQo+ID4g bmVlZCB0byBiZSBpbiBjb250cm9sLgo+ID4+IFdoYXQgd2UgbmVlZCBoZXJlIGlzIGp1c3QgY29u ZmlndXJlLiBTbyBzb21ldGhpbmcgbGlrZSB0aGlzIHRoZW46Cj4gVGhlIGludGVudCB3YXNuJ3Qg dG8gdXNlIGRldl9wbV9vcHBfc2V0X3JhdGUoKSBmcm9tCj4gX19nZW5wZF9kZXZfcG1fYXR0YWNo KCksIGJ1dCB0byBzZXQgZ2VucGQtPnJwbV9wc3RhdGUgaW4gYWNjb3JkYW5jZSB0bwo+IHRoZSBo L3cgY29uZmlndXJhdGlvbi4KClJpZ2h0LgoKPiBPbiBUZWdyYSB3ZSBoYXZlIGEgY2hhaW4gb2Yg UERzIGFuZCBpdCdzIG5vdCB0cml2aWFsIHRvIGNvbnZlcnQgdGhlCj4gZGV2aWNlJ3MgT1BQIGlu dG8gcHN0YXRlIGJlY2F1c2Ugb25seSB0aGUgcGFyZW50IGRvbWFpbiBjYW4gdHJhbnNsYXRlCj4g dGhlIHJlcXVpcmVkIE9QUC4KClRoZSBkcml2ZXIgc2hvdWxkIGp1c3QgYmUgcmVxdWlyZWQgdG8g bWFrZSBhIGNhbGwsIGFuZCBPUFAvZ2VucGQgY29yZQpzaG91bGQgcmV0dXJuIGl0IGEgdmFsdWUu IFRoaXMgaXMgYWxyZWFkeSBkb25lIHRvZGF5IHdoaWxlIHNldHRpbmcgdGhlCnBzdGF0ZSBmb3Ig YSBkZXZpY2UuIFRoZSBzYW1lIGZyYW1ld29ya3MgbXVzdCBiZSBhYmxlIHRvIHN1cHBseSBhCnZh bHVlIHRvIGJlIHVzZWQgZm9yIHRoZSBkZXZpY2UuCgo+IFZpcmVzaCwgcGxlYXNlIHRha2UgYSBs b29rIGF0IHdoYXQgSSBkaWQgaW4gWzFdLiBNYXliZSBpdCBjb3VsZCBiZSBkb25lCj4gaW4gYW5v dGhlciB3YXkuCgpJIGxvb2tlZCBpbnRvIHRoaXMgYW5kIGxvb2tlZCBsaWtlIHRvbyBtdWNoIHRy b3VibGUuIFRoZQppbXBsZW1lbnRhdGlvbiBuZWVkcyB0byBiZSBzaW1wbGUuIEkgYW0gbm90IHN1 cmUgSSB1bmRlcnN0YW5kIGFsbCB0aGUKcHJvYmxlbXMgeW91IGZhY2VkIHdoaWxlIGRvaW5nIHRo YXQsIHdvdWxkIGJlIGJldHRlciB0byBzdGFydCB3aXRoIGEKc2ltcGxlciBpbXBsZW1lbnRhdGlv biBvZiBnZXRfcGVyZm9ybWFuY2Vfc3RhdGUoKSBraW5kIG9mIEFQSSBmb3IKZ2VucGQsIGFmdGVy IHRoZSBkb21haW4gaXMgYXR0YWNoZWQgYW5kIGl0cyBPUFAgdGFibGUgaXMgaW5pdGlhbGl6ZWQu CgpOb3RlLCB0aGF0IHRoZSBPUFAgdGFibGUgaXNuJ3QgcmVxdWlyZWQgdG8gYmUgZnVsbHkgaW5p dGlhbGl6ZWQgZm9yCnRoZSBkZXZpY2UgYXQgdGhpcyBwb2ludCwgd2UgY2FuIHBhcnNlIHRoZSBE VCBhcyB3ZWxsIGlmIG5lZWRlZCBiZS4KCi0tIAp2aXJlc2gKCl9fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpMaW51eCBNVEQgZGlzY3Vzc2lvbiBt YWlsaW5nIGxpc3QKaHR0cDovL2xpc3RzLmluZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9s aW51eC1tdGQvCg==