From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 55149C432BE for ; Thu, 19 Aug 2021 17:57:19 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 38CBF6109F for ; Thu, 19 Aug 2021 17:57:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234014AbhHSR5y (ORCPT ); Thu, 19 Aug 2021 13:57:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:51342 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232909AbhHSR5y (ORCPT ); Thu, 19 Aug 2021 13:57:54 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1E8166109F; Thu, 19 Aug 2021 17:57:17 +0000 (UTC) Date: Thu, 19 Aug 2021 13:57:10 -0400 From: Steven Rostedt To: "Tzvetomir Stoyanov (VMware)" Cc: linux-trace-devel@vger.kernel.org Subject: Re: [PATCH v2 35/87] trace-cmd library: Initialize internal sections database on file read Message-ID: <20210819135710.7fb40ba0@oasis.local.home> In-Reply-To: <20210729050959.12263-36-tz.stoyanov@gmail.com> References: <20210729050959.12263-1-tz.stoyanov@gmail.com> <20210729050959.12263-36-tz.stoyanov@gmail.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Thu, 29 Jul 2021 08:09:07 +0300 "Tzvetomir Stoyanov (VMware)" wrote: > > + if (handle->file_version < 7) > + add_section(handle, TRACECMD_OPTION_FTRACE_EVENTS, 0, 0, > + lseek64(handle->fd, 0, SEEK_CUR)); > + I really hate these "magic number 7"s. Perhaps we should add flags, like "SECTIONED" with a bit more meaning. if (handle->flags & HANDLE_FL_SECTIONED) section_add(...); -- Steve