From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32B05C4338F for ; Thu, 19 Aug 2021 19:21:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 116BA60EB5 for ; Thu, 19 Aug 2021 19:21:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234511AbhHSTWO (ORCPT ); Thu, 19 Aug 2021 15:22:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:56824 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234436AbhHSTWN (ORCPT ); Thu, 19 Aug 2021 15:22:13 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E726060EB5; Thu, 19 Aug 2021 19:21:36 +0000 (UTC) Date: Thu, 19 Aug 2021 15:21:35 -0400 From: Steven Rostedt To: "Tzvetomir Stoyanov (VMware)" Cc: linux-trace-devel@vger.kernel.org Subject: Re: [PATCH v2 59/87] trace-cmd report: Do not print empty buffer name Message-ID: <20210819152135.222951b4@oasis.local.home> In-Reply-To: <20210729050959.12263-60-tz.stoyanov@gmail.com> References: <20210729050959.12263-1-tz.stoyanov@gmail.com> <20210729050959.12263-60-tz.stoyanov@gmail.com> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-trace-devel@vger.kernel.org On Thu, 29 Jul 2021 08:09:31 +0300 "Tzvetomir Stoyanov (VMware)" wrote: > In trace file version 7, the top buffer is saved with its empty > file name, string "". When displaying it, filter those empty strings. This looks like it could have been folded into another patch. -- Steve > > Signed-off-by: Tzvetomir Stoyanov (VMware) > --- > tracecmd/trace-read.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tracecmd/trace-read.c b/tracecmd/trace-read.c > index a36d72e4..1868a830 100644 > --- a/tracecmd/trace-read.c > +++ b/tracecmd/trace-read.c > @@ -1175,7 +1175,7 @@ static void print_handle_file(struct handle_list *handles) > /* Only print file names if more than one file is read */ > if (!multi_inputs && !instances) > return; > - if (handles->file) > + if (handles->file && *handles->file != '\0') > printf("%*s: ", max_file_size, handles->file); > else > printf("%*s ", max_file_size, "");