From: Alan Stern <stern@rowland.harvard.edu>
To: syzbot <syzbot+9b57a46bf1801ce2a2ca@syzkaller.appspotmail.com>
Cc: benjamin.tissoires@redhat.com, jikos@kernel.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-usb@vger.kernel.org, mkubecek@suse.cz,
syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] WARNING in hid_submit_ctrl/usb_submit_urb
Date: Thu, 19 Aug 2021 11:26:26 -0400 [thread overview]
Message-ID: <20210819152626.GD228422@rowland.harvard.edu> (raw)
In-Reply-To: <000000000000f7ab1005c9db0f8e@google.com>
On Wed, Aug 18, 2021 at 01:13:06PM -0700, syzbot wrote:
> Hello,
>
> syzbot has tested the proposed patch but the reproducer is still triggering an issue:
> WARNING in hid_submit_ctrl/usb_submit_urb
>
> ------------[ cut here ]------------
> usb 1-1: BOGUS control dir, pipe 80000280 doesn't match bRequestType a1
> WARNING: CPU: 1 PID: 10180 at drivers/usb/core/urb.c:410 usb_submit_urb+0x149d/0x18a0 drivers/usb/core/urb.c:410
Looks like I was wrong. Let's see what's really happening.
Alan Stern
#syz test: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git 794c7931a242
--- usb-devel.orig/drivers/hid/usbhid/hid-core.c
+++ usb-devel/drivers/hid/usbhid/hid-core.c
@@ -397,6 +397,8 @@ static int hid_submit_ctrl(struct hid_de
} else
padlen = 0;
usbhid->urbctrl->transfer_buffer_length = padlen;
+ hid_err(hid, "submit_ctrl: maxpacket %d len %d padlen %d\n",
+ maxpacket, len, padlen);
}
usbhid->urbctrl->dev = hid_to_usb_dev(hid);
next prev parent reply other threads:[~2021-08-19 15:26 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-18 15:46 [syzbot] WARNING in hid_submit_ctrl/usb_submit_urb syzbot
2021-08-18 9:14 ` syzbot
2021-08-18 18:49 ` Alan Stern
2021-08-18 20:13 ` syzbot
2021-08-19 15:26 ` Alan Stern [this message]
2021-08-19 17:35 ` syzbot
2021-08-19 19:53 ` Alan Stern
2021-08-20 0:40 ` syzbot
2021-08-20 14:06 ` Alan Stern
2021-08-24 11:53 ` Jiri Kosina
2021-08-24 12:34 ` Benjamin Tissoires
2021-08-31 9:51 ` Benjamin Tissoires
2021-08-31 13:34 ` Alan Stern
2021-08-31 19:53 ` Jiri Kosina
2021-09-01 15:38 ` Alan Stern
2021-09-01 15:51 ` Michal Kubecek
2021-09-01 16:35 ` [PATCH 1/3] HID: usbhid: Fix flood of "control queue full" messages Alan Stern
2021-09-01 18:53 ` Jiri Kosina
2021-08-24 11:50 ` [syzbot] WARNING in hid_submit_ctrl/usb_submit_urb Michal Kubecek
2021-08-30 19:22 ` Oleksandr Natalenko
2021-08-18 19:01 ` Alan Stern
2021-08-18 19:39 ` syzbot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210819152626.GD228422@rowland.harvard.edu \
--to=stern@rowland.harvard.edu \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mkubecek@suse.cz \
--cc=syzbot+9b57a46bf1801ce2a2ca@syzkaller.appspotmail.com \
--cc=syzkaller-bugs@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.