From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6AB32C4338F for ; Thu, 19 Aug 2021 16:53:17 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 28A0A610A6 for ; Thu, 19 Aug 2021 16:53:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 28A0A610A6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:60140 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mGlI4-0004WF-Df for qemu-devel@archiver.kernel.org; Thu, 19 Aug 2021 12:53:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59742) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGlHS-0003j9-Hd for qemu-devel@nongnu.org; Thu, 19 Aug 2021 12:52:38 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:20078) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGlHP-0001Vc-Sf for qemu-devel@nongnu.org; Thu, 19 Aug 2021 12:52:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629391954; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Te0uu1wux1vZo/m9r1QEEFwbMYFiRhbZQLz7lOc8p9M=; b=coQ+eRvxNUU5mUYTztLveUK21t3v8INGSrYMzojMrbH9f208X2gsi7q7sVEnTxkIW91VRG mxa47tMs3yGwvjYu7OkOdOnKiS16QGN8XJCSP38wN1rjqHr5OH2Epi7i55Paj4mWp/KkkE 3WWy1Tug+8nunnYftUC6TksVZbGtMhs= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-480-eSCE9lEyOTCdRniPkaIJkg-1; Thu, 19 Aug 2021 12:52:32 -0400 X-MC-Unique: eSCE9lEyOTCdRniPkaIJkg-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E44C01B2C993; Thu, 19 Aug 2021 16:52:31 +0000 (UTC) Received: from localhost (unknown [10.22.32.130]) by smtp.corp.redhat.com (Postfix) with ESMTP id A657C5DAA5; Thu, 19 Aug 2021 16:52:31 +0000 (UTC) Date: Thu, 19 Aug 2021 12:52:31 -0400 From: Eduardo Habkost To: Peter Maydell Subject: Re: [PATCH v3 50/66] hw/core/cpu: Move cpu properties to cpu-sysemu.c Message-ID: <20210819165231.6qc3bnfctufm2vvh@habkost.net> References: <20210818191920.390759-1-richard.henderson@linaro.org> <20210818191920.390759-51-richard.henderson@linaro.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=ehabkost@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Received-SPF: pass client-ip=170.10.133.124; envelope-from=ehabkost@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , QEMU Developers Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Thu, Aug 19, 2021 at 04:26:10PM +0100, Peter Maydell wrote: > On Wed, 18 Aug 2021 at 21:09, Richard Henderson > wrote: > > > > The comment in cpu-common.c is absolutely correct, we can't > > rely on the ifdef in a file built once. This was only "working" > > because we used ifndef. > > > > Signed-off-by: Richard Henderson > > Fixes: 1b36e4f5a5de585 > > which moved the properties out of cpu.c and into cpu-common.c > with the remark "There's no reason to keep the property list > separate from the CPU class code" despite there being a big > fat warning comment saying why it can't go in a compiled-once > source file ! Ouch. Sorry about that. :( > > Is there a reason to prefer this patch over just reverting > 1b36e4f5a5de585 ? I agree with reverting the commit. -- Eduardo