From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78640C4338F for ; Thu, 19 Aug 2021 20:51:32 +0000 (UTC) Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3E3036108E for ; Thu, 19 Aug 2021 20:51:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3E3036108E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=bootlin.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=busybox.net Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id 1043D4043F; Thu, 19 Aug 2021 20:51:32 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 49B-yUh_hoBs; Thu, 19 Aug 2021 20:51:28 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 5B8B84048C; Thu, 19 Aug 2021 20:51:27 +0000 (UTC) Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136]) by ash.osuosl.org (Postfix) with ESMTP id 9162A1BF297 for ; Thu, 19 Aug 2021 20:51:26 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp3.osuosl.org (Postfix) with ESMTP id 80BE560775 for ; Thu, 19 Aug 2021 20:51:26 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp3.osuosl.org ([127.0.0.1]) by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id LectGs5fR3Qx for ; Thu, 19 Aug 2021 20:51:21 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.8.0 Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [217.70.183.196]) by smtp3.osuosl.org (Postfix) with ESMTPS id 9A185605E9 for ; Thu, 19 Aug 2021 20:51:21 +0000 (UTC) Received: (Authenticated sender: thomas.petazzoni@bootlin.com) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id D9136E0003; Thu, 19 Aug 2021 20:51:19 +0000 (UTC) Date: Thu, 19 Aug 2021 22:51:18 +0200 From: Thomas Petazzoni To: Fabrice Fontaine Message-ID: <20210819225118.361fe904@windsurf> In-Reply-To: <20210817221530.2343233-1-fontaine.fabrice@gmail.com> References: <20210817221530.2343233-1-fontaine.fabrice@gmail.com> Organization: Bootlin X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Subject: Re: [Buildroot] [PATCH 1/1] Revert "package/libshout: enable optional dependency for libressl" X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" On Wed, 18 Aug 2021 00:15:30 +0200 Fabrice Fontaine wrote: > This reverts commit 46b8fb7500ecca65a79507318fd3052208559c09 indeed if > libressl is selected as the openssl provider, the BR2_PACKAGE_OPENSSL > conditition will always be used and the BR2_PACKAGE_LIBRESSL condition > will never be triggered. Moreover, libressl provides a pkg-config file. > > Signed-off-by: Fabrice Fontaine > --- > package/libshout/libshout.mk | 3 --- > 1 file changed, 3 deletions(-) I've applied to master, because you're right, what 46b8fb7500ecca65a79507318fd3052208559c09 has added is a no-op, because BR2_PACKAGE_LIBRESSL cannot be 'y' without BR2_PACKAGE_OPENSSL also being 'y'. However, could you look at the autobuilder issue that 46b8fb7500ecca65a79507318fd3052208559c09 was intended to fix, and see what is the proper fix for it ? Best regards, Thomas -- Thomas Petazzoni, CTO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com _______________________________________________ buildroot mailing list buildroot@busybox.net http://lists.busybox.net/mailman/listinfo/buildroot