From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DFD6FC4320A for ; Fri, 20 Aug 2021 03:20:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C584860EBC for ; Fri, 20 Aug 2021 03:20:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238073AbhHTDUl (ORCPT ); Thu, 19 Aug 2021 23:20:41 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51176 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234992AbhHTDUj (ORCPT ); Thu, 19 Aug 2021 23:20:39 -0400 Received: from mail-qk1-x732.google.com (mail-qk1-x732.google.com [IPv6:2607:f8b0:4864:20::732]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9F2ADC061575; Thu, 19 Aug 2021 20:20:02 -0700 (PDT) Received: by mail-qk1-x732.google.com with SMTP id a10so663705qka.12; Thu, 19 Aug 2021 20:20:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ILia9TnznEgu+zH0nAD0DU3ELIP+hXxx/xtqhrAXbUc=; b=sjjsZXWb4ZAPdSvkpjDDeS63EK6LqAuKdpTC5PXtJlmaww/87Om/upXqpvAX2p0oOE +LdwtSl8oH66cE9XdrtTVCLQT4iaBimtscoyGxjKhF1pdFI8qWmZ956TqWei0pjD6Dr1 o6VecAO0cN+QaIVxrL5h/7Mfu5pkjyj6nVIJWTHsisCA7Gc0HHX+JhbwpFjpLQBqKpLp 9seCoCjCY7GaI/udON/vlYZ0TVOIHVDafFyGKreSfAy7qGkJ6NhYCZ1ZFLdp8RxZvfcR a3XqHo66xcPA3XJeEOUUOK8nA9Ws2L1Ic/T0LNfM07fYd9oOvoone+7CC4vFRQGsLj2c oGYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ILia9TnznEgu+zH0nAD0DU3ELIP+hXxx/xtqhrAXbUc=; b=kkPEqadsrawwVoNoLQAL5b3kope4nbLouFGJWZqoJ5TQ7qLBD3zgexYZJe2/T24o0H zm65hCr2X+s7ytI5Z0RgUMM1eWLiDbwoJLA3KtkwVDzTD1//WvA/v1LL1nl6grRSvVqM HOXvsIutb3iB9uZ86R+RcOZgs+h6lbv6k3HHsutRRi0+Q7YvTq3WQnV1NLdYzagovI5W sSHwVhrMJwg8hOiq+F3KLUZeSS2jrNMNINFQ4m29QEWJYJmuCrA2sCVKEZBsxU2NBQLc lEduiqcmaOUYGU3JndbnFZkiZ1B8UEa/YX/OjKjcYAGBdwVUunf9YB6X7G/1HmHMavK+ m6GQ== X-Gm-Message-State: AOAM530kLMkiWZe8UCeYJcn86cDL1A/Bwom4a6IwFbAPtNEm8jGNp43G 4UIvmAgrH5iYoeqrINNjXPmSwt9W4ZM= X-Google-Smtp-Source: ABdhPJxTY3pdJ7lF569LxTmk2KWEo0QxxkuPPcsGvnR/aBGc5UP4MwjsqxL3hZHfb6Skry/C5CQFew== X-Received: by 2002:ae9:ef4c:: with SMTP id d73mr6935367qkg.494.1629429601851; Thu, 19 Aug 2021 20:20:01 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id h68sm2668162qkf.126.2021.08.19.20.19.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Aug 2021 20:20:01 -0700 (PDT) From: CGEL X-Google-Original-From: CGEL To: Alain Volmat Cc: Mark Brown , Maxime Coquelin , Alexandre Torgue , linux-spi@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, jing yangyang , Zeal Robot Subject: [PATCH linux-next] spi-stm32: fix Coccinelle warnings Date: Thu, 19 Aug 2021 20:19:52 -0700 Message-Id: <20210820031952.12746-1-jing.yangyang@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: jing yangyang WARNING !A || A && B is equivalent to !A || B This issue was detected with the help of Coccinelle. Reported-by: Zeal Robot Signed-off-by: jing yangyang --- drivers/spi/spi-stm32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c index 14ca7ea..cc4a731 100644 --- a/drivers/spi/spi-stm32.c +++ b/drivers/spi/spi-stm32.c @@ -912,8 +912,8 @@ static irqreturn_t stm32h7_spi_irq_thread(int irq, void *dev_id) if (!spi->cur_usedma && (spi->rx_buf && (spi->rx_len > 0))) stm32h7_spi_read_rxfifo(spi); if (!spi->cur_usedma || - (spi->cur_usedma && (spi->cur_comm == SPI_SIMPLEX_TX || - spi->cur_comm == SPI_3WIRE_TX))) + (spi->cur_comm == SPI_SIMPLEX_TX || + spi->cur_comm == SPI_3WIRE_TX)) end = true; } -- 1.8.3.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED,DKIM_SIGNED,DKIM_VALID,FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BE585C4338F for ; Fri, 20 Aug 2021 03:22:09 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 82C38610CB for ; Fri, 20 Aug 2021 03:22:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 82C38610CB Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:Cc :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=W+w5/ERUAhtSL93pzcVO5PyAejBKFq0Q/zIQi9c21PQ=; b=f0idMUU5+9zJY2 hP6Qeo01BRJEkTz9N4amPGx69VHo8rLlxyKp6yr4h0IeMkDVmG9+EhcSjWn66WBXhLT0RG52eZgkH gC9zyzp0cmBmKQgVoKWyAjjpKVziP4HIe3u+AZ5Yg9drkuChJIxuw1yR7Vpq/yzPo4ZYBsZOOz9uX jk/ntND/l0WU5BlMl1sh3W7Nf6rtbY8oBWHYr5LEp1DpgFT8H+Uv352bKi2qNf9jXwjf1KAP88TZp aEewKbtKYOWwwGItFioB9Ue9fwrwWzTDaYIwmxk/VXQuAXToujiYq77WKB+0SivHGUs+tvfnhsvMc z6OYyL75k+oQFyXu+G7w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGv4g-009z9R-PS; Fri, 20 Aug 2021 03:20:06 +0000 Received: from mail-qk1-x72b.google.com ([2607:f8b0:4864:20::72b]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mGv4d-009z96-Hf for linux-arm-kernel@lists.infradead.org; Fri, 20 Aug 2021 03:20:04 +0000 Received: by mail-qk1-x72b.google.com with SMTP id t66so9604717qkb.0 for ; Thu, 19 Aug 2021 20:20:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ILia9TnznEgu+zH0nAD0DU3ELIP+hXxx/xtqhrAXbUc=; b=sjjsZXWb4ZAPdSvkpjDDeS63EK6LqAuKdpTC5PXtJlmaww/87Om/upXqpvAX2p0oOE +LdwtSl8oH66cE9XdrtTVCLQT4iaBimtscoyGxjKhF1pdFI8qWmZ956TqWei0pjD6Dr1 o6VecAO0cN+QaIVxrL5h/7Mfu5pkjyj6nVIJWTHsisCA7Gc0HHX+JhbwpFjpLQBqKpLp 9seCoCjCY7GaI/udON/vlYZ0TVOIHVDafFyGKreSfAy7qGkJ6NhYCZ1ZFLdp8RxZvfcR a3XqHo66xcPA3XJeEOUUOK8nA9Ws2L1Ic/T0LNfM07fYd9oOvoone+7CC4vFRQGsLj2c oGYQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=ILia9TnznEgu+zH0nAD0DU3ELIP+hXxx/xtqhrAXbUc=; b=V4V/nBkazJRGJgrgHkXDE916oSXpj1jcrYBlxh5tnTggDSoV1xPCTqQEPZv2accMJ5 aynqOtvfekdTOoWE2a8ojMIrVFK4OC5hr+sLtDBiCjevoFCPZR5Z2HR6hrKyINCU43xn zOSaEYvhGV/nbK47wQtNl4GA5PBI+hindLgtZqlsDVzPmHaG5zv2aKqojCQEkF6BgQIa xY1msUbenmDYMUhoi9q2HbaE+3QDKpSRF8+sAO9lOlBhWQVxJZ9TUPJZ7gra0gEaF4KX o/Dgh1ZXNoG5/V9VPXDfZKslycPjM3qIsdbC2fuQN0j3Y1OgKqYUEGFJIi3n7vAV4uId 0K0g== X-Gm-Message-State: AOAM532KidKCwYX0Diag2PUNglZ+TpwRncHv9yrklLFXiADBZwshmf/Q 0ziCNYvFGbOTgGcq+Yu3VPw= X-Google-Smtp-Source: ABdhPJxTY3pdJ7lF569LxTmk2KWEo0QxxkuPPcsGvnR/aBGc5UP4MwjsqxL3hZHfb6Skry/C5CQFew== X-Received: by 2002:ae9:ef4c:: with SMTP id d73mr6935367qkg.494.1629429601851; Thu, 19 Aug 2021 20:20:01 -0700 (PDT) Received: from localhost.localdomain ([193.203.214.57]) by smtp.gmail.com with ESMTPSA id h68sm2668162qkf.126.2021.08.19.20.19.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 19 Aug 2021 20:20:01 -0700 (PDT) From: CGEL X-Google-Original-From: CGEL To: Alain Volmat Cc: Mark Brown , Maxime Coquelin , Alexandre Torgue , linux-spi@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, jing yangyang , Zeal Robot Subject: [PATCH linux-next] spi-stm32: fix Coccinelle warnings Date: Thu, 19 Aug 2021 20:19:52 -0700 Message-Id: <20210820031952.12746-1-jing.yangyang@zte.com.cn> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210819_202003_649518_0AFE44F5 X-CRM114-Status: GOOD ( 12.87 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: jing yangyang WARNING !A || A && B is equivalent to !A || B This issue was detected with the help of Coccinelle. Reported-by: Zeal Robot Signed-off-by: jing yangyang --- drivers/spi/spi-stm32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/spi/spi-stm32.c b/drivers/spi/spi-stm32.c index 14ca7ea..cc4a731 100644 --- a/drivers/spi/spi-stm32.c +++ b/drivers/spi/spi-stm32.c @@ -912,8 +912,8 @@ static irqreturn_t stm32h7_spi_irq_thread(int irq, void *dev_id) if (!spi->cur_usedma && (spi->rx_buf && (spi->rx_len > 0))) stm32h7_spi_read_rxfifo(spi); if (!spi->cur_usedma || - (spi->cur_usedma && (spi->cur_comm == SPI_SIMPLEX_TX || - spi->cur_comm == SPI_3WIRE_TX))) + (spi->cur_comm == SPI_SIMPLEX_TX || + spi->cur_comm == SPI_3WIRE_TX)) end = true; } -- 1.8.3.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel