From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 92B3FC432BE for ; Fri, 20 Aug 2021 06:08:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 21AA460FF2 for ; Fri, 20 Aug 2021 06:08:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 21AA460FF2 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:43722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mGxi3-0006Ro-8K for qemu-devel@archiver.kernel.org; Fri, 20 Aug 2021 02:08:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34224) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGxgg-0005Yp-Qq for qemu-devel@nongnu.org; Fri, 20 Aug 2021 02:07:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:54977) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mGxgb-0007v5-Gc for qemu-devel@nongnu.org; Fri, 20 Aug 2021 02:07:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629439637; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=xsLMEBc/3vvxc/MLHz3cVFR0qb6gpoJ9PareRakC5ZA=; b=Ld09w0uzIpiKUB+gvj1mExJoBWjDODAg19gfS/Qqzy9t5o+g+qsdg+9I6fNm9eXxo8KsRp utPg8MSmlrFnFBNP2VJha7ublkLeloiHZNTgJ8j+gpGu+s1CY6T4TGJeAEVd2CIDDuKSIo qx+xj6+BCjeyaIwtgI+M4zFN4QycLt4= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-429-IN5f6ztTP86XtOpEnEqBng-1; Fri, 20 Aug 2021 02:07:16 -0400 X-MC-Unique: IN5f6ztTP86XtOpEnEqBng-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B85341082921; Fri, 20 Aug 2021 06:07:14 +0000 (UTC) Received: from sirius.home.kraxel.org (unknown [10.39.193.216]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 255DF60C13; Fri, 20 Aug 2021 06:07:04 +0000 (UTC) Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 494B218007A6; Fri, 20 Aug 2021 08:07:03 +0200 (CEST) Date: Fri, 20 Aug 2021 08:07:03 +0200 From: Gerd Hoffmann To: Peter Maydell Subject: Re: [RFC PATCH 6/6] memory: Have address_space_create() re-use global &address_space_memory Message-ID: <20210820060703.njdj5pfa3lz66zjb@sirius.home.kraxel.org> References: <20210819142039.2825366-1-philmd@redhat.com> <20210819142039.2825366-7-philmd@redhat.com> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=kraxel@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=kraxel@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.7, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: David Hildenbrand , Mark Cave-Ayland , Alistair Francis , Jianxian Wen , QEMU Developers , Peter Xu , qemu-arm , "Edgar E. Iglesias" , Paolo Bonzini , Philippe =?utf-8?Q?Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi, > This also seems to me to be the tail wagging the dog. If we think > 'info mtree' has too much duplicate information (which it certainly > does) then we should make mtree_info() smarter about reducing that > duplication. Off the top of my head, we could change the code that > prints ASes to do something like: > qemu_printf("...same as address-space %s\n", name); Neat idea. Having 'info mtree' accept an (optional) 'name' parameter to pick an address space to be printed would be useful too. take care, Gerd