From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_2 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C04A9C432BE for ; Fri, 20 Aug 2021 14:13:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ABAB0610FF for ; Fri, 20 Aug 2021 14:13:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S240801AbhHTOOE (ORCPT ); Fri, 20 Aug 2021 10:14:04 -0400 Received: from mail.kernel.org ([198.145.29.99]:35730 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235032AbhHTOOD (ORCPT ); Fri, 20 Aug 2021 10:14:03 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 35874601FD; Fri, 20 Aug 2021 14:13:25 +0000 (UTC) Date: Fri, 20 Aug 2021 10:13:18 -0400 From: Steven Rostedt To: Masami Hiramatsu Cc: linux-kernel@vger.kernel.org, linux-trace-devel@vger.kernel.org, Ingo Molnar , Andrew Morton , "Tzvetomir Stoyanov" , Tom Zanussi , Shuah Khan , Shuah Khan , linux-kselftest@vger.kernel.org Subject: Re: [PATCH v8 5/5] selftests/ftrace: Add selftest for testing duplicate eprobes and kprobes Message-ID: <20210820101318.542d5cc2@oasis.local.home> In-Reply-To: <20210820095359.f99a6cecb9886d8809685465@kernel.org> References: <20210819152604.704335282@goodmis.org> <20210819152825.715290342@goodmis.org> <20210820095359.f99a6cecb9886d8809685465@kernel.org> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Aug 2021 09:53:59 +0900 Masami Hiramatsu wrote: > Hmm, can you also remove kprobe event dependency from this test case? > The event probe depends on CONFIG_PROBE_EVENTS meta config, but that > is enabled both of CONFIG_KPROBE_EVENTS and CONFIG_UPROBE_EVENTS. > This means if the kernel configs CONFIG_KPROBE_EVENTS=n and > CONFIG_UPROBE_EVENTS=y, this will be executed but should fail. I'll add a check if kprobes are available before testing the kprobes. -- Steve