From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 552ADC4338F for ; Fri, 20 Aug 2021 16:34:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3168C61152 for ; Fri, 20 Aug 2021 16:34:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230295AbhHTQfO (ORCPT ); Fri, 20 Aug 2021 12:35:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:51270 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229564AbhHTQfO (ORCPT ); Fri, 20 Aug 2021 12:35:14 -0400 Received: from oasis.local.home (cpe-66-24-58-225.stny.res.rr.com [66.24.58.225]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 585836113B; Fri, 20 Aug 2021 16:34:35 +0000 (UTC) Date: Fri, 20 Aug 2021 12:34:28 -0400 From: Steven Rostedt To: Cc: mathieu.desnoyers@efficios.com, akpm@linux-foundation.org, metze@samba.org, mingo@redhat.com, paulmck@kernel.org, peterz@infradead.org, Subject: Re: FAILED: patch "[PATCH] tracepoint: Use rcu get state and cond sync for static call" failed to apply to 5.10-stable tree Message-ID: <20210820123428.2ac6a814@oasis.local.home> In-Reply-To: <20210819204204.00f9ad28@rorschach.local.home> References: <1628500832155134@kroah.com> <20210819170933.5c4c6a38@oasis.local.home> <20210819204204.00f9ad28@rorschach.local.home> X-Mailer: Claws Mail 3.18.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org Greg, Paul, Any comment on this? -- Steve On Thu, 19 Aug 2021 20:42:04 -0400 Steven Rostedt wrote: > On Thu, 19 Aug 2021 17:09:33 -0400 > Steven Rostedt wrote: > > > Mathieu, seems that the "slow down 10x" patch was able to be backported > > to 5.10, where as this patch was not. Reason being is that > > start_poll_synchronize_rcu() was added in 5.13. > > I can get this to work if I backport the following RCU patches: > > 29d2bb94a8a126ce80ffbb433b648b32fdea524e > srcu: Provide internal interface to start a Tree SRCU grace period > > 5358c9fa54b09b5d3d7811b033aa0838c1bbaaf2 > srcu: Provide polling interfaces for Tree SRCU grace periods > > 1a893c711a600ab57526619b56e6f6b7be00956e > srcu: Provide internal interface to start a Tiny SRCU grace period > > 8b5bd67cf6422b63ee100d76d8de8960ca2df7f0 > srcu: Provide polling interfaces for Tiny SRCU grace periods > > The first three can be cherry-picked without issue. The last one has a > small conflict, of: > > include/linux/srcutiny.h.rej: > --- include/linux/srcutiny.h > +++ include/linux/srcutiny.h > @@ -16,6 +16,7 @@ > struct srcu_struct { > short srcu_lock_nesting[2]; /* srcu_read_lock() nesting depth. */ > unsigned short srcu_idx; /* Current reader array element in bit 0x2. */ > + unsigned short srcu_idx_max; /* Furthest future srcu_idx request. */ > u8 srcu_gp_running; /* GP workqueue running? */ > u8 srcu_gp_waiting; /* GP waiting for readers? */ > struct swait_queue_head srcu_wq; > > > Which I just added that line, and everything worked. > > Paul, do you have any issues with these four patches getting backported? > > Greg, Are you OK with them too? > > Once those are backported, this patch can be backported as well, and > everything should work. This patch really needs to stay with: > > 231264d6927f6740af36855a622d0e240be9d94c > tracepoint: Fix static call function vs data state mismatch > > Otherwise I would say to revert it if this one can't be backported with > it. > > -- Steve