From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EF3C3C4338F for ; Fri, 20 Aug 2021 18:35:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CC2FC6113E for ; Fri, 20 Aug 2021 18:35:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236264AbhHTSgO (ORCPT ); Fri, 20 Aug 2021 14:36:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:57512 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229927AbhHTSgM (ORCPT ); Fri, 20 Aug 2021 14:36:12 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id D09B56113D; Fri, 20 Aug 2021 18:35:33 +0000 (UTC) Date: Fri, 20 Aug 2021 19:35:21 +0100 From: Catalin Marinas To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, Will Deacon , linux-kernel@vger.kernel.org, Mark Rutland Subject: Re: [PATCH V2] arm64/mm: Drop Message-ID: <20210820183520.GC23080@arm.com> References: <1629457516-32306-1-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1629457516-32306-1-git-send-email-anshuman.khandual@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 20, 2021 at 04:35:16PM +0530, Anshuman Khandual wrote: > PAGE_SHIFT (PAGE_SIZE and PAGE_MASK) which is derived from ARM64_PAGE_SHIFT > should be moved into instead like in case for other platforms, > and then subsequently can be just dropped off completely. These were moved to page-def.h as part of commit b6531456ba27 ("arm64: factor out PAGE_* and CONT_* definitions") to avoid some circular header dependencies. > diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h > index 824a3655dd93..649d26396f9e 100644 > --- a/arch/arm64/include/asm/memory.h > +++ b/arch/arm64/include/asm/memory.h > @@ -12,7 +12,7 @@ > > #include > #include > -#include > +#include In 5.14-rc3, asm/page.h still includes asm/memory.h. -- Catalin From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84273C4338F for ; Fri, 20 Aug 2021 18:37:17 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5342760F8F for ; Fri, 20 Aug 2021 18:37:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 5342760F8F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=OMXjwK59ozom4l/fnXdTDP6iCkoNorXWA9cJJ6qWX8A=; b=RgBCy6c56+PdH1 XiMBeJeVyyd6tj7kvARrmM4tszXHB6Xz7yse390u2akr4uFan9NbS+TCERj08R9aQaUqC4yMPcLEW QL36vgyDX93obn/2x3MeiZH8AGNphUtOFZe2ndJvS/I8qw2nQGvhM/SBQ0dbKD4ATOaiRplrHpYFJ Tkc8i1HLykQKmlUAdgxXV/svtuRuPazD44yfqoI7JCCaSNXpckcNIp/bDYiZiUDRbf46QjemA+MEA 65THnBSXDGsoLQAFGAIzDT6SMG8JmFlCHX39Sefdacehkx/81bvt/EkxNUGelHWmoOlfBO2S02+l/ k8/EdmZGkc77JZhVluxA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mH9Ml-00Btay-5K; Fri, 20 Aug 2021 18:35:43 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mH9Md-00BtZQ-4g for linux-arm-kernel@lists.infradead.org; Fri, 20 Aug 2021 18:35:37 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id D09B56113D; Fri, 20 Aug 2021 18:35:33 +0000 (UTC) Date: Fri, 20 Aug 2021 19:35:21 +0100 From: Catalin Marinas To: Anshuman Khandual Cc: linux-arm-kernel@lists.infradead.org, Will Deacon , linux-kernel@vger.kernel.org, Mark Rutland Subject: Re: [PATCH V2] arm64/mm: Drop Message-ID: <20210820183520.GC23080@arm.com> References: <1629457516-32306-1-git-send-email-anshuman.khandual@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1629457516-32306-1-git-send-email-anshuman.khandual@arm.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210820_113535_239828_E02DA994 X-CRM114-Status: GOOD ( 11.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 20, 2021 at 04:35:16PM +0530, Anshuman Khandual wrote: > PAGE_SHIFT (PAGE_SIZE and PAGE_MASK) which is derived from ARM64_PAGE_SHIFT > should be moved into instead like in case for other platforms, > and then subsequently can be just dropped off completely. These were moved to page-def.h as part of commit b6531456ba27 ("arm64: factor out PAGE_* and CONT_* definitions") to avoid some circular header dependencies. > diff --git a/arch/arm64/include/asm/memory.h b/arch/arm64/include/asm/memory.h > index 824a3655dd93..649d26396f9e 100644 > --- a/arch/arm64/include/asm/memory.h > +++ b/arch/arm64/include/asm/memory.h > @@ -12,7 +12,7 @@ > > #include > #include > -#include > +#include In 5.14-rc3, asm/page.h still includes asm/memory.h. -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel