All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bjorn Helgaas <helgaas@kernel.org>
To: Jakub Kicinski <kuba@kernel.org>
Cc: bhelgaas@google.com, david.e.box@linux.intel.com,
	linux-pci@vger.kernel.org, rafael.j.wysocki@intel.com
Subject: Re: [PATCH] pci: ptm: remove error message at boot
Date: Fri, 20 Aug 2021 16:10:28 -0500	[thread overview]
Message-ID: <20210820211028.GA3358973@bjorn-Precision-5520> (raw)
In-Reply-To: <20210811185955.3112534-1-kuba@kernel.org>

On Wed, Aug 11, 2021 at 11:59:55AM -0700, Jakub Kicinski wrote:
> Since commit 39850ed51062 ("PCI/PTM: Save/restore Precision
> Time Measurement Capability for suspend/resume") devices
> which have PTM capability but don't enable it see this
> message on calls to pci_save_state():
> 
>   "no suspend buffer for PTM"
> 
> Drop the message, it's perfectly fine not to use a capability.
> 
> Fixes: 39850ed51062 ("PCI/PTM: Save/restore Precision Time Measurement Capability for suspend/resume")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>

Applied to pci/misc for v5.15, thanks!

I fixed your subject line to match previous ones and converted David's
informal ack to an actual "Acked-by".

> ---
>  drivers/pci/pcie/ptm.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/pci/pcie/ptm.c b/drivers/pci/pcie/ptm.c
> index 95d4eef2c9e8..4810faa67f52 100644
> --- a/drivers/pci/pcie/ptm.c
> +++ b/drivers/pci/pcie/ptm.c
> @@ -60,10 +60,8 @@ void pci_save_ptm_state(struct pci_dev *dev)
>  		return;
>  
>  	save_state = pci_find_saved_ext_cap(dev, PCI_EXT_CAP_ID_PTM);
> -	if (!save_state) {
> -		pci_err(dev, "no suspend buffer for PTM\n");
> +	if (!save_state)
>  		return;
> -	}
>  
>  	cap = (u16 *)&save_state->cap.data[0];
>  	pci_read_config_word(dev, ptm + PCI_PTM_CTRL, cap);
> -- 
> 2.31.1
> 

      parent reply	other threads:[~2021-08-20 21:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-11 18:59 [PATCH] pci: ptm: remove error message at boot Jakub Kicinski
2021-08-11 22:29 ` David E. Box
2021-08-20 21:10 ` Bjorn Helgaas [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210820211028.GA3358973@bjorn-Precision-5520 \
    --to=helgaas@kernel.org \
    --cc=bhelgaas@google.com \
    --cc=david.e.box@linux.intel.com \
    --cc=kuba@kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.