From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
To: Vladimir Oltean <vladimir.oltean@nxp.com>
Cc: Alexandre Belloni <alexandre.belloni@bootlin.com>,
devicetree@vger.kernel.org, UNGLinuxDriver@microchip.com,
Horatiu Vultur <horatiu.vultur@microchip.com>,
Rob Herring <robh+dt@kernel.org>,
linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH devicetree 1/2] MIPS: mscc: ocelot: disable all switch ports by default
Date: Sat, 21 Aug 2021 10:41:51 +0200 [thread overview]
Message-ID: <20210821084151.GC3555@alpha.franken.de> (raw)
In-Reply-To: <20210819170416.2252210-1-vladimir.oltean@nxp.com>
On Thu, Aug 19, 2021 at 08:04:15PM +0300, Vladimir Oltean wrote:
> The ocelot switch driver used to ignore ports which do not have a
> phy-handle property and not probe those, but this is not quite ok since
> it is valid to not have a phy-handle property if there is a fixed-link.
>
> It seems that checking for a phy-handle was a proxy for the proper check
> which is for the status, but that doesn't make a lot of sense, since the
> ocelot driver already iterates using for_each_available_child_of_node
> which skips the disabled ports, so I have no idea.
>
> Anyway, a widespread pattern in device trees is for a SoC dtsi to
> disable by default all hardware, and let board dts files enable what is
> used. So let's do that and enable only the ports with a phy-handle in
> the pcb120 and pcb123 device tree files.
>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
> arch/mips/boot/dts/mscc/ocelot.dtsi | 11 +++++++++++
> arch/mips/boot/dts/mscc/ocelot_pcb120.dts | 8 ++++++++
> arch/mips/boot/dts/mscc/ocelot_pcb123.dts | 4 ++++
> 3 files changed, 23 insertions(+)
applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
prev parent reply other threads:[~2021-08-21 9:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-19 17:04 [PATCH devicetree 1/2] MIPS: mscc: ocelot: disable all switch ports by default Vladimir Oltean
2021-08-19 17:04 ` [PATCH devicetree 2/2] MIPS: mscc: ocelot: mark the phy-mode for internal PHY ports Vladimir Oltean
2021-08-19 17:17 ` Vladimir Oltean
2021-08-19 17:58 ` Alexandre Belloni
2021-08-21 8:42 ` Thomas Bogendoerfer
2021-08-21 8:41 ` Thomas Bogendoerfer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210821084151.GC3555@alpha.franken.de \
--to=tsbogend@alpha.franken.de \
--cc=UNGLinuxDriver@microchip.com \
--cc=alexandre.belloni@bootlin.com \
--cc=devicetree@vger.kernel.org \
--cc=horatiu.vultur@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.