From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: multipart/mixed; boundary="===============0660385428959794972==" MIME-Version: 1.0 From: kernel test robot Subject: [PATCH] coccinelle: irqf_oneshot: fix irqf_oneshot.cocci warnings Date: Sat, 21 Aug 2021 18:22:56 +0800 Message-ID: <20210821102255.GA43436@999fdb78b12b> In-Reply-To: <202108211838.ZPYNXat3-lkp@intel.com> List-Id: To: kbuild@lists.01.org --===============0660385428959794972== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable CC: kbuild-all(a)lists.01.org CC: linux-kernel(a)vger.kernel.org TO: Krzysztof Kozlowski CC: Julia Lawall CC: Lee Jones CC: linux-kernel(a)vger.kernel.org From: kernel test robot drivers/mfd/htc-i2cpld.c:546:8-28: WARNING: Threaded IRQ with no primary ha= ndler requested without IRQF_ONESHOT (unless it is nested IRQ) Since commit 1c6c69525b40 ("genirq: Reject bogus threaded irq requests") threaded IRQs without a primary handler need to be requested with IRQF_ONESHOT, otherwise the request will fail. So pass the IRQF_ONESHOT flag in this case. Generated by: scripts/coccinelle/misc/irqf_oneshot.cocci CC: Krzysztof Kozlowski Reported-by: kernel test robot Signed-off-by: kernel test robot --- tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git = master head: fa54d366a6e4fe3e16322abdb8b5115f8be0da8b commit: 5d2db9bb5f8a850d037983f0df72ad59cefa9e3d coccinelle: irqf_oneshot: = reduce the severity due to false positives :::::: branch date: 14 hours ago :::::: commit date: 4 months ago Please take the patch only if it's a positive warning. Thanks! htc-i2cpld.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/mfd/htc-i2cpld.c +++ b/drivers/mfd/htc-i2cpld.c @@ -545,7 +545,8 @@ static int htcpld_core_probe(struct plat IRQF_ONESHOT; ret =3D request_threaded_irq(htcpld->chained_irq, NULL, htcpld_handler, - flags, pdev->name, htcpld); + flags | IRQF_ONESHOT, pdev->name, + htcpld); if (ret) { dev_warn(dev, "Unable to setup chained irq handler: %d\n", ret); return ret; --===============0660385428959794972==--