From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1668C4320A for ; Sat, 21 Aug 2021 01:40:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AE9C66115A for ; Sat, 21 Aug 2021 01:40:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S237700AbhHUBla (ORCPT ); Fri, 20 Aug 2021 21:41:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:35224 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229783AbhHUBl3 (ORCPT ); Fri, 20 Aug 2021 21:41:29 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id C4F5F61163; Sat, 21 Aug 2021 01:40:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629510051; bh=yKkJ4SLfNYw+uYg298yLZSt7Kzso3olgvrYqbSi4JpQ=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tirdiOdTmkhhkR0Rj6yNbP3zMxa/wl6C1Hr8R3Z7pR7FoEnwrYzeEebuJM0/yPYje 7QE7DH5NkZDJf0v7XtM/8XrAj3rlJPIC3aK3ZtRdkH7fqRQwR90lG8ZfnGr0/e8Ar/ m5BF0a9egBr65g3MsULoK9eekLiTLStfoaIiU8rh3upNj+0vJsCXU2N5b2WKwo2rNT iFfKx55e+z/GHIb2GRaF9CX/nhrQWYwp6KOXzp3k7iJcpQwpSbcl+zV/IU/YyrHDKt WJTx3/wrqB7R6ZFMyFct2mzPnk3RhBvUYWiY8a8xVsiYXp62iXWFQgxO3F1q2y+Kc+ Bm0f+o+dRR6EQ== Date: Sat, 21 Aug 2021 10:40:48 +0900 From: Masami Hiramatsu To: Steven Rostedt Cc: linux-kernel@vger.kernel.org, linux-trace-devel@vger.kernel.org, Ingo Molnar , Andrew Morton , Masami Hiramatsu , "Tzvetomir Stoyanov" , Tom Zanussi , Shuah Khan , Shuah Khan , linux-kselftest@vger.kernel.org Subject: Re: [PATCH v9 4/6] selftests/ftrace: Add test case to test adding and removing of event probe Message-Id: <20210821104048.2eeda1067909e7df0771bef6@kernel.org> In-Reply-To: <20210820204742.274591200@goodmis.org> References: <20210820204644.546662591@goodmis.org> <20210820204742.274591200@goodmis.org> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 20 Aug 2021 16:46:48 -0400 Steven Rostedt wrote: > From: "Steven Rostedt (VMware)" > > Add a test case that adds an event probe, makes sure that it works, and > then removes it. > > Link: https://lore.kernel.org/linux-kselftest/20210819152825.526931866@goodmis.org/ > > Cc: Shuah Khan > Cc: Shuah Khan > Cc: linux-kselftest@vger.kernel.org > Signed-off-by: Steven Rostedt (VMware) This looks good to me. Acked-by: Masami Hiramatsu Thank you! > --- > .../test.d/dynevent/add_remove_eprobe.tc | 40 +++++++++++++++++++ > 1 file changed, 40 insertions(+) > create mode 100644 tools/testing/selftests/ftrace/test.d/dynevent/add_remove_eprobe.tc > > diff --git a/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_eprobe.tc b/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_eprobe.tc > new file mode 100644 > index 000000000000..25a3da4eaa44 > --- /dev/null > +++ b/tools/testing/selftests/ftrace/test.d/dynevent/add_remove_eprobe.tc > @@ -0,0 +1,40 @@ > +#!/bin/sh > +# SPDX-License-Identifier: GPL-2.0 > +# description: Generic dynamic event - add/remove eprobe events > +# requires: dynamic_events events/syscalls/sys_enter_openat "e[:[/]] . []":README > + > +echo 0 > events/enable > + > +clear_dynamic_events > + > +SYSTEM="syscalls" > +EVENT="sys_enter_openat" > +FIELD="filename" > +EPROBE="eprobe_open" > + > +echo "e:$EPROBE $SYSTEM/$EVENT file=+0(\$filename):ustring" >> dynamic_events > + > +grep -q "$EPROBE" dynamic_events > +test -d events/eprobes/$EPROBE > + > +echo 1 > events/eprobes/$EPROBE/enable > +ls > +echo 0 > events/eprobes/$EPROBE/enable > + > +content=`grep '^ *ls-' trace | grep 'file='` > +nocontent=`grep '^ *ls-' trace | grep 'file=' | grep -v -e '"/' -e '"."'` || true > + > +if [ -z "$content" ]; then > + exit_fail > +fi > + > +if [ ! -z "$nocontent" ]; then > + exit_fail > +fi > + > +echo "-:$EPROBE" >> dynamic_events > + > +! grep -q "$EPROBE" dynamic_events > +! test -d events/eprobes/$EPROBE > + > +clear_trace > -- > 2.30.2 -- Masami Hiramatsu