All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH for-5.15] ASoC: intel: atom: Revert PCM buffer address setup workaround again
@ 2021-08-22  7:21 Takashi Iwai
  2021-08-23 11:37 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Takashi Iwai @ 2021-08-22  7:21 UTC (permalink / raw)
  To: alsa-devel

We worked around the breakage of PCM buffer setup by the commit
65ca89c2b12c ("ASoC: intel: atom: Fix breakage for PCM buffer address
setup"), but this isn't necessary since the CONTINUOUS buffer type
also sets runtime->dma_addr since commit f84ba106a018 ("ALSA:
memalloc: Store snd_dma_buffer.addr for continuous pages, too").
Let's revert the change again.

Signed-off-by: Takashi Iwai <tiwai@suse.de>
---

The patch is to be applied on my for-next branch once after merging
for-linus branch.

 sound/soc/intel/atom/sst-mfld-platform-pcm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/intel/atom/sst-mfld-platform-pcm.c b/sound/soc/intel/atom/sst-mfld-platform-pcm.c
index 905c7965f653..5db2f4865bbb 100644
--- a/sound/soc/intel/atom/sst-mfld-platform-pcm.c
+++ b/sound/soc/intel/atom/sst-mfld-platform-pcm.c
@@ -127,7 +127,7 @@ static void sst_fill_alloc_params(struct snd_pcm_substream *substream,
 	snd_pcm_uframes_t period_size;
 	ssize_t periodbytes;
 	ssize_t buffer_bytes = snd_pcm_lib_buffer_bytes(substream);
-	u32 buffer_addr = virt_to_phys(substream->runtime->dma_area);
+	u32 buffer_addr = substream->runtime->dma_addr;
 
 	channels = substream->runtime->channels;
 	period_size = substream->runtime->period_size;
-- 
2.26.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH for-5.15] ASoC: intel: atom: Revert PCM buffer address setup workaround again
  2021-08-22  7:21 [PATCH for-5.15] ASoC: intel: atom: Revert PCM buffer address setup workaround again Takashi Iwai
@ 2021-08-23 11:37 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2021-08-23 11:37 UTC (permalink / raw)
  To: alsa-devel

On Sun, 22 Aug 2021 09:21:27 +0200,
Takashi Iwai wrote:
> 
> We worked around the breakage of PCM buffer setup by the commit
> 65ca89c2b12c ("ASoC: intel: atom: Fix breakage for PCM buffer address
> setup"), but this isn't necessary since the CONTINUOUS buffer type
> also sets runtime->dma_addr since commit f84ba106a018 ("ALSA:
> memalloc: Store snd_dma_buffer.addr for continuous pages, too").
> Let's revert the change again.
> 
> Signed-off-by: Takashi Iwai <tiwai@suse.de>
> ---
> 
> The patch is to be applied on my for-next branch once after merging
> for-linus branch.

Now merged to for-next branch.


Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-23 11:38 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-22  7:21 [PATCH for-5.15] ASoC: intel: atom: Revert PCM buffer address setup workaround again Takashi Iwai
2021-08-23 11:37 ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.