Re: [PATCH RFC v2 3/6] staging: r8188eu: add error handling of rtw_read8

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 4393 bytes --]

Hi Pavel,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on staging/staging-testing]

url:    https://github.com/0day-ci/linux/commits/Pavel-Skripkin/staging-r8188eu-remove-read-write-_macreg/20210822-233538
base:   https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git 093991aaadf0fbb34184fa37a46e7a157da3f386
config: arc-allyesconfig (attached as .config)
compiler: arceb-elf-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/2b557bc2dab8449fa9bb37a8a4c36b0714b007f7
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Pavel-Skripkin/staging-r8188eu-remove-read-write-_macreg/20210822-233538
        git checkout 2b557bc2dab8449fa9bb37a8a4c36b0714b007f7
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=arc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

   drivers/staging/r8188eu/os_dep/ioctl_linux.c: In function 'rtw_dbg_mode_hdl':
>> drivers/staging/r8188eu/os_dep/ioctl_linux.c:2258:13: warning: variable 'error' set but not used [-Wunused-but-set-variable]
    2258 |         int error;
         |             ^~~~~


vim +/error +2258 drivers/staging/r8188eu/os_dep/ioctl_linux.c

  2250	
  2251	static void rtw_dbg_mode_hdl(struct adapter *padapter, u32 id, u8 *pdata, u32 len)
  2252	{
  2253		struct mp_rw_reg *RegRWStruct;
  2254		struct rf_reg_param *prfreg;
  2255		u8 path;
  2256		u8 offset;
  2257		u32 value;
> 2258		int error;
  2259	
  2260		DBG_88E("%s\n", __func__);
  2261	
  2262		switch (id) {
  2263		case GEN_MP_IOCTL_SUBCODE(MP_START):
  2264			DBG_88E("871x_driver is only for normal mode, can't enter mp mode\n");
  2265			break;
  2266		case GEN_MP_IOCTL_SUBCODE(READ_REG):
  2267			RegRWStruct = (struct mp_rw_reg *)pdata;
  2268			switch (RegRWStruct->width) {
  2269			case 1:
  2270				error = rtw_read8(padapter, RegRWStruct->offset,
  2271						 (u8 *) &RegRWStruct->value);
  2272				break;
  2273			case 2:
  2274				RegRWStruct->value = rtw_read16(padapter, RegRWStruct->offset);
  2275				break;
  2276			case 4:
  2277				RegRWStruct->value = rtw_read32(padapter, RegRWStruct->offset);
  2278				break;
  2279			default:
  2280				break;
  2281			}
  2282	
  2283			break;
  2284		case GEN_MP_IOCTL_SUBCODE(WRITE_REG):
  2285			RegRWStruct = (struct mp_rw_reg *)pdata;
  2286			switch (RegRWStruct->width) {
  2287			case 1:
  2288				rtw_write8(padapter, RegRWStruct->offset, (u8)RegRWStruct->value);
  2289				break;
  2290			case 2:
  2291				rtw_write16(padapter, RegRWStruct->offset, (u16)RegRWStruct->value);
  2292				break;
  2293			case 4:
  2294				rtw_write32(padapter, RegRWStruct->offset, (u32)RegRWStruct->value);
  2295				break;
  2296			default:
  2297				break;
  2298			}
  2299	
  2300			break;
  2301		case GEN_MP_IOCTL_SUBCODE(READ_RF_REG):
  2302	
  2303			prfreg = (struct rf_reg_param *)pdata;
  2304	
  2305			path = (u8)prfreg->path;
  2306			offset = (u8)prfreg->offset;
  2307	
  2308			value = rtw_hal_read_rfreg(padapter, path, offset, 0xffffffff);
  2309	
  2310			prfreg->value = value;
  2311	
  2312			break;
  2313		case GEN_MP_IOCTL_SUBCODE(WRITE_RF_REG):
  2314	
  2315			prfreg = (struct rf_reg_param *)pdata;
  2316	
  2317			path = (u8)prfreg->path;
  2318			offset = (u8)prfreg->offset;
  2319			value = prfreg->value;
  2320	
  2321			rtw_hal_write_rfreg(padapter, path, offset, 0xffffffff, value);
  2322	
  2323			break;
  2324		case GEN_MP_IOCTL_SUBCODE(TRIGGER_GPIO):
  2325			DBG_88E("==> trigger gpio 0\n");
  2326			rtw_hal_set_hwreg(padapter, HW_VAR_TRIGGER_GPIO_0, NULL);
  2327			break;
  2328		case GEN_MP_IOCTL_SUBCODE(GET_WIFI_STATUS):
  2329			*pdata = rtw_hal_sreset_get_wifi_status(padapter);
  2330			break;
  2331		default:
  2332			break;
  2333		}
  2334	}
  2335	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all(a)lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 68459 bytes --]