Re: [RFC PATCH net-next 4/5] net: dsa: realtek-smi: add rtl8365mb subdriver for RTL8365MB-VC

[kernel test robot <lkp@intel.com>]

[-- Attachment #1: Type: text/plain, Size: 3692 bytes --]

Hi "Alvin,

[FYI, it's a private test report for your RFC patch.]
[auto build test WARNING on net-next/master]

url:    https://github.com/0day-ci/linux/commits/Alvin-ipraga/net-dsa-add-support-for-RTL8365MB-VC/20210823-033419
base:   https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 9b60ac54ab7cf92af76240cdad549e8fde605eee
config: x86_64-randconfig-a014-20210822 (attached as .config)
compiler: clang version 14.0.0 (https://github.com/llvm/llvm-project a83d99c55ebb14532c414066a5aa3bdb65389965)
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/678769f73446be05b2f03f10fe1ccbe161a35019
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Alvin-ipraga/net-dsa-add-support-for-RTL8365MB-VC/20210823-033419
        git checkout 678769f73446be05b2f03f10fe1ccbe161a35019
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross ARCH=x86_64 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/net/dsa/rtl8365mb.c:1188:5: warning: no previous prototype for function 'rtl8365mb_port_vlan_filtering' [-Wmissing-prototypes]
   int rtl8365mb_port_vlan_filtering(struct dsa_switch *ds, int port,
       ^
   drivers/net/dsa/rtl8365mb.c:1188:1: note: declare 'static' if the function is not intended to be used outside of this translation unit
   int rtl8365mb_port_vlan_filtering(struct dsa_switch *ds, int port,
   ^
   static 
>> drivers/net/dsa/rtl8365mb.c:1755:24: warning: variable 'irq' is uninitialized when used here [-Wuninitialized]
                   irq_set_parent(virq, irq);
                                        ^~~
   drivers/net/dsa/rtl8365mb.c:1727:9: note: initialize the variable 'irq' to silence this warning
           int irq;
                  ^
                   = 0
>> drivers/net/dsa/rtl8365mb.c:1943:20: warning: variable 'mb' set but not used [-Wunused-but-set-variable]
           struct rtl8365mb *mb;
                             ^
   3 warnings generated.


vim +/rtl8365mb_port_vlan_filtering +1188 drivers/net/dsa/rtl8365mb.c

  1187	
> 1188	int rtl8365mb_port_vlan_filtering(struct dsa_switch *ds, int port,
  1189					  bool vlan_filtering,
  1190					  struct netlink_ext_ack *extack)
  1191	{
  1192		struct realtek_smi *smi = ds->priv;
  1193		u32 phys_port = PORT_NUM_L2P(port);
  1194		int ret;
  1195	
  1196		dev_info(smi->dev, "%s filtering on port %d\n",
  1197			 vlan_filtering ? "enable" : "disable", port);
  1198	
  1199		/* vlan_filtering on: Discard VLAN tagged frames if the port is not a
  1200		 * member of the VLAN with which the packet is associated. Untagged
  1201		 * packets should also be discarded unless the port has a PVID
  1202		 * programmed.
  1203		 *
  1204		 * vlan_filtering off: Accept all VLAN tagged frames, including
  1205		 * untagged.
  1206		 */
  1207		ret = regmap_update_bits(
  1208			smi->map, RTL8365MB_VLAN_INGRESS_REG,
  1209			RTL8365MB_VLAN_INGRESS_FILTER_PORT_EN_MASK(phys_port),
  1210			(vlan_filtering ? 1 : 0)
  1211				<< RTL8365MB_VLAN_INGRESS_FILTER_PORT_EN_OFFSET(
  1212					   phys_port));
  1213		if (ret)
  1214			return ret;
  1215	
  1216		return 0;
  1217	}
  1218	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: config.gz --]
[-- Type: application/gzip, Size: 39841 bytes --]