From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A6A1C4338F for ; Mon, 23 Aug 2021 09:08:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0DC3F61357 for ; Mon, 23 Aug 2021 09:08:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230496AbhHWJIk (ORCPT ); Mon, 23 Aug 2021 05:08:40 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:26429 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229944AbhHWJIj (ORCPT ); Mon, 23 Aug 2021 05:08:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629709676; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aISp5M1izx4NH4v0Hn06V3ODxv34YeYXayvZgVqi7XI=; b=VVC0xQ88CHPih/Hasxu6hGx0QckDyJoNwYwMGrvYnFDEy5DtbU3KQ7PeM1oJuW+GnzhcI1 5IIBpbZ9sBPsSlyEE0iAteqBgUr3Cd9tblZCM9U/gBwGw6qdR2R1R8w3/IJBfonqCpMeGY zW5FCYvq3kvwQwR/VP9mBF0NzDoYzUg= Received: from mail-ed1-f71.google.com (mail-ed1-f71.google.com [209.85.208.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-586-eRzZ5eI9NV-DAxubZd9VSQ-1; Mon, 23 Aug 2021 05:07:55 -0400 X-MC-Unique: eRzZ5eI9NV-DAxubZd9VSQ-1 Received: by mail-ed1-f71.google.com with SMTP id l18-20020a0564021252b02903be7bdd65ccso8489447edw.12 for ; Mon, 23 Aug 2021 02:07:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=aISp5M1izx4NH4v0Hn06V3ODxv34YeYXayvZgVqi7XI=; b=jUzVXFDqymQc022Ug/Me13DIMKh5vAUndsmKtkCYxU94ICn+oTzCuELCZ1GG2jTsiH QXUnkB8VSeHKdKzJ1DFELFyItSIEJ8otjDRjhtJUR7hp7MZeCaeuf8Ymv16Qhqpbk2el B/kE0H6lzALHvli7szOjVpJU8O9wuhywJmPJJwBIJ1xTvYBxGAczGoehbePIBtVI24nI DyjvATUSCxnAfKfoD2xauy5zLMSMEJjhv/+ripQAwz9PQdcYOCO/byLYvS2RJX4mxjj+ sKanxMqFomw7oB+Q2yl1KJw+NO97+Y5VchCaFvhL9k8gEtXVJDyeB19R5tfk4UlE5vio B3LA== X-Gm-Message-State: AOAM532HGyWyaDQpQVF8wzf7cvFKyQ1W3UjYOdb5MScmMjcVE/7ur1oM /2Uj9R/NWLhIeLXPGu4h3Tr22f+s3v4fIaGibdhmdNAkf2025rV7egu4UNdfwYf7JjY5Lh/uEIl uB1P9PMQPVax2 X-Received: by 2002:a05:6402:1907:: with SMTP id e7mr8322339edz.201.1629709674295; Mon, 23 Aug 2021 02:07:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxB8djTuJSNghEDmXQfwZUrFrUJ+XhpXaA6T6sK1VZ2LMR5UNf4tuXRgxUvxp5oivYQUoq5rg== X-Received: by 2002:a05:6402:1907:: with SMTP id e7mr8322319edz.201.1629709674115; Mon, 23 Aug 2021 02:07:54 -0700 (PDT) Received: from gator.home (cst2-174-132.cust.vodafone.cz. [31.30.174.132]) by smtp.gmail.com with ESMTPSA id ks20sm6977968ejb.101.2021.08.23.02.07.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Aug 2021 02:07:53 -0700 (PDT) Date: Mon, 23 Aug 2021 11:07:52 +0200 From: Andrew Jones To: Marc Zyngier Cc: qemu-devel@nongnu.org, Eric Auger , Peter Maydell , kvmarm@lists.cs.columbia.edu, kvm@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH 1/3] hw/arm/virt: KVM: Probe for KVM_CAP_ARM_VM_IPA_SIZE when creating scratch VM Message-ID: <20210823090752.nanm4wttyefg3txh@gator.home> References: <20210822144441.1290891-1-maz@kernel.org> <20210822144441.1290891-2-maz@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210822144441.1290891-2-maz@kernel.org> Precedence: bulk List-ID: X-Mailing-List: kvm@vger.kernel.org On Sun, Aug 22, 2021 at 03:44:39PM +0100, Marc Zyngier wrote: > Although we probe for the IPA limits imposed by KVM (and the hardware) > when computing the memory map, we still use the old style '0' when > creating a scratch VM in kvm_arm_create_scratch_host_vcpu(). > > On systems that are severely IPA challenged (such as the Apple M1), > this results in a failure as KVM cannot use the default 40bit that > '0' represents. > > Instead, probe for the extension and use the reported IPA limit > if available. > > Cc: Andrew Jones > Cc: Eric Auger > Cc: Peter Maydell > Signed-off-by: Marc Zyngier > --- > target/arm/kvm.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/target/arm/kvm.c b/target/arm/kvm.c > index d8381ba224..cc3371a99b 100644 > --- a/target/arm/kvm.c > +++ b/target/arm/kvm.c > @@ -70,12 +70,17 @@ bool kvm_arm_create_scratch_host_vcpu(const uint32_t *cpus_to_try, > struct kvm_vcpu_init *init) > { > int ret = 0, kvmfd = -1, vmfd = -1, cpufd = -1; > + int max_vm_pa_size; > > kvmfd = qemu_open_old("/dev/kvm", O_RDWR); > if (kvmfd < 0) { > goto err; > } > - vmfd = ioctl(kvmfd, KVM_CREATE_VM, 0); > + max_vm_pa_size = ioctl(kvmfd, KVM_CHECK_EXTENSION, KVM_CAP_ARM_VM_IPA_SIZE); > + if (max_vm_pa_size < 0) { > + max_vm_pa_size = 0; > + } > + vmfd = ioctl(kvmfd, KVM_CREATE_VM, max_vm_pa_size); > if (vmfd < 0) { > goto err; > } > -- > 2.30.2 > Reviewed-by: Andrew Jones From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7161DC4338F for ; Mon, 23 Aug 2021 09:08:09 +0000 (UTC) Received: from mm01.cs.columbia.edu (mm01.cs.columbia.edu [128.59.11.253]) by mail.kernel.org (Postfix) with ESMTP id E30336136A for ; Mon, 23 Aug 2021 09:08:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org E30336136A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.cs.columbia.edu Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 5DC004B1DC; Mon, 23 Aug 2021 05:08:08 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Authentication-Results: mm01.cs.columbia.edu (amavisd-new); dkim=softfail (fail, message has been altered) header.i=@redhat.com Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id iOO9zvqmxvkL; Mon, 23 Aug 2021 05:08:03 -0400 (EDT) Received: from mm01.cs.columbia.edu (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id C46E94B264; Mon, 23 Aug 2021 05:08:03 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mm01.cs.columbia.edu (Postfix) with ESMTP id A54C64B25D for ; Mon, 23 Aug 2021 05:08:01 -0400 (EDT) X-Virus-Scanned: at lists.cs.columbia.edu Received: from mm01.cs.columbia.edu ([127.0.0.1]) by localhost (mm01.cs.columbia.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id A7sk6juHLxOM for ; Mon, 23 Aug 2021 05:07:57 -0400 (EDT) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mm01.cs.columbia.edu (Postfix) with ESMTP id 0AEC34B1DC for ; Mon, 23 Aug 2021 05:07:57 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629709676; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aISp5M1izx4NH4v0Hn06V3ODxv34YeYXayvZgVqi7XI=; b=VVC0xQ88CHPih/Hasxu6hGx0QckDyJoNwYwMGrvYnFDEy5DtbU3KQ7PeM1oJuW+GnzhcI1 5IIBpbZ9sBPsSlyEE0iAteqBgUr3Cd9tblZCM9U/gBwGw6qdR2R1R8w3/IJBfonqCpMeGY zW5FCYvq3kvwQwR/VP9mBF0NzDoYzUg= Received: from mail-ej1-f71.google.com (mail-ej1-f71.google.com [209.85.218.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-592-ZkaRe2kBNiaMk4I3uAf99Q-1; Mon, 23 Aug 2021 05:07:55 -0400 X-MC-Unique: ZkaRe2kBNiaMk4I3uAf99Q-1 Received: by mail-ej1-f71.google.com with SMTP id h17-20020a1709070b11b02905b5ced62193so5421966ejl.1 for ; Mon, 23 Aug 2021 02:07:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=aISp5M1izx4NH4v0Hn06V3ODxv34YeYXayvZgVqi7XI=; b=hYD7TD5Gi8ZM2OCdwiaKTHPxGFGZ589ahmhHDCQsWNHdCzt/khE6tSmopLSGhvYQps ZvQ/JLLRqptLWKxPwOnzCxZajyd4sT2WyP1jAE3J/+sZ6/uw9M5uxde5CJr5u3KdtCsN 9pvYe8j+hJFdX0bbEWBuDYRkQ6DgGjgSLmHNqMVLDGQ6DX4aPIfQtZj9K8ggJdTITIKD ls68pQUy/1/3LqU6nlkARS3j1mhRamnlpJtkpaQ+C1d9DchQIrymNUSd1l+ETek11c6h uZBmYOq6oe9bgR8qxwGL4NjFTP4hUDO5Uggzl3ig6m0sYlsFNoP+hQkqepN8Yr5uwwsg aI4w== X-Gm-Message-State: AOAM530aEQvk+6AyCRAjtpvW5jJCfTKV1SEGSbGEuGkYx5UxsPGuZN2P 9Lqk8gL9xW2ZLbjjY3RQFqZR5ABTgipghgiVI8rrWrXHRunJqRQa15jjVnGL7Z25JanspfDQBN8 rtGMzFrGyxudTMYhTOWHNrmdu X-Received: by 2002:a05:6402:1907:: with SMTP id e7mr8322341edz.201.1629709674295; Mon, 23 Aug 2021 02:07:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxB8djTuJSNghEDmXQfwZUrFrUJ+XhpXaA6T6sK1VZ2LMR5UNf4tuXRgxUvxp5oivYQUoq5rg== X-Received: by 2002:a05:6402:1907:: with SMTP id e7mr8322319edz.201.1629709674115; Mon, 23 Aug 2021 02:07:54 -0700 (PDT) Received: from gator.home (cst2-174-132.cust.vodafone.cz. [31.30.174.132]) by smtp.gmail.com with ESMTPSA id ks20sm6977968ejb.101.2021.08.23.02.07.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Aug 2021 02:07:53 -0700 (PDT) Date: Mon, 23 Aug 2021 11:07:52 +0200 From: Andrew Jones To: Marc Zyngier Subject: Re: [PATCH 1/3] hw/arm/virt: KVM: Probe for KVM_CAP_ARM_VM_IPA_SIZE when creating scratch VM Message-ID: <20210823090752.nanm4wttyefg3txh@gator.home> References: <20210822144441.1290891-1-maz@kernel.org> <20210822144441.1290891-2-maz@kernel.org> MIME-Version: 1.0 In-Reply-To: <20210822144441.1290891-2-maz@kernel.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=drjones@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Disposition: inline Cc: kvm@vger.kernel.org, qemu-devel@nongnu.org, kernel-team@android.com, kvmarm@lists.cs.columbia.edu X-BeenThere: kvmarm@lists.cs.columbia.edu X-Mailman-Version: 2.1.14 Precedence: list List-Id: Where KVM/ARM decisions are made List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: kvmarm-bounces@lists.cs.columbia.edu Sender: kvmarm-bounces@lists.cs.columbia.edu On Sun, Aug 22, 2021 at 03:44:39PM +0100, Marc Zyngier wrote: > Although we probe for the IPA limits imposed by KVM (and the hardware) > when computing the memory map, we still use the old style '0' when > creating a scratch VM in kvm_arm_create_scratch_host_vcpu(). > > On systems that are severely IPA challenged (such as the Apple M1), > this results in a failure as KVM cannot use the default 40bit that > '0' represents. > > Instead, probe for the extension and use the reported IPA limit > if available. > > Cc: Andrew Jones > Cc: Eric Auger > Cc: Peter Maydell > Signed-off-by: Marc Zyngier > --- > target/arm/kvm.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/target/arm/kvm.c b/target/arm/kvm.c > index d8381ba224..cc3371a99b 100644 > --- a/target/arm/kvm.c > +++ b/target/arm/kvm.c > @@ -70,12 +70,17 @@ bool kvm_arm_create_scratch_host_vcpu(const uint32_t *cpus_to_try, > struct kvm_vcpu_init *init) > { > int ret = 0, kvmfd = -1, vmfd = -1, cpufd = -1; > + int max_vm_pa_size; > > kvmfd = qemu_open_old("/dev/kvm", O_RDWR); > if (kvmfd < 0) { > goto err; > } > - vmfd = ioctl(kvmfd, KVM_CREATE_VM, 0); > + max_vm_pa_size = ioctl(kvmfd, KVM_CHECK_EXTENSION, KVM_CAP_ARM_VM_IPA_SIZE); > + if (max_vm_pa_size < 0) { > + max_vm_pa_size = 0; > + } > + vmfd = ioctl(kvmfd, KVM_CREATE_VM, max_vm_pa_size); > if (vmfd < 0) { > goto err; > } > -- > 2.30.2 > Reviewed-by: Andrew Jones _______________________________________________ kvmarm mailing list kvmarm@lists.cs.columbia.edu https://lists.cs.columbia.edu/mailman/listinfo/kvmarm From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DB058C4338F for ; Mon, 23 Aug 2021 09:09:01 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 7FC4E61250 for ; Mon, 23 Aug 2021 09:09:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 7FC4E61250 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:47548 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mI5wy-0003vA-Fk for qemu-devel@archiver.kernel.org; Mon, 23 Aug 2021 05:09:00 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:33154) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mI5w1-0003E9-3V for qemu-devel@nongnu.org; Mon, 23 Aug 2021 05:08:01 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:54037) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mI5vy-0006ZV-1w for qemu-devel@nongnu.org; Mon, 23 Aug 2021 05:08:00 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629709676; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=aISp5M1izx4NH4v0Hn06V3ODxv34YeYXayvZgVqi7XI=; b=VVC0xQ88CHPih/Hasxu6hGx0QckDyJoNwYwMGrvYnFDEy5DtbU3KQ7PeM1oJuW+GnzhcI1 5IIBpbZ9sBPsSlyEE0iAteqBgUr3Cd9tblZCM9U/gBwGw6qdR2R1R8w3/IJBfonqCpMeGY zW5FCYvq3kvwQwR/VP9mBF0NzDoYzUg= Received: from mail-ej1-f69.google.com (mail-ej1-f69.google.com [209.85.218.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-61-rGhnkSxPO42hDHRNOEa_Cg-1; Mon, 23 Aug 2021 05:07:55 -0400 X-MC-Unique: rGhnkSxPO42hDHRNOEa_Cg-1 Received: by mail-ej1-f69.google.com with SMTP id bx10-20020a170906a1ca00b005c341820edeso2474938ejb.10 for ; Mon, 23 Aug 2021 02:07:55 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=aISp5M1izx4NH4v0Hn06V3ODxv34YeYXayvZgVqi7XI=; b=WCbrko3VdaYpJ1mNxmWwYgrhnyw9aAL9QZMMT8QpEU6Z4qJlSr942B24hAbA6DADQ2 r4fyh847oLReJzgcSQyYqvSnR0IXsrLi2I9xRnwySUa/vsNl86+nI4yGqqIRkc7ITb4h EH9nSbdhiI19hDCEihJfNkskdebGnBW/5khthRZHBmfQ/j+UtFcLjzWVN3Mw5KkSKLGM DowGtx0U/ABCwCQksGS5LkXguzR0V+gXFQkXPcZ4UoQ1+v6iN9pSKJttuxngMQJzkCp2 k/6/pwNKm2uS2v+ggcf4b34JuWqg3CM8S2q40rROngEqsLof1Wd5Pvy8b4cWDNjn/lTb 3ApA== X-Gm-Message-State: AOAM532Y3Yh2kzhx8H4xHJ5EiSm/KAIVijMYSiIvKzYAcAZMeTkDhHcV /PXcYUOdl82D5BbPkJ/OhL5Lg9izV2m4VsfFrxaOHcPHJZD0ELn3kuS59t+YoheS57iJobRZjoo zB+X39jOCkT/Kavg= X-Received: by 2002:a05:6402:1907:: with SMTP id e7mr8322344edz.201.1629709674331; Mon, 23 Aug 2021 02:07:54 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxB8djTuJSNghEDmXQfwZUrFrUJ+XhpXaA6T6sK1VZ2LMR5UNf4tuXRgxUvxp5oivYQUoq5rg== X-Received: by 2002:a05:6402:1907:: with SMTP id e7mr8322319edz.201.1629709674115; Mon, 23 Aug 2021 02:07:54 -0700 (PDT) Received: from gator.home (cst2-174-132.cust.vodafone.cz. [31.30.174.132]) by smtp.gmail.com with ESMTPSA id ks20sm6977968ejb.101.2021.08.23.02.07.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Aug 2021 02:07:53 -0700 (PDT) Date: Mon, 23 Aug 2021 11:07:52 +0200 From: Andrew Jones To: Marc Zyngier Subject: Re: [PATCH 1/3] hw/arm/virt: KVM: Probe for KVM_CAP_ARM_VM_IPA_SIZE when creating scratch VM Message-ID: <20210823090752.nanm4wttyefg3txh@gator.home> References: <20210822144441.1290891-1-maz@kernel.org> <20210822144441.1290891-2-maz@kernel.org> MIME-Version: 1.0 In-Reply-To: <20210822144441.1290891-2-maz@kernel.org> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=drjones@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Received-SPF: pass client-ip=216.205.24.124; envelope-from=drjones@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -34 X-Spam_score: -3.5 X-Spam_bar: --- X-Spam_report: (-3.5 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.746, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , kvm@vger.kernel.org, qemu-devel@nongnu.org, Eric Auger , kernel-team@android.com, kvmarm@lists.cs.columbia.edu Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Sun, Aug 22, 2021 at 03:44:39PM +0100, Marc Zyngier wrote: > Although we probe for the IPA limits imposed by KVM (and the hardware) > when computing the memory map, we still use the old style '0' when > creating a scratch VM in kvm_arm_create_scratch_host_vcpu(). > > On systems that are severely IPA challenged (such as the Apple M1), > this results in a failure as KVM cannot use the default 40bit that > '0' represents. > > Instead, probe for the extension and use the reported IPA limit > if available. > > Cc: Andrew Jones > Cc: Eric Auger > Cc: Peter Maydell > Signed-off-by: Marc Zyngier > --- > target/arm/kvm.c | 7 ++++++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/target/arm/kvm.c b/target/arm/kvm.c > index d8381ba224..cc3371a99b 100644 > --- a/target/arm/kvm.c > +++ b/target/arm/kvm.c > @@ -70,12 +70,17 @@ bool kvm_arm_create_scratch_host_vcpu(const uint32_t *cpus_to_try, > struct kvm_vcpu_init *init) > { > int ret = 0, kvmfd = -1, vmfd = -1, cpufd = -1; > + int max_vm_pa_size; > > kvmfd = qemu_open_old("/dev/kvm", O_RDWR); > if (kvmfd < 0) { > goto err; > } > - vmfd = ioctl(kvmfd, KVM_CREATE_VM, 0); > + max_vm_pa_size = ioctl(kvmfd, KVM_CHECK_EXTENSION, KVM_CAP_ARM_VM_IPA_SIZE); > + if (max_vm_pa_size < 0) { > + max_vm_pa_size = 0; > + } > + vmfd = ioctl(kvmfd, KVM_CREATE_VM, max_vm_pa_size); > if (vmfd < 0) { > goto err; > } > -- > 2.30.2 > Reviewed-by: Andrew Jones