All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Michael Riesch <michael.riesch@wolfvision.net>
Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
	linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Jose Abreu <joabreu@synopsys.com>,
	"David S . Miller" <davem@davemloft.net>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>
Subject: Re: [PATCH] net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings
Date: Mon, 23 Aug 2021 09:44:25 -0700	[thread overview]
Message-ID: <20210823094425.78d7a73e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210823143754.14294-1-michael.riesch@wolfvision.net>

On Mon, 23 Aug 2021 16:37:54 +0200 Michael Riesch wrote:
> In the commit to be reverted, support for power management was
> introduced to the Rockchip glue code. Later, power management support
> was introduced to the stmmac core code, resulting in multiple
> invocations of pm_runtime_{enable,disable,get_sync,put_sync}.

Can we get a Fixes tag? I.e. reference to the earliest commit where 
the warning can be triggered?

> The multiple invocations happen in rk_gmac_powerup and
> stmmac_{dvr_probe, resume} as well as in rk_gmac_powerdown and
> stmmac_{dvr_remove, suspend}, respectively, which are always called
> in conjunction.

WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Michael Riesch <michael.riesch@wolfvision.net>
Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
	linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Jose Abreu <joabreu@synopsys.com>,
	"David S . Miller" <davem@davemloft.net>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>
Subject: Re: [PATCH] net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings
Date: Mon, 23 Aug 2021 09:44:25 -0700	[thread overview]
Message-ID: <20210823094425.78d7a73e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210823143754.14294-1-michael.riesch@wolfvision.net>

On Mon, 23 Aug 2021 16:37:54 +0200 Michael Riesch wrote:
> In the commit to be reverted, support for power management was
> introduced to the Rockchip glue code. Later, power management support
> was introduced to the stmmac core code, resulting in multiple
> invocations of pm_runtime_{enable,disable,get_sync,put_sync}.

Can we get a Fixes tag? I.e. reference to the earliest commit where 
the warning can be triggered?

> The multiple invocations happen in rk_gmac_powerup and
> stmmac_{dvr_probe, resume} as well as in rk_gmac_powerdown and
> stmmac_{dvr_remove, suspend}, respectively, which are always called
> in conjunction.

_______________________________________________
Linux-rockchip mailing list
Linux-rockchip@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-rockchip

WARNING: multiple messages have this Message-ID (diff)
From: Jakub Kicinski <kuba@kernel.org>
To: Michael Riesch <michael.riesch@wolfvision.net>
Cc: netdev@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com,
	linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org,
	Giuseppe Cavallaro <peppe.cavallaro@st.com>,
	Alexandre Torgue <alexandre.torgue@foss.st.com>,
	Jose Abreu <joabreu@synopsys.com>,
	"David S . Miller" <davem@davemloft.net>,
	Maxime Coquelin <mcoquelin.stm32@gmail.com>
Subject: Re: [PATCH] net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings
Date: Mon, 23 Aug 2021 09:44:25 -0700	[thread overview]
Message-ID: <20210823094425.78d7a73e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <20210823143754.14294-1-michael.riesch@wolfvision.net>

On Mon, 23 Aug 2021 16:37:54 +0200 Michael Riesch wrote:
> In the commit to be reverted, support for power management was
> introduced to the Rockchip glue code. Later, power management support
> was introduced to the stmmac core code, resulting in multiple
> invocations of pm_runtime_{enable,disable,get_sync,put_sync}.

Can we get a Fixes tag? I.e. reference to the earliest commit where 
the warning can be triggered?

> The multiple invocations happen in rk_gmac_powerup and
> stmmac_{dvr_probe, resume} as well as in rk_gmac_powerdown and
> stmmac_{dvr_remove, suspend}, respectively, which are always called
> in conjunction.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2021-08-23 16:44 UTC|newest]

Thread overview: 49+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-23 14:37 [PATCH] net: stmmac: dwmac-rk: fix unbalanced pm_runtime_enable warnings Michael Riesch
2021-08-23 14:37 ` Michael Riesch
2021-08-23 14:37 ` Michael Riesch
2021-08-23 16:44 ` Jakub Kicinski [this message]
2021-08-23 16:44   ` Jakub Kicinski
2021-08-23 16:44   ` Jakub Kicinski
2021-08-25  8:07   ` Michael Riesch
2021-08-25  8:07     ` Michael Riesch
2021-08-25  8:07     ` Michael Riesch
2021-08-25  9:50 ` patchwork-bot+netdevbpf
2021-08-25  9:50   ` patchwork-bot+netdevbpf
2021-08-25  9:50   ` patchwork-bot+netdevbpf
2021-08-29 17:48 ` Chen-Yu Tsai
2021-08-29 17:48   ` Chen-Yu Tsai
2021-08-29 17:48   ` Chen-Yu Tsai
2021-08-30  7:57   ` Michael Riesch
2021-08-30  7:57     ` Michael Riesch
2021-08-30  7:57     ` Michael Riesch
2021-08-30 13:49     ` Punit Agrawal
2021-08-30 13:49       ` Punit Agrawal
2021-08-30 13:49       ` Punit Agrawal
2021-08-30 14:10       ` Michael Riesch
2021-08-30 14:10         ` Michael Riesch
2021-08-30 14:10         ` Michael Riesch
2021-09-17  2:22         ` Qu Wenruo
2021-09-17  2:22           ` Qu Wenruo
2021-09-17  2:22           ` Qu Wenruo
2021-09-17  7:18           ` Punit Agrawal
2021-09-17  7:18             ` Punit Agrawal
2021-09-17  7:18             ` Punit Agrawal
2021-09-17  8:02             ` Qu Wenruo
2021-09-17  8:02               ` Qu Wenruo
2021-09-17  8:02               ` Qu Wenruo
2021-09-17 15:11               ` Punit Agrawal
2021-09-17 15:11                 ` Punit Agrawal
2021-09-17 15:11                 ` Punit Agrawal
2021-08-30 16:03     ` Chen-Yu Tsai
2021-08-30 16:03       ` Chen-Yu Tsai
2021-08-30 16:03       ` Chen-Yu Tsai
2021-08-30 19:22     ` Sasha Levin
2021-08-30 19:22       ` Sasha Levin
2021-08-30 19:22       ` Sasha Levin
2021-09-14  1:10 Ivan Babrou
2021-09-14 10:06 ` Michael Riesch
2021-09-14 10:06   ` Michael Riesch
2021-09-14 10:06   ` Michael Riesch
2021-09-14 13:39   ` Sebastian Döring
2021-09-14 13:39     ` Sebastian Döring
2021-09-14 13:39     ` Sebastian Döring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210823094425.78d7a73e@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
    --to=kuba@kernel.org \
    --cc=alexandre.torgue@foss.st.com \
    --cc=davem@davemloft.net \
    --cc=joabreu@synopsys.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=michael.riesch@wolfvision.net \
    --cc=netdev@vger.kernel.org \
    --cc=peppe.cavallaro@st.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.