From: John Efstathiades <john.efstathiades@pebblebay.com>
To: unlisted-recipients:; (no To-header on input)
Cc: UNGLinuxDriver@microchip.com, woojung.huh@microchip.com,
davem@davemloft.net, netdev@vger.kernel.org,
john.efstathiades@pebblebay.com
Subject: [PATCH net-next 04/10] lan78xx: Remove unused pause frame queue
Date: Mon, 23 Aug 2021 14:52:23 +0100 [thread overview]
Message-ID: <20210823135229.36581-5-john.efstathiades@pebblebay.com> (raw)
In-Reply-To: <20210823135229.36581-1-john.efstathiades@pebblebay.com>
Remove the pause frame queue from the driver. It is initialised
but not actually used.
Signed-off-by: John Efstathiades <john.efstathiades@pebblebay.com>
---
drivers/net/usb/lan78xx.c | 9 ---------
1 file changed, 9 deletions(-)
diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
index ccfb2d47932d..746aeeaa9d6e 100644
--- a/drivers/net/usb/lan78xx.c
+++ b/drivers/net/usb/lan78xx.c
@@ -383,7 +383,6 @@ struct lan78xx_net {
struct sk_buff_head rxq;
struct sk_buff_head txq;
struct sk_buff_head done;
- struct sk_buff_head rxq_pause;
struct sk_buff_head txq_pend;
struct tasklet_struct bh;
@@ -2710,8 +2709,6 @@ static int lan78xx_stop(struct net_device *net)
usb_kill_urb(dev->urb_intr);
- skb_queue_purge(&dev->rxq_pause);
-
/* deferred work (task, timer, softirq) must also stop.
* can't flush_scheduled_work() until we drop rtnl (later),
* else workers could deadlock; so make workers a NOP.
@@ -3003,11 +3000,6 @@ static void lan78xx_skb_return(struct lan78xx_net *dev, struct sk_buff *skb)
{
int status;
- if (test_bit(EVENT_RX_PAUSED, &dev->flags)) {
- skb_queue_tail(&dev->rxq_pause, skb);
- return;
- }
-
dev->net->stats.rx_packets++;
dev->net->stats.rx_bytes += skb->len;
@@ -3674,7 +3666,6 @@ static int lan78xx_probe(struct usb_interface *intf,
skb_queue_head_init(&dev->rxq);
skb_queue_head_init(&dev->txq);
skb_queue_head_init(&dev->done);
- skb_queue_head_init(&dev->rxq_pause);
skb_queue_head_init(&dev->txq_pend);
mutex_init(&dev->phy_mutex);
--
2.25.1
next prev parent reply other threads:[~2021-08-23 13:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-23 13:52 [PATCH net-next 00/10] LAN7800 driver improvements John Efstathiades
2021-08-23 13:52 ` [PATCH net-next 01/10] lan78xx: Fix white space and style issues John Efstathiades
2021-08-23 13:52 ` [PATCH net-next 02/10] lan78xx: Remove unused timer John Efstathiades
2021-08-23 13:52 ` [PATCH net-next 03/10] lan78xx: Set flow control threshold to prevent packet loss John Efstathiades
2021-08-23 13:52 ` John Efstathiades [this message]
2021-08-23 13:52 ` [PATCH net-next 05/10] lan78xx: Disable USB3 link power state transitions John Efstathiades
2021-08-23 22:40 ` Jakub Kicinski
2021-08-24 8:59 ` John Efstathiades
2021-08-24 13:53 ` Jakub Kicinski
2021-08-24 14:33 ` John Efstathiades
2021-08-24 15:19 ` Jakub Kicinski
2021-08-24 15:52 ` John Efstathiades
2021-08-23 13:52 ` [PATCH net-next 06/10] lan78xx: Fix exception on link speed change John Efstathiades
2021-08-23 22:42 ` Jakub Kicinski
2021-08-23 13:52 ` [PATCH net-next 07/10] lan78xx: Fix partial packet errors on suspend/resume John Efstathiades
2021-08-23 13:52 ` [PATCH net-next 08/10] lan78xx: Fix race conditions in suspend/resume handling John Efstathiades
2021-08-23 13:52 ` [PATCH net-next 09/10] lan78xx: Fix race condition in disconnect handling John Efstathiades
2021-08-23 13:52 ` [PATCH net-next 10/10] lan78xx: Limit number of driver warning messages John Efstathiades
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210823135229.36581-5-john.efstathiades@pebblebay.com \
--to=john.efstathiades@pebblebay.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.