From: Naohiro Aota <naohiro.aota@wdc.com>
To: Karel Zak <kzak@redhat.com>
Cc: util-linux@vger.kernel.org, Naohiro Aota <naohiro.aota@wdc.com>
Subject: [PATCH 2/2] lsblk: add columns of zoned parameters
Date: Tue, 24 Aug 2021 10:17:18 +0900 [thread overview]
Message-ID: <20210824011718.300747-3-naohiro.aota@wdc.com> (raw)
In-Reply-To: <20210824011718.300747-1-naohiro.aota@wdc.com>
Several parameters for zoned devices are missing from lsblk's columns. This
commit introduces them as following.
ZONE-SIZE zone size
ZONE-WGRAN zone write granularity
ZONE-APPEND zone append max bytes
ZONES-NR number of zones
ZONES-OMAX max open zones
ZONES-AMAX max active zones
Signed-off-by: Naohiro Aota <naohiro.aota@wdc.com>
---
misc-utils/lsblk.c | 52 ++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 52 insertions(+)
diff --git a/misc-utils/lsblk.c b/misc-utils/lsblk.c
index 775a6d832076..6f1c5dc67060 100644
--- a/misc-utils/lsblk.c
+++ b/misc-utils/lsblk.c
@@ -123,6 +123,12 @@ enum {
COL_WSAME,
COL_WWN,
COL_ZONED,
+ COL_ZONESIZE,
+ COL_ZONEWRITEGRAN,
+ COL_ZONEAPPEND,
+ COL_ZONES_NR,
+ COL_ZONES_OMAX,
+ COL_ZONES_AMAX,
};
/* basic table settings */
@@ -213,6 +219,12 @@ static struct colinfo infos[] = {
[COL_WSAME] = { "WSAME", 6, SCOLS_FL_RIGHT, N_("write same max bytes"), COLTYPE_SIZE },
[COL_WWN] = { "WWN", 18, 0, N_("unique storage identifier") },
[COL_ZONED] = { "ZONED", 0.3, 0, N_("zone model") },
+ [COL_ZONESIZE] = { "ZONE-SIZE", 9, SCOLS_FL_RIGHT, N_("zone size"), COLTYPE_NUM },
+ [COL_ZONEWRITEGRAN] = { "ZONE-WGRAN", 10, SCOLS_FL_RIGHT, N_("zone write granularity"), COLTYPE_NUM },
+ [COL_ZONEAPPEND] = { "ZONE-APPEND", 11, SCOLS_FL_RIGHT, N_("zone append max bytes"), COLTYPE_NUM },
+ [COL_ZONES_NR] = { "ZONES-NR", 8, SCOLS_FL_RIGHT, N_("number of zones"), COLTYPE_NUM },
+ [COL_ZONES_OMAX] = { "ZONES-OMAX", 10, SCOLS_FL_RIGHT, N_("max open zones"), COLTYPE_NUM },
+ [COL_ZONES_AMAX] = { "ZONES-AMAX", 10, SCOLS_FL_RIGHT, N_("max active zones"), COLTYPE_NUM },
};
struct lsblk *lsblk; /* global handler */
@@ -1067,6 +1079,46 @@ static char *device_get_data(
case COL_ZONED:
ul_path_read_string(dev->sysfs, &str, "queue/zoned");
break;
+ case COL_ZONESIZE:
+ {
+ uint64_t x;
+
+ if (ul_path_read_u64(dev->sysfs, &x, "queue/chunk_sectors") == 0) {
+ x <<= 9;
+ if (lsblk->bytes)
+ xasprintf(&str, "%ju", x);
+ else
+ str = size_to_human_string(SIZE_SUFFIX_1LETTER, x);
+ if (sortdata)
+ *sortdata = x;
+ }
+ break;
+ }
+ case COL_ZONEWRITEGRAN:
+ device_read_bytes(dev, "queue/zone_write_granularity", &str, sortdata);
+ break;
+ case COL_ZONEAPPEND:
+ device_read_bytes(dev, "queue/zone_append_max_bytes", &str, sortdata);
+ break;
+ case COL_ZONES_NR:
+ ul_path_read_string(dev->sysfs, &str, "queue/nr_zones");
+ if (sortdata)
+ str2u64(str, sortdata);
+ break;
+ case COL_ZONES_OMAX:
+ ul_path_read_string(dev->sysfs, &str, "queue/max_open_zones");
+ if (!str)
+ str = xstrdup("0");
+ if (sortdata)
+ str2u64(str, sortdata);
+ break;
+ case COL_ZONES_AMAX:
+ ul_path_read_string(dev->sysfs, &str, "queue/max_active_zones");
+ if (!str)
+ str = xstrdup("0");
+ if (sortdata)
+ str2u64(str, sortdata);
+ break;
case COL_DAX:
ul_path_read_string(dev->sysfs, &str, "queue/dax");
break;
--
2.33.0
next prev parent reply other threads:[~2021-08-24 1:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 1:17 [PATCH 0/2] add columns for zoned parameters Naohiro Aota
2021-08-24 1:17 ` [PATCH 1/2] lsblk: factor out function to read sysfs param as bytes Naohiro Aota
2021-08-24 1:17 ` Naohiro Aota [this message]
2021-08-24 12:47 ` [PATCH 0/2] add columns for zoned parameters Karel Zak
2021-08-25 2:12 ` Naohiro Aota
2021-08-25 2:49 ` Damien Le Moal
2021-08-25 10:03 ` Karel Zak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210824011718.300747-3-naohiro.aota@wdc.com \
--to=naohiro.aota@wdc.com \
--cc=kzak@redhat.com \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.