From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C451AC4338F for ; Tue, 24 Aug 2021 01:49:00 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3A9B0600D1 for ; Tue, 24 Aug 2021 01:49:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3A9B0600D1 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:36172 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mILYh-0006AQ-3g for qemu-devel@archiver.kernel.org; Mon, 23 Aug 2021 21:48:59 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40058) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mILXj-0005M6-Np; Mon, 23 Aug 2021 21:47:59 -0400 Received: from mail.kernel.org ([198.145.29.99]:33616) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mILXg-00032U-M7; Mon, 23 Aug 2021 21:47:59 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 8DFD561042; Tue, 24 Aug 2021 01:47:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629769673; bh=SC94jOA6r5jKeRjTmTIVT7ssy7GNOuu1Jxz05Np3/zc=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=XoayFTxPs1lnsVcMe8TXchbqS1OcpXLJULya2rpqdmOc+ueXkhA5J8GggEBxI9JmH LEsU8Zi0Qcq7XjMEX0bLvRS2Un/4+MzGUtNjBZ/xH4CBlEmA+7smxMZISZiIqGpsUw EFPve8fDWEDmxORKELNW7Yi7YdQPFHbQVyRgD+4lwIHDuPfpylpHM+JwFqe3j+EJNI /g45KWulBQgGoljttyeFJpRYtfGC7zDPgS+XX2nurAdt7Hp+AXG6J/5s2XWP0Mau+/ PwI8HPinmhOeHXBtx+slHTlqtGnURrpyWizFNxXYaykUPPSxmqr9LzDDfZZMWsgm/W 0zJ+mHGltbb4g== Date: Mon, 23 Aug 2021 19:47:48 -0600 From: Keith Busch To: Klaus Jensen Subject: Re: [PATCH] hw/nvme: fix validation of ASQ and ACQ Message-ID: <20210824014748.GA64408@C02WT3WMHTD6> References: <20210823122018.401370-1-its@irrelevant.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210823122018.401370-1-its@irrelevant.dk> Received-SPF: pass client-ip=198.145.29.99; envelope-from=kbusch@kernel.org; helo=mail.kernel.org X-Spam_score_int: -77 X-Spam_score: -7.8 X-Spam_bar: ------- X-Spam_report: (-7.8 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.743, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Klaus Jensen , qemu-devel@nongnu.org, qemu-block@nongnu.org Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Mon, Aug 23, 2021 at 02:20:18PM +0200, Klaus Jensen wrote: > From: Klaus Jensen > > Address 0x0 is a valid address. Fix the admin submission and completion > queue address validation to not error out on this. Indeed, there are environments that can use that address. It's a host error if the controller was enabled with invalid queue addresses anyway. The controller only needs to verify the lower bits are clear, which we do later. Reviewed-by: Keith Busch