From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mIPlu-0001GW-Fr for mharc-grub-devel@gnu.org; Tue, 24 Aug 2021 02:18:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47396) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from <3SI8kYQcKCgkvj1t0j7pxxpun.lxvp03k-mn4nupw3.x0p@flex--maskray.bounces.google.com>) id 1mIPlr-00018K-8B for grub-devel@gnu.org; Tue, 24 Aug 2021 02:18:51 -0400 Received: from mail-qk1-x74a.google.com ([2607:f8b0:4864:20::74a]:47800) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from <3SI8kYQcKCgkvj1t0j7pxxpun.lxvp03k-mn4nupw3.x0p@flex--maskray.bounces.google.com>) id 1mIPlp-0003AT-OC for grub-devel@gnu.org; Tue, 24 Aug 2021 02:18:51 -0400 Received: by mail-qk1-x74a.google.com with SMTP id b4-20020a3799040000b02903b899a4309cso13544784qke.14 for ; Mon, 23 Aug 2021 23:18:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:in-reply-to:message-id:mime-version:references:subject:from:to :cc; bh=cCIc7Ipg8DSNSDOU0SnbbjeofQwK0F+lE4sGgz4X84o=; b=Y0veGrU0fpP0yWniqNjqqhDYsC0b+VHIDHqvOkNEeikptmtZtPUqCR1uQz+GgvBDo9 HyIsTSQ8VDmYdhgb2IWkmtCfd5B8WxTWVNoAuy85R8Bop6xYT4/ZYzvr7GJl+HdafCt/ NQ0q1x8qcNU2aVogUijzgnA5Jbi9239qKeTEWHH4J4J3WOPcM1BNEQDWo5EUL47eaVCo 1G3KNsmY2OTM6gdFXRnOkGE9rrMc32BjY0X5fWQBWba6Oiyn7gRXPiOey10e3RoTwL2o jjE5li0Lig4oTlmo/tc7Xoigpj7U7qWZuvWQhfKJ264e7tj4BZVBrIh3zKz94yoDkM3+ Wyfw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:in-reply-to:message-id:mime-version :references:subject:from:to:cc; bh=cCIc7Ipg8DSNSDOU0SnbbjeofQwK0F+lE4sGgz4X84o=; b=R+xVXf9pZ0xiYCJCmp6KUe/isvkW+atoDTEnaQuNBEsDYTCAcqwBtI/Er3/VTnvs4u uvj2GkxJY9QgSziD0W4puHeEJ1s5WIvvmwEzn5sp6XlBUEdPmhIWrnwLrCGWb1Ku1pWV PDZPLQa64jPPghoqAHVEC3k5Snwl5beazCyPA61eka+Kvdkwo9TUaAZUuQteWCQzwVus h8tG80b5PB5GoyoPglpFTOQXxd/NJHxp/fB36/PmDc6tRVtAeTKEIYS76nb81FDOBK+q JLctL6kqanRxS70lXugqT6TtqrA8PPVawZpdWiu7WsA8E58rltbGblErtKI+gwKuO4sQ AnWw== X-Gm-Message-State: AOAM533qoQ6BX2XFWrX9g+bbBoxiS0inlfX9UK9sIKfl4BTeTxb1BJoc PNi2VOp+d8AykUThY46S5FrkzS+NQOOmXvIhBpZlpx3KLj0Q0RKTqzNGivZpbwvMgi6qwB69o8i HQ7Sk8dyUtI/oMUNXHn9R4Gep0fckGtgfAHUuJYSRVN5pnUpYfZHprXaJbWM= X-Google-Smtp-Source: ABdhPJytK1B53ILV2e/QvMybiwB0LJ2eKG2alHlvBkXIErfVUqtA25TxN2kSqmNa7I7MTmC5bmL5MOYzYxx1 X-Received: from maskray1.svl.corp.google.com ([2620:15c:2ce:200:196f:5297:b0e8:1313]) (user=maskray job=sendgmr) by 2002:a05:6214:20e6:: with SMTP id 6mr37065947qvk.20.1629785928229; Mon, 23 Aug 2021 23:18:48 -0700 (PDT) Date: Mon, 23 Aug 2021 23:18:38 -0700 In-Reply-To: <20210824061838.3569412-1-maskray@google.com> Message-Id: <20210824061838.3569412-3-maskray@google.com> Mime-Version: 1.0 References: <20210824061838.3569412-1-maskray@google.com> Subject: [PATCH 2/2] configure: Check -falign-jumps=1 -falign-functions=1 beside -falign-loops=1 From: Fangrui Song To: grub-devel@gnu.org, Daniel Kiper , Alex Burmashev , "Vladimir 'phcoder' Serbinenko" Cc: Fangrui Song Content-Type: text/plain; charset="UTF-8" Received-SPF: pass client-ip=2607:f8b0:4864:20::74a; envelope-from=3SI8kYQcKCgkvj1t0j7pxxpun.lxvp03k-mn4nupw3.x0p@flex--maskray.bounces.google.com; helo=mail-qk1-x74a.google.com X-Spam_score_int: -95 X-Spam_score: -9.6 X-Spam_bar: --------- X-Spam_report: (-9.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 24 Aug 2021 06:18:51 -0000 Clang does not support -falign-jumps and only recently gained support for -falign-loops. Test all the alignment options to avoid passing unrecognized options to Clang: clang-14: error: optimization flag '-falign-jumps=1' is not supported [-Werror,-Wignored-optimization-argument] When compiled with older Clang, the alignment options are not added, so just avoid the complexity for each option. Signed-off-by: Fangrui Song --- configure.ac | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 9a12151bd..8625e6776 100644 --- a/configure.ac +++ b/configure.ac @@ -798,8 +798,9 @@ fi # Force no alignment to save space on i386. if test "x$target_cpu" = xi386; then - AC_CACHE_CHECK([whether -falign-loops works], [grub_cv_cc_falign_loop], [ - CFLAGS="$TARGET_CFLAGS -falign-loops=1 -Werror" + AC_CACHE_CHECK([whether -falign-jumps=1 -falign-loops=1 -falign-functions=1 works], + [grub_cv_cc_falign_loop], [ + CFLAGS="$TARGET_CFLAGS -falign-jumps=1 -falign-loops=1 -falign-functions=1 -Werror" AC_COMPILE_IFELSE([AC_LANG_PROGRAM([[]], [[]])], [grub_cv_cc_falign_loop=yes], [grub_cv_cc_falign_loop=no]) -- 2.33.0.rc2.250.ged5fa647cd-goog