From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.9 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78E74C4338F for ; Tue, 24 Aug 2021 06:59:06 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5C08561360 for ; Tue, 24 Aug 2021 06:59:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234505AbhHXG7s (ORCPT ); Tue, 24 Aug 2021 02:59:48 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56498 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231868AbhHXG7k (ORCPT ); Tue, 24 Aug 2021 02:59:40 -0400 Received: from mail-pl1-x636.google.com (mail-pl1-x636.google.com [IPv6:2607:f8b0:4864:20::636]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CFBDC061575 for ; Mon, 23 Aug 2021 23:58:57 -0700 (PDT) Received: by mail-pl1-x636.google.com with SMTP id b9so7284578plx.2 for ; Mon, 23 Aug 2021 23:58:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hxmjjXl6haOlUyFAodOeN6Rid/V7VeRFHdShmZUvvps=; b=gQUOEkb9jVQiUcTryVHj8YyC5b+IVDtVMTww8NE+oRIGz8i4pRkgVU7Sxge0sWL7U+ 4SBj2XaIq5LEDPAe12U+CF712yba2yYpcj5ThnkNIfNz/VVo3plIJMLda6ILSwsNesPR 56DrL1xYLwK/PPMh/OQzeyRTBelTu2huqtE1mZbCYXT0N8zh9MY1HnN4brzmyCSt+TwA HZAUBXrkvDLkJ1TZQE9oSJ4tehixfFz5YRd1FOXC6CV3T287hZaLKU43qX5BNfISMp4L 6Q14e37amSgJ6ndGSWUdHv4NtFONfJWdWv9KG6yTyO0iPLka9AC5uf3fVWMXjRAv7b+q SOJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hxmjjXl6haOlUyFAodOeN6Rid/V7VeRFHdShmZUvvps=; b=qdQT1hZEblRX2s+1uQtbgddlzvf3xg0sD4POD/doR0PSJVpin6GZctYgaExv79I7BA 1gwjJZGxJP/sD2TYQpxITI7gf3GQs2PGuzjTDjU2la1rQhOsBaoG3VRymTjExsvOKYhX rKowymsJyxsO3Axp6B7sRSGbTYtaiVhAM2Wbn8OHJSDiBatJSlOcwmnNpos57gZ236+c C+lKmO5/a1ni6Ymz7N3G9nRw8BEuXDHPWW2BU9g0QgTOm00jRA9NPUHkM8r3j14Z5Ojt rIluriKGc44g2GZw8ItlxEYELPDas3NVApqSCc2Klbnt/c8kDkDpGtkDi/eVLFoDsPlL wrTg== X-Gm-Message-State: AOAM5327yJjlDsJxEf/Jbuzw8LpD0LgyHSFDqN/stMsH5RLG3vJx1f82 dyfiJSrdVoxQlhJbCp5xnbmuwQ== X-Google-Smtp-Source: ABdhPJxv5fGaGFUoAHH4NEpea5BSJ1aA34eW3Z8d6rlBEEw6xgHxu7zqJkZzQ9QlExxymvkto8O/IA== X-Received: by 2002:a17:902:9a04:b029:12b:8d54:7c2 with SMTP id v4-20020a1709029a04b029012b8d5407c2mr32555237plp.62.1629788336725; Mon, 23 Aug 2021 23:58:56 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([202.155.204.36]) by smtp.gmail.com with ESMTPSA id 10sm1460505pjc.41.2021.08.23.23.58.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Aug 2021 23:58:56 -0700 (PDT) Date: Tue, 24 Aug 2021 14:58:48 +0800 From: Leo Yan To: James Clark Cc: mathieu.poirier@linaro.org, coresight@lists.linaro.org, linux-perf-users@vger.kernel.org, mike.leach@linaro.org, acme@kernel.org, suzuki.poulose@arm.com, John Garry , Will Deacon , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/9] perf cs-etm: Refactor out ETMv4 header saving Message-ID: <20210824065848.GB204566@leoy-ThinkPad-X240s> References: <20210806134109.1182235-1-james.clark@arm.com> <20210806134109.1182235-4-james.clark@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210806134109.1182235-4-james.clark@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 06, 2021 at 02:41:03PM +0100, James Clark wrote: > Extract a function for saving the ETMv4 header because this will be used > for ETE in a later commit. > > Signed-off-by: James Clark Reviewed-by: Leo Yan > --- > tools/perf/arch/arm/util/cs-etm.c | 46 +++++++++++++++---------------- > 1 file changed, 23 insertions(+), 23 deletions(-) > > diff --git a/tools/perf/arch/arm/util/cs-etm.c b/tools/perf/arch/arm/util/cs-etm.c > index 85168d87b2d7..ecb6fa55a210 100644 > --- a/tools/perf/arch/arm/util/cs-etm.c > +++ b/tools/perf/arch/arm/util/cs-etm.c > @@ -607,6 +607,28 @@ static int cs_etm_get_ro(struct perf_pmu *pmu, int cpu, const char *path) > return val; > } > > +static void cs_etm_save_etmv4_header(__u64 data[], struct auxtrace_record *itr, int cpu) > +{ > + struct cs_etm_recording *ptr = container_of(itr, struct cs_etm_recording, itr); > + struct perf_pmu *cs_etm_pmu = ptr->cs_etm_pmu; > + > + /* Get trace configuration register */ > + data[CS_ETMV4_TRCCONFIGR] = cs_etmv4_get_config(itr); > + /* Get traceID from the framework */ > + data[CS_ETMV4_TRCTRACEIDR] = coresight_get_trace_id(cpu); > + /* Get read-only information from sysFS */ > + data[CS_ETMV4_TRCIDR0] = cs_etm_get_ro(cs_etm_pmu, cpu, > + metadata_etmv4_ro[CS_ETMV4_TRCIDR0]); > + data[CS_ETMV4_TRCIDR1] = cs_etm_get_ro(cs_etm_pmu, cpu, > + metadata_etmv4_ro[CS_ETMV4_TRCIDR1]); > + data[CS_ETMV4_TRCIDR2] = cs_etm_get_ro(cs_etm_pmu, cpu, > + metadata_etmv4_ro[CS_ETMV4_TRCIDR2]); > + data[CS_ETMV4_TRCIDR8] = cs_etm_get_ro(cs_etm_pmu, cpu, > + metadata_etmv4_ro[CS_ETMV4_TRCIDR8]); > + data[CS_ETMV4_TRCAUTHSTATUS] = cs_etm_get_ro(cs_etm_pmu, cpu, > + metadata_etmv4_ro[CS_ETMV4_TRCAUTHSTATUS]); > +} > + > static void cs_etm_get_metadata(int cpu, u32 *offset, > struct auxtrace_record *itr, > struct perf_record_auxtrace_info *info) > @@ -620,29 +642,7 @@ static void cs_etm_get_metadata(int cpu, u32 *offset, > /* first see what kind of tracer this cpu is affined to */ > if (cs_etm_is_etmv4(itr, cpu)) { > magic = __perf_cs_etmv4_magic; > - /* Get trace configuration register */ > - info->priv[*offset + CS_ETMV4_TRCCONFIGR] = > - cs_etmv4_get_config(itr); > - /* Get traceID from the framework */ > - info->priv[*offset + CS_ETMV4_TRCTRACEIDR] = > - coresight_get_trace_id(cpu); > - /* Get read-only information from sysFS */ > - info->priv[*offset + CS_ETMV4_TRCIDR0] = > - cs_etm_get_ro(cs_etm_pmu, cpu, > - metadata_etmv4_ro[CS_ETMV4_TRCIDR0]); > - info->priv[*offset + CS_ETMV4_TRCIDR1] = > - cs_etm_get_ro(cs_etm_pmu, cpu, > - metadata_etmv4_ro[CS_ETMV4_TRCIDR1]); > - info->priv[*offset + CS_ETMV4_TRCIDR2] = > - cs_etm_get_ro(cs_etm_pmu, cpu, > - metadata_etmv4_ro[CS_ETMV4_TRCIDR2]); > - info->priv[*offset + CS_ETMV4_TRCIDR8] = > - cs_etm_get_ro(cs_etm_pmu, cpu, > - metadata_etmv4_ro[CS_ETMV4_TRCIDR8]); > - info->priv[*offset + CS_ETMV4_TRCAUTHSTATUS] = > - cs_etm_get_ro(cs_etm_pmu, cpu, > - metadata_etmv4_ro > - [CS_ETMV4_TRCAUTHSTATUS]); > + cs_etm_save_etmv4_header(&info->priv[*offset], itr, cpu); > > /* How much space was used */ > increment = CS_ETMV4_PRIV_MAX; > -- > 2.28.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNWANTED_LANGUAGE_BODY,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 202A6C4338F for ; Tue, 24 Aug 2021 07:01:25 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DFA6F6103E for ; Tue, 24 Aug 2021 07:01:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org DFA6F6103E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=jyaBt3Ks4F/FhTXlmH8HqRg4FjF3y/pRnbT8HN+8Yis=; b=jZL/A5bCKMBTHh HH7lMeumO7vWRq+gQxk+cwLCfY4E5DSR11rw5393M8PXc/JENKeZQxz8BGRRb+2Q787WRcfrBX6UJ Wx5vZoVoOa6nL6ook/Z1oMIZcPd5iO2cGj0kDtz6GqZltTAsgDtHalF8G4h5M9U1xwSIfbInHV5Dg x7oExgO0mIh0AsH83Tb2WchFzu6bwD9mpgOxotWgLMC6NdGgvnLfpeSXKpYur0bZGz69er9ZThIu0 FUUstQnCJEZtOYF8w6NuceF9N34Dta5J7MA6urw6BEYYk95vbn7BGbDKykkL9v70Lcdy8UpEy7KJY YgHYJwrYhwhBUwnMicYQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIQOo-001xib-PP; Tue, 24 Aug 2021 06:59:06 +0000 Received: from mail-pj1-x1030.google.com ([2607:f8b0:4864:20::1030]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIQOi-001xg3-LE for linux-arm-kernel@lists.infradead.org; Tue, 24 Aug 2021 06:59:04 +0000 Received: by mail-pj1-x1030.google.com with SMTP id w19-20020a17090aaf9300b00191e6d10a19so1168171pjq.1 for ; Mon, 23 Aug 2021 23:58:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=hxmjjXl6haOlUyFAodOeN6Rid/V7VeRFHdShmZUvvps=; b=gQUOEkb9jVQiUcTryVHj8YyC5b+IVDtVMTww8NE+oRIGz8i4pRkgVU7Sxge0sWL7U+ 4SBj2XaIq5LEDPAe12U+CF712yba2yYpcj5ThnkNIfNz/VVo3plIJMLda6ILSwsNesPR 56DrL1xYLwK/PPMh/OQzeyRTBelTu2huqtE1mZbCYXT0N8zh9MY1HnN4brzmyCSt+TwA HZAUBXrkvDLkJ1TZQE9oSJ4tehixfFz5YRd1FOXC6CV3T287hZaLKU43qX5BNfISMp4L 6Q14e37amSgJ6ndGSWUdHv4NtFONfJWdWv9KG6yTyO0iPLka9AC5uf3fVWMXjRAv7b+q SOJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=hxmjjXl6haOlUyFAodOeN6Rid/V7VeRFHdShmZUvvps=; b=IqLgAIsSug34QYEBSty4NkvJws3isyR0zHyYx3boUoXa5WNarOQGuega6p0LOSvaTp vu67MQ/rJedIKmLmjyWzzbMwSEdodvM8m54/GTwrbgbOJBRupZyqtk0sv118vUHwiucc mh1IGUgGXXlt6w0Ron828OeZOsTYCzqvGNXUgy8DfLEH76y5YrRDFy1K5Rr3ynAI2JZ9 5cj0pMOB2oLvh6Pmacs6jaPJ+4NaCT5RkkVAf7FKH80KZEWaYbOY+ZyL4VOE+mKyxm+y 5M0YFfJGsIybr1lrH/g4+McevbbabNLufSj2CKTK/kgWPgY7e/fsOIXiVX4OnlYwhZOG dnDQ== X-Gm-Message-State: AOAM533xJF3LBdfucC5RHMI4L+kYjzMLOD+CD+2GkoF9QakRWRRd4KQm ZPDAbhzH9ECKGbjYH4B0jCXAcw== X-Google-Smtp-Source: ABdhPJxv5fGaGFUoAHH4NEpea5BSJ1aA34eW3Z8d6rlBEEw6xgHxu7zqJkZzQ9QlExxymvkto8O/IA== X-Received: by 2002:a17:902:9a04:b029:12b:8d54:7c2 with SMTP id v4-20020a1709029a04b029012b8d5407c2mr32555237plp.62.1629788336725; Mon, 23 Aug 2021 23:58:56 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([202.155.204.36]) by smtp.gmail.com with ESMTPSA id 10sm1460505pjc.41.2021.08.23.23.58.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Aug 2021 23:58:56 -0700 (PDT) Date: Tue, 24 Aug 2021 14:58:48 +0800 From: Leo Yan To: James Clark Cc: mathieu.poirier@linaro.org, coresight@lists.linaro.org, linux-perf-users@vger.kernel.org, mike.leach@linaro.org, acme@kernel.org, suzuki.poulose@arm.com, John Garry , Will Deacon , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 3/9] perf cs-etm: Refactor out ETMv4 header saving Message-ID: <20210824065848.GB204566@leoy-ThinkPad-X240s> References: <20210806134109.1182235-1-james.clark@arm.com> <20210806134109.1182235-4-james.clark@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210806134109.1182235-4-james.clark@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210823_235900_743022_0FA0226D X-CRM114-Status: GOOD ( 22.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 06, 2021 at 02:41:03PM +0100, James Clark wrote: > Extract a function for saving the ETMv4 header because this will be used > for ETE in a later commit. > > Signed-off-by: James Clark Reviewed-by: Leo Yan > --- > tools/perf/arch/arm/util/cs-etm.c | 46 +++++++++++++++---------------- > 1 file changed, 23 insertions(+), 23 deletions(-) > > diff --git a/tools/perf/arch/arm/util/cs-etm.c b/tools/perf/arch/arm/util/cs-etm.c > index 85168d87b2d7..ecb6fa55a210 100644 > --- a/tools/perf/arch/arm/util/cs-etm.c > +++ b/tools/perf/arch/arm/util/cs-etm.c > @@ -607,6 +607,28 @@ static int cs_etm_get_ro(struct perf_pmu *pmu, int cpu, const char *path) > return val; > } > > +static void cs_etm_save_etmv4_header(__u64 data[], struct auxtrace_record *itr, int cpu) > +{ > + struct cs_etm_recording *ptr = container_of(itr, struct cs_etm_recording, itr); > + struct perf_pmu *cs_etm_pmu = ptr->cs_etm_pmu; > + > + /* Get trace configuration register */ > + data[CS_ETMV4_TRCCONFIGR] = cs_etmv4_get_config(itr); > + /* Get traceID from the framework */ > + data[CS_ETMV4_TRCTRACEIDR] = coresight_get_trace_id(cpu); > + /* Get read-only information from sysFS */ > + data[CS_ETMV4_TRCIDR0] = cs_etm_get_ro(cs_etm_pmu, cpu, > + metadata_etmv4_ro[CS_ETMV4_TRCIDR0]); > + data[CS_ETMV4_TRCIDR1] = cs_etm_get_ro(cs_etm_pmu, cpu, > + metadata_etmv4_ro[CS_ETMV4_TRCIDR1]); > + data[CS_ETMV4_TRCIDR2] = cs_etm_get_ro(cs_etm_pmu, cpu, > + metadata_etmv4_ro[CS_ETMV4_TRCIDR2]); > + data[CS_ETMV4_TRCIDR8] = cs_etm_get_ro(cs_etm_pmu, cpu, > + metadata_etmv4_ro[CS_ETMV4_TRCIDR8]); > + data[CS_ETMV4_TRCAUTHSTATUS] = cs_etm_get_ro(cs_etm_pmu, cpu, > + metadata_etmv4_ro[CS_ETMV4_TRCAUTHSTATUS]); > +} > + > static void cs_etm_get_metadata(int cpu, u32 *offset, > struct auxtrace_record *itr, > struct perf_record_auxtrace_info *info) > @@ -620,29 +642,7 @@ static void cs_etm_get_metadata(int cpu, u32 *offset, > /* first see what kind of tracer this cpu is affined to */ > if (cs_etm_is_etmv4(itr, cpu)) { > magic = __perf_cs_etmv4_magic; > - /* Get trace configuration register */ > - info->priv[*offset + CS_ETMV4_TRCCONFIGR] = > - cs_etmv4_get_config(itr); > - /* Get traceID from the framework */ > - info->priv[*offset + CS_ETMV4_TRCTRACEIDR] = > - coresight_get_trace_id(cpu); > - /* Get read-only information from sysFS */ > - info->priv[*offset + CS_ETMV4_TRCIDR0] = > - cs_etm_get_ro(cs_etm_pmu, cpu, > - metadata_etmv4_ro[CS_ETMV4_TRCIDR0]); > - info->priv[*offset + CS_ETMV4_TRCIDR1] = > - cs_etm_get_ro(cs_etm_pmu, cpu, > - metadata_etmv4_ro[CS_ETMV4_TRCIDR1]); > - info->priv[*offset + CS_ETMV4_TRCIDR2] = > - cs_etm_get_ro(cs_etm_pmu, cpu, > - metadata_etmv4_ro[CS_ETMV4_TRCIDR2]); > - info->priv[*offset + CS_ETMV4_TRCIDR8] = > - cs_etm_get_ro(cs_etm_pmu, cpu, > - metadata_etmv4_ro[CS_ETMV4_TRCIDR8]); > - info->priv[*offset + CS_ETMV4_TRCAUTHSTATUS] = > - cs_etm_get_ro(cs_etm_pmu, cpu, > - metadata_etmv4_ro > - [CS_ETMV4_TRCAUTHSTATUS]); > + cs_etm_save_etmv4_header(&info->priv[*offset], itr, cpu); > > /* How much space was used */ > increment = CS_ETMV4_PRIV_MAX; > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel