From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ACC0A3FC1 for ; Tue, 24 Aug 2021 07:59:30 +0000 (UTC) Received: by verein.lst.de (Postfix, from userid 2407) id 757AD67373; Tue, 24 Aug 2021 09:59:28 +0200 (CEST) Date: Tue, 24 Aug 2021 09:59:28 +0200 From: Christoph Hellwig To: Kari Argillander Cc: Konstantin Komarov , Christoph Hellwig , ntfs3@lists.linux.dev, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, Pali =?iso-8859-1?Q?Roh=E1r?= , Matthew Wilcox , Christian Brauner Subject: Re: [PATCH v2 2/6] fs/ntfs3: Remove unnecesarry remount flag handling Message-ID: <20210824075928.GB26733@lst.de> References: <20210819002633.689831-1-kari.argillander@gmail.com> <20210819002633.689831-3-kari.argillander@gmail.com> Precedence: bulk X-Mailing-List: ntfs3@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210819002633.689831-3-kari.argillander@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Thu, Aug 19, 2021 at 03:26:29AM +0300, Kari Argillander wrote: > Remove unnecesarry remount flag handling. This does not do anything for > this driver. We have already set SB_NODIRATIME when we fill super. Also > noatime should be set from mount option. Now for some reson we try to > set it when remounting. > > Lazytime part looks like it is copied from f2fs and there is own mount > parameter for it. That is why they use it. We do not set lazytime > anywhere in our code. So basically this just blocks lazytime when > remounting. > > Signed-off-by: Kari Argillander Looks good, Reviewed-by: Christoph Hellwig