From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30721C4338F for ; Tue, 24 Aug 2021 08:36:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0960A61262 for ; Tue, 24 Aug 2021 08:36:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235335AbhHXIhK (ORCPT ); Tue, 24 Aug 2021 04:37:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:51156 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232714AbhHXIhH (ORCPT ); Tue, 24 Aug 2021 04:37:07 -0400 Received: from mail-pg1-x531.google.com (mail-pg1-x531.google.com [IPv6:2607:f8b0:4864:20::531]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 80028C061757 for ; Tue, 24 Aug 2021 01:36:23 -0700 (PDT) Received: by mail-pg1-x531.google.com with SMTP id g184so610584pgc.6 for ; Tue, 24 Aug 2021 01:36:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=F1XMyMZTrlMsAyxJHJ7+jgxpDBQIUvOlx6q4619hvdU=; b=NUoRDRdLXEWTEekCDmBtZ/exdtGXze3rrbYg+ex/+uIqp7rJsa6G1CjW9ZlBEbGJPa 0E9ZTiBZqMWIHwk7RZqP77HaITamZxBNT5RVqPYk0GC4AG8bcGOqwG6McNx/1WRjBYBZ aDAXLl9Mjfl68opbSN2x68GaPNFYOVo6orj7fRjUDwa/kZLN3+OZTwxFE03UekCI6qhR 3I2uNbJQVkKOsWInW3GrI+etyfetVKbN6j/7w0fuZB2RqYweNmNrkge8BnBLNF6xVwdy wqF6TjBxK2KjbLdlWUR2uSSpM53Yf9dG5mFMUrtxcOzUV2tjRiP2zld8yCb1tnES86TI KmHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=F1XMyMZTrlMsAyxJHJ7+jgxpDBQIUvOlx6q4619hvdU=; b=un40kFX6te21Ta0GV3kVMKf29UfqJNSdGMkH7klS3afg8ZPrkNsz5jG1GCSaCw90XI kYy++3XQDNAaTdGjBwwDhIcf98CF3KdudLkzvX0898GaBaj7kVuZQ1wJDadYjuXZzsAt 4+DLdYSUGu6mxL+i6oYRRxtyWvRgAp1Hi6oLoetHwE78OlHzTAgkr35o6dPqRWSg5mgA +QXNLknkkgzfdPQcWS2Pf1rJJwxNkTxosAfVRHpV86YM0HsEaE+pvXYk89epuLCexqu2 +keSWI2QPubNGpC0XxMDo3bNCH19ZTkVavmAfAIRdwKm5m2W1CAbD5fCr1uw0vlYC0YQ RYqA== X-Gm-Message-State: AOAM530a96Hqn6unxzG6zljC89TwsfF29tuisgXhoTSxEDKkmLU//dg7 XQH+vdrgRy2hUEbndwLRC3MWUA== X-Google-Smtp-Source: ABdhPJyUW69QXyRkb+6UuNtr5+pZZHByZSuSk3OEROQ/prtfEBYN0rOUFRkvTRN1VPFRsmRgERbpVw== X-Received: by 2002:aa7:86c3:0:b0:3eb:1857:8ae9 with SMTP id h3-20020aa786c3000000b003eb18578ae9mr14612757pfo.52.1629794182897; Tue, 24 Aug 2021 01:36:22 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([202.155.204.36]) by smtp.gmail.com with ESMTPSA id z3sm18612008pff.47.2021.08.24.01.36.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Aug 2021 01:36:22 -0700 (PDT) Date: Tue, 24 Aug 2021 16:36:15 +0800 From: Leo Yan To: James Clark Cc: mathieu.poirier@linaro.org, coresight@lists.linaro.org, linux-perf-users@vger.kernel.org, mike.leach@linaro.org, acme@kernel.org, suzuki.poulose@arm.com, John Garry , Will Deacon , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 9/9] perf cs-etm: Show a warning for an unknown magic number Message-ID: <20210824083615.GF204566@leoy-ThinkPad-X240s> References: <20210806134109.1182235-1-james.clark@arm.com> <20210806134109.1182235-10-james.clark@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210806134109.1182235-10-james.clark@arm.com> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Aug 06, 2021 at 02:41:09PM +0100, James Clark wrote: > Currently perf reports "Cannot allocate memory" which isn't very helpful > for a potentially user facing issue. If we add a new magic number in > the future, perf will be able to report unrecognised magic numbers. > > Signed-off-by: James Clark Reviewed-by: Leo Yan > --- > tools/perf/util/cs-etm.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c > index 788ad5a099f6..5b276bdb96a6 100644 > --- a/tools/perf/util/cs-etm.c > +++ b/tools/perf/util/cs-etm.c > @@ -2973,6 +2973,11 @@ int cs_etm__process_auxtrace_info(union perf_event *event, > > /* ETE shares first part of metadata with ETMv4 */ > trcidr_idx = CS_ETMV4_TRCTRACEIDR; > + } else { > + ui__error("CS ETM Trace: Unrecognised magic number %#"PRIx64". File could be from a newer version of perf.\n", > + ptr[i]); > + err = -EINVAL; > + goto err_free_metadata; > } > > if (!metadata[j]) { > -- > 2.28.0 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id EBB48C4338F for ; Tue, 24 Aug 2021 08:39:00 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id B3D7161262 for ; Tue, 24 Aug 2021 08:39:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org B3D7161262 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=NYg1D6huTdBt137BWLVu4/753PwFrwyDmJqU5EYvaVo=; b=uGioJfaM7JtQ3N gb9OnEQwgv/arHJK/p3ZYCH72RFr18p1d01l6oK5fsE4BlcrIYuT3vaoGOCkmIyRvcogV0P5AAk6D TGIUsGP8U7tOeN9eZ4/HN1Yje45vHqTyq4QyHf6+gVxt3N6Xx9n/j0PCDK3Q5e9k0azHvItNW3FL8 Md8+wy62+8ZaiYcw7mLObhaCA9vyc2M4Q9tdYdIiaSvgSrrPBaleHeZUjk6q0eEob0hBGxlkYfVSY 4V4jpa2jv9vmAao+YJbJ6ISghmykdkEx/v8mkmfzvw46UUo4CP0E0bykI3tAZG+/IGLMsWe3/vz3Z scTLEmnw2IiX9BqvLnjw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIRvE-002Bie-ET; Tue, 24 Aug 2021 08:36:40 +0000 Received: from mail-pg1-x530.google.com ([2607:f8b0:4864:20::530]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIRv8-002Bft-6m for linux-arm-kernel@lists.infradead.org; Tue, 24 Aug 2021 08:36:38 +0000 Received: by mail-pg1-x530.google.com with SMTP id c17so19107651pgc.0 for ; Tue, 24 Aug 2021 01:36:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=F1XMyMZTrlMsAyxJHJ7+jgxpDBQIUvOlx6q4619hvdU=; b=NUoRDRdLXEWTEekCDmBtZ/exdtGXze3rrbYg+ex/+uIqp7rJsa6G1CjW9ZlBEbGJPa 0E9ZTiBZqMWIHwk7RZqP77HaITamZxBNT5RVqPYk0GC4AG8bcGOqwG6McNx/1WRjBYBZ aDAXLl9Mjfl68opbSN2x68GaPNFYOVo6orj7fRjUDwa/kZLN3+OZTwxFE03UekCI6qhR 3I2uNbJQVkKOsWInW3GrI+etyfetVKbN6j/7w0fuZB2RqYweNmNrkge8BnBLNF6xVwdy wqF6TjBxK2KjbLdlWUR2uSSpM53Yf9dG5mFMUrtxcOzUV2tjRiP2zld8yCb1tnES86TI KmHQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=F1XMyMZTrlMsAyxJHJ7+jgxpDBQIUvOlx6q4619hvdU=; b=uaobTYwo3marwl4vbkB8xxn4wRa7kIiyjOYttBUAH5TepaC0AN8MGa32LgZ75cNxV2 rNTDpjhQSL6velRbGdWZgj2jpacLcnmhSMtuowJytmWyGlncDHZWPx7P/Nfx6aVXOMp0 27twz4Ld01QD8P978CG5bxSr7fvv1iBYoI9/FP4F6QtZAMnH++asPdnBzzT1pB+6JAcu IHhxx5lY+cJI9jZu9vXPa/qAJG5yyJzYi9kPXJIrzjqpa1T4xSvB08blVH19DAwT5nBf ZQTiuA1T3mLEViXNZeLIsXyogIPQOfwRL3/q1dZezEqW/2jUzcAQli2EJjx1UUrEhmsG Jq6w== X-Gm-Message-State: AOAM532dbsOuf0SrZNL6mlPNwTnOzbM0IPjL+DyMHGLQWG1Cz5bAnXbR st0+j9Wq5zO6gPHrSHQtPTiJjA== X-Google-Smtp-Source: ABdhPJyUW69QXyRkb+6UuNtr5+pZZHByZSuSk3OEROQ/prtfEBYN0rOUFRkvTRN1VPFRsmRgERbpVw== X-Received: by 2002:aa7:86c3:0:b0:3eb:1857:8ae9 with SMTP id h3-20020aa786c3000000b003eb18578ae9mr14612757pfo.52.1629794182897; Tue, 24 Aug 2021 01:36:22 -0700 (PDT) Received: from leoy-ThinkPad-X240s ([202.155.204.36]) by smtp.gmail.com with ESMTPSA id z3sm18612008pff.47.2021.08.24.01.36.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Aug 2021 01:36:22 -0700 (PDT) Date: Tue, 24 Aug 2021 16:36:15 +0800 From: Leo Yan To: James Clark Cc: mathieu.poirier@linaro.org, coresight@lists.linaro.org, linux-perf-users@vger.kernel.org, mike.leach@linaro.org, acme@kernel.org, suzuki.poulose@arm.com, John Garry , Will Deacon , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 9/9] perf cs-etm: Show a warning for an unknown magic number Message-ID: <20210824083615.GF204566@leoy-ThinkPad-X240s> References: <20210806134109.1182235-1-james.clark@arm.com> <20210806134109.1182235-10-james.clark@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210806134109.1182235-10-james.clark@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210824_013634_323892_A062B052 X-CRM114-Status: GOOD ( 18.26 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Aug 06, 2021 at 02:41:09PM +0100, James Clark wrote: > Currently perf reports "Cannot allocate memory" which isn't very helpful > for a potentially user facing issue. If we add a new magic number in > the future, perf will be able to report unrecognised magic numbers. > > Signed-off-by: James Clark Reviewed-by: Leo Yan > --- > tools/perf/util/cs-etm.c | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/tools/perf/util/cs-etm.c b/tools/perf/util/cs-etm.c > index 788ad5a099f6..5b276bdb96a6 100644 > --- a/tools/perf/util/cs-etm.c > +++ b/tools/perf/util/cs-etm.c > @@ -2973,6 +2973,11 @@ int cs_etm__process_auxtrace_info(union perf_event *event, > > /* ETE shares first part of metadata with ETMv4 */ > trcidr_idx = CS_ETMV4_TRCTRACEIDR; > + } else { > + ui__error("CS ETM Trace: Unrecognised magic number %#"PRIx64". File could be from a newer version of perf.\n", > + ptr[i]); > + err = -EINVAL; > + goto err_free_metadata; > } > > if (!metadata[j]) { > -- > 2.28.0 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel