From: Vladimir Oltean <vladimir.oltean@nxp.com>
To: Joe Hershberger <joe.hershberger@ni.com>,
Ramon Fried <rfried.dev@gmail.com>,
u-boot@lists.denx.de
Cc: Claudiu Manoil <claudiu.manoil@nxp.com>,
Michael Walle <michael@walle.cc>,
Priyanka Jain <priyanka.jain@nxp.com>
Subject: [PATCH v2 2/6] net: dsa: use "err" instead of "ret" in dsa_port_probe
Date: Tue, 24 Aug 2021 15:00:39 +0300 [thread overview]
Message-ID: <20210824120043.3823931-3-vladimir.oltean@nxp.com> (raw)
In-Reply-To: <20210824120043.3823931-1-vladimir.oltean@nxp.com>
DM DSA uses "err" for error code values, so use this consistently.
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Ramon Fried <rfried.dev@gmail.com>
Tested-by: Michael Walle <michael@walle.cc>
---
net/dsa-uclass.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/net/dsa-uclass.c b/net/dsa-uclass.c
index 694664d81bbb..f279ca7d2d6c 100644
--- a/net/dsa-uclass.c
+++ b/net/dsa-uclass.c
@@ -248,7 +248,7 @@ static int dsa_port_probe(struct udevice *pdev)
struct dsa_port_pdata *port_pdata;
struct dsa_priv *dsa_priv;
struct udevice *master;
- int ret;
+ int err;
port_pdata = dev_get_parent_plat(pdev);
dsa_priv = dev_get_uclass_priv(dev);
@@ -268,9 +268,9 @@ static int dsa_port_probe(struct udevice *pdev)
* TODO: we assume the master device is always there and doesn't get
* removed during runtime.
*/
- ret = device_probe(master);
- if (ret)
- return ret;
+ err = device_probe(master);
+ if (err)
+ return err;
/*
* Inherit port's hwaddr from the DSA master, unless the port already
--
2.25.1
next prev parent reply other threads:[~2021-08-24 12:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-24 12:00 [PATCH v2 0/6] Call phy_config at port probe time for the Felix DSA driver Vladimir Oltean
2021-08-24 12:00 ` [PATCH v2 1/6] net: dsa: felix: felix_init() can be static Vladimir Oltean
2021-09-14 9:23 ` Ramon Fried
2021-08-24 12:00 ` Vladimir Oltean [this message]
2021-09-14 9:23 ` [PATCH v2 2/6] net: dsa: use "err" instead of "ret" in dsa_port_probe Ramon Fried
2021-08-24 12:00 ` [PATCH v2 3/6] net: dsa: refactor the code to set the port MAC address into a dedicated function Vladimir Oltean
2021-09-14 9:23 ` Ramon Fried
2021-08-24 12:00 ` [PATCH v2 4/6] net: dsa: introduce a .port_probe() method in struct dsa_ops Vladimir Oltean
2021-09-14 9:24 ` Ramon Fried
2021-08-24 12:00 ` [PATCH v2 5/6] net: dsa: felix: call phy_config at .port_probe() time Vladimir Oltean
2021-08-24 12:00 ` [PATCH v2 6/6] net: dsa: felix: propagate the error code from phy_startup() Vladimir Oltean
2021-09-14 9:24 ` Ramon Fried
2021-08-25 11:08 ` [PATCH v2 0/6] Call phy_config at port probe time for the Felix DSA driver Vladimir Oltean
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210824120043.3823931-3-vladimir.oltean@nxp.com \
--to=vladimir.oltean@nxp.com \
--cc=claudiu.manoil@nxp.com \
--cc=joe.hershberger@ni.com \
--cc=michael@walle.cc \
--cc=priyanka.jain@nxp.com \
--cc=rfried.dev@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.