From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64EFFC4338F for ; Tue, 24 Aug 2021 17:40:46 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2EFB061245 for ; Tue, 24 Aug 2021 17:40:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2EFB061245 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id: In-Reply-To:MIME-Version:References:Message-ID:Subject:Cc:To:From:Date: Reply-To:Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date :Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=tt5ndh8udzR2jJXSFScDDt3uAbEVyC9LAGscg52wLuI=; b=I1s0mTjuu2Eav1mr4HM7K8/uCl qr8qPH3+xW0ImtqwA9uTLzNlWDZ9U4qt1ztODGdmqIeDhpMe+h4oxK7SvPQw8ehsw9gmyM/3XSg9c WlCyP5SYphDlwEP7U8RYrKJmDSickM2AU6h/9XlFghqQDMLqCzIjsX8XqXf6mdvxyqIIjkrI2tT+K eGPO7uQrNQ6qbr2DzH24onCkvu3NzRlU/x3UfDp1x0ABekMSwF2gnMG90S+sTLgRY/G5laENsCF9w L1Q1xRAxQyyhBmaZak4Tv+Z0LiclC9516i9gwsp5lJOrZ5+uyOODX7gqR7xwcbQ2vz8DYB5VeB0XM SUCd+r4Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIaOR-004DEv-Ks; Tue, 24 Aug 2021 17:39:23 +0000 Received: from mail.kernel.org ([198.145.29.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIaOM-004DDe-9A for linux-arm-kernel@lists.infradead.org; Tue, 24 Aug 2021 17:39:19 +0000 Received: by mail.kernel.org (Postfix) with ESMTPSA id 62B63610D1; Tue, 24 Aug 2021 17:39:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629826757; bh=CsaaIJ0mqvMrW1cfcnujbBXiLpITKWy956POm5RpK0k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OdnT40ch9qUhQ04G6TGydGZux5oi5A6H95hLtQRnt4NfKYBrSrU4UkFmHI5yEWOYJ 1j0trFQ7m6Z/qtlu+HFFip4VWp5VWik0kBId32P5h2u9W0xna7qaVzFyxVQAng8PNC cORxENimPGDsp+ugmywYIEseXrgiUcGtJAy3B3mzdRfOa7vww33zh1XsCbtAGye3Kk QFZrdXr/bkZca0hAkHt3d3IVuUKXFcD00zIkpDE8MmTLryXLydNpLt4Hgw0FM7Lkki jKsQOEIGXBwKKNpJuF1nLjoXhM0/uqM+FvyKchwhH1/PDg0XIwyR76VKr0aJbhPgtb p699nOhPxskAA== Date: Tue, 24 Aug 2021 18:38:50 +0100 From: Mark Brown To: "Madhavan T. Venkataraman" Cc: Mark Rutland , jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, pasha.tatashin@soleen.com, jthierry@redhat.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v8 1/4] arm64: Make all stack walking functions use arch_stack_walk() Message-ID: <20210824173850.GN4393@sirena.org.uk> References: <20210812190603.25326-1-madvenka@linux.microsoft.com> <20210812190603.25326-2-madvenka@linux.microsoft.com> <20210824131344.GE96738@C02TD0UTHF1T.local> MIME-Version: 1.0 In-Reply-To: X-Cookie: Sentient plasmoids are a gas. User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210824_103918_389672_7238E163 X-CRM114-Status: GOOD ( 16.62 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: multipart/mixed; boundary="===============2350714050126498672==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2350714050126498672== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="iwjEIfU64POCkTAH" Content-Disposition: inline --iwjEIfU64POCkTAH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 24, 2021 at 12:21:28PM -0500, Madhavan T. Venkataraman wrote: > On 8/24/21 8:13 AM, Mark Rutland wrote: > > On Thu, Aug 12, 2021 at 02:06:00PM -0500, madvenka@linux.microsoft.com wrote: > > Note that arch_stack_walk() depends on CONFIG_STACKTRACE (which is not in > > defconfig), so we'll need to reorganise things such that it's always defined, > > or factor out the core of that function and add a wrapper such that we > > can always use it. > I will include CONFIG_STACKTRACE in defconfig, if that is OK with you and > Mark Brown. That might be separately useful but it doesn't address the issue, if something is optional we need to handle the case where that option is disabled. It'll need to be one of the two options Mark Rutland mentioned above. --iwjEIfU64POCkTAH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmElLqkACgkQJNaLcl1U h9D52wf9HF8gVGgKIbvDXcRnQ3/hQSq3I/kE8tfA0mjUk6GSVSXBN0W3+3b0hnVZ In5H7LYRDhD3vusvJhJlb9bE/6GdNxwnqX0UsRF/tBoeiRjJAW5aphWaw2d/d9E3 a0fDLhKwVKhjgEEVtpAtbm1Hhy3/yhysuuFiHCbl1LCMfgD/zTea3ksk6EbNOs+O J1UEeSO/5rhwrAUQoIvUurkYvlEuqOgcvryIb36ibmyzdaGzPHV/8MMq4Z9qWKmt JGQBuWfh+DV3HB7XJw0780vdjDfjlscqu51/b0SxXOjuU+nTJaMZ7YLXsLduYpcY +DXmi8wIed6NkKwo+J/BKulZu1z45Q== =FpFy -----END PGP SIGNATURE----- --iwjEIfU64POCkTAH-- --===============2350714050126498672== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2350714050126498672==-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DBBB5C4320A for ; Tue, 24 Aug 2021 17:42:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C1EA7610A7 for ; Tue, 24 Aug 2021 17:42:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S241485AbhHXRnA (ORCPT ); Tue, 24 Aug 2021 13:43:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:46430 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234752AbhHXRkC (ORCPT ); Tue, 24 Aug 2021 13:40:02 -0400 Received: by mail.kernel.org (Postfix) with ESMTPSA id 62B63610D1; Tue, 24 Aug 2021 17:39:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1629826757; bh=CsaaIJ0mqvMrW1cfcnujbBXiLpITKWy956POm5RpK0k=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OdnT40ch9qUhQ04G6TGydGZux5oi5A6H95hLtQRnt4NfKYBrSrU4UkFmHI5yEWOYJ 1j0trFQ7m6Z/qtlu+HFFip4VWp5VWik0kBId32P5h2u9W0xna7qaVzFyxVQAng8PNC cORxENimPGDsp+ugmywYIEseXrgiUcGtJAy3B3mzdRfOa7vww33zh1XsCbtAGye3Kk QFZrdXr/bkZca0hAkHt3d3IVuUKXFcD00zIkpDE8MmTLryXLydNpLt4Hgw0FM7Lkki jKsQOEIGXBwKKNpJuF1nLjoXhM0/uqM+FvyKchwhH1/PDg0XIwyR76VKr0aJbhPgtb p699nOhPxskAA== Date: Tue, 24 Aug 2021 18:38:50 +0100 From: Mark Brown To: "Madhavan T. Venkataraman" Cc: Mark Rutland , jpoimboe@redhat.com, ardb@kernel.org, nobuta.keiya@fujitsu.com, sjitindarsingh@gmail.com, catalin.marinas@arm.com, will@kernel.org, jmorris@namei.org, pasha.tatashin@soleen.com, jthierry@redhat.com, linux-arm-kernel@lists.infradead.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH v8 1/4] arm64: Make all stack walking functions use arch_stack_walk() Message-ID: <20210824173850.GN4393@sirena.org.uk> References: <20210812190603.25326-1-madvenka@linux.microsoft.com> <20210812190603.25326-2-madvenka@linux.microsoft.com> <20210824131344.GE96738@C02TD0UTHF1T.local> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="iwjEIfU64POCkTAH" Content-Disposition: inline In-Reply-To: X-Cookie: Sentient plasmoids are a gas. User-Agent: Mutt/1.10.1 (2018-07-13) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --iwjEIfU64POCkTAH Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Aug 24, 2021 at 12:21:28PM -0500, Madhavan T. Venkataraman wrote: > On 8/24/21 8:13 AM, Mark Rutland wrote: > > On Thu, Aug 12, 2021 at 02:06:00PM -0500, madvenka@linux.microsoft.com wrote: > > Note that arch_stack_walk() depends on CONFIG_STACKTRACE (which is not in > > defconfig), so we'll need to reorganise things such that it's always defined, > > or factor out the core of that function and add a wrapper such that we > > can always use it. > I will include CONFIG_STACKTRACE in defconfig, if that is OK with you and > Mark Brown. That might be separately useful but it doesn't address the issue, if something is optional we need to handle the case where that option is disabled. It'll need to be one of the two options Mark Rutland mentioned above. --iwjEIfU64POCkTAH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEreZoqmdXGLWf4p/qJNaLcl1Uh9AFAmElLqkACgkQJNaLcl1U h9D52wf9HF8gVGgKIbvDXcRnQ3/hQSq3I/kE8tfA0mjUk6GSVSXBN0W3+3b0hnVZ In5H7LYRDhD3vusvJhJlb9bE/6GdNxwnqX0UsRF/tBoeiRjJAW5aphWaw2d/d9E3 a0fDLhKwVKhjgEEVtpAtbm1Hhy3/yhysuuFiHCbl1LCMfgD/zTea3ksk6EbNOs+O J1UEeSO/5rhwrAUQoIvUurkYvlEuqOgcvryIb36ibmyzdaGzPHV/8MMq4Z9qWKmt JGQBuWfh+DV3HB7XJw0780vdjDfjlscqu51/b0SxXOjuU+nTJaMZ7YLXsLduYpcY +DXmi8wIed6NkKwo+J/BKulZu1z45Q== =FpFy -----END PGP SIGNATURE----- --iwjEIfU64POCkTAH--