Re: [PATCH 1/2] mm: move ioremap_page_range to vmalloc.c

From: kernel test robot <lkp@intel.com>
To: Christoph Hellwig <hch@lst.de>,
	Andrew Morton <akpm@linux-foundation.org>
Cc: kbuild-all@lists.01.org,
	Linux Memory Management List <linux-mm@kvack.org>,
	Nicholas Piggin <npiggin@gmail.com>,
	Peter Zijlstra <peterz@infradead.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] mm: move ioremap_page_range to vmalloc.c
Date: Wed, 25 Aug 2021 03:51:43 +0800	[thread overview]
Message-ID: <202108250358.mBFwBiD3-lkp@intel.com> (raw)
In-Reply-To: <20210824091259.1324527-2-hch@lst.de>

[-- Attachment #1: Type: text/plain, Size: 3382 bytes --]

Hi Christoph,

I love your patch! Yet something to improve:

[auto build test ERROR on v5.14-rc7]
[cannot apply to hnaz-linux-mm/master next-20210824]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Christoph-Hellwig/mm-move-ioremap_page_range-to-vmalloc-c/20210824-181347
base:    e22ce8eb631bdc47a4a4ea7ecf4e4ba499db4f93
config: riscv-randconfig-s032-20210824 (attached as .config)
compiler: riscv64-linux-gcc (GCC) 11.2.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # apt-get install sparse
        # sparse version: v0.6.3-348-gf0e6938b-dirty
        # https://github.com/0day-ci/linux/commit/bb163539c969c4a902dbbe9e3bfd81ae00ee8c6e
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Christoph-Hellwig/mm-move-ioremap_page_range-to-vmalloc-c/20210824-181347
        git checkout bb163539c969c4a902dbbe9e3bfd81ae00ee8c6e
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross C=1 CF='-fdiagnostic-prefix -D__CHECK_ENDIAN__' ARCH=riscv 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All error/warnings (new ones prefixed by >>):

>> mm/ioremap.c:14:15: warning: no previous prototype for 'ioremap_prot' [-Wmissing-prototypes]
      14 | void __iomem *ioremap_prot(phys_addr_t addr, size_t size, unsigned long prot)
         |               ^~~~~~~~~~~~
   In file included from arch/riscv/include/asm/io.h:136,
                    from include/linux/io.h:13,
                    from mm/ioremap.c:11:
>> include/asm-generic/io.h:959:17: error: conflicting types for 'iounmap'; have 'void(volatile void *)'
     959 | #define iounmap iounmap
         |                 ^~~~~~~
   mm/ioremap.c:45:6: note: in expansion of macro 'iounmap'
      45 | void iounmap(volatile void __iomem *addr)
         |      ^~~~~~~
   include/asm-generic/io.h:959:17: note: previous definition of 'iounmap' with type 'void(void *)'
     959 | #define iounmap iounmap
         |                 ^~~~~~~
   include/asm-generic/io.h:960:20: note: in expansion of macro 'iounmap'
     960 | static inline void iounmap(void __iomem *addr)
         |                    ^~~~~~~

vim +959 include/asm-generic/io.h

3f7e212df82ca04 Arnd Bergmann     2009-05-13  957  
b3ada9d0ce8d286 Greentime Hu      2017-11-22  958  #ifndef iounmap
b3ada9d0ce8d286 Greentime Hu      2017-11-22 @959  #define iounmap iounmap
b3ada9d0ce8d286 Greentime Hu      2017-11-22  960  static inline void iounmap(void __iomem *addr)
b3ada9d0ce8d286 Greentime Hu      2017-11-22  961  {
b3ada9d0ce8d286 Greentime Hu      2017-11-22  962  }
b3ada9d0ce8d286 Greentime Hu      2017-11-22  963  #endif
80b0ca98f91ddbc Christoph Hellwig 2019-08-13  964  #elif defined(CONFIG_GENERIC_IOREMAP)
ca5999fde0a1761 Mike Rapoport     2020-06-08  965  #include <linux/pgtable.h>
80b0ca98f91ddbc Christoph Hellwig 2019-08-13  966  

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 30270 bytes --]