From: Jakub Kicinski <kuba@kernel.org>
To: Eric Dumazet <edumazet@google.com>
Cc: Zhongya Yan <yan2228598786@gmail.com>,
netdev <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
Steven Rostedt <rostedt@goodmis.org>,
Ingo Molnar <mingo@redhat.com>,
David Miller <davem@davemloft.net>,
Hideaki YOSHIFUJI <yoshfuji@linux-ipv6.org>,
David Ahern <dsahern@kernel.org>,
hengqi.chen@gmail.com, Yonghong Song <yhs@fb.com>,
ntspring@fb.com
Subject: Re: [PATCH] net: tcp_drop adds `reason` parameter for tracing v2
Date: Wed, 25 Aug 2021 09:04:18 -0700 [thread overview]
Message-ID: <20210825090418.57fd7d2f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com> (raw)
In-Reply-To: <CANn89iJO8jzjFWvJ610TPmKDE8WKi8ojTr_HWXLz5g=4pdQHEA@mail.gmail.com>
On Wed, 25 Aug 2021 08:47:46 -0700 Eric Dumazet wrote:
> On Wed, Aug 25, 2021 at 8:41 AM Zhongya Yan <yan2228598786@gmail.com> wrote:
> > @@ -5703,15 +5700,15 @@ static bool tcp_validate_incoming(struct sock *sk, struct sk_buff *skb,
> > TCP_INC_STATS(sock_net(sk), TCP_MIB_INERRS);
> > NET_INC_STATS(sock_net(sk), LINUX_MIB_TCPSYNCHALLENGE);
> > tcp_send_challenge_ack(sk, skb);
> > - goto discard;
> > + tcp_drop(sk, skb, TCP_DROP_MASK(__LINE__, TCP_VALIDATE_INCOMING));
>
> I'd rather use a string. So that we can more easily identify _why_ the
> packet was drop, without looking at the source code
> of the exact kernel version to locate line number 1057
Yeah, the line number seems like a particularly bad idea. Hopefully
strings won't be problematic, given we can expect most serious users
to feed the tracepoints via BPF. enum would be more convenient there,
I'd think.
> You can be sure that we will get reports in the future from users of
> heavily modified kernels.
> Having to download a git tree, or apply semi-private patches is a no go.
I'm slightly surprised by this angle. Are there downstream kernels with
heavily modified TCP other than Google's?
> If you really want to include __FILE__ and __LINE__, these both can be
> stringified and included in the report, with the help of macros.
next prev parent reply other threads:[~2021-08-25 16:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 15:40 [PATCH] net: tcp_drop adds `reason` parameter for tracing v2 Zhongya Yan
2021-08-25 15:47 ` Eric Dumazet
2021-08-25 16:04 ` Jakub Kicinski [this message]
2021-08-25 16:20 ` Eric Dumazet
2021-08-25 17:06 ` Jakub Kicinski
2021-08-26 3:19 ` Steven Rostedt
2021-08-26 5:13 ` Brendan Gregg
2021-09-01 14:36 ` Steven Rostedt
2021-09-01 15:20 ` Eric Dumazet
2021-09-01 17:44 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210825090418.57fd7d2f@kicinski-fedora-pc1c0hjn.dhcp.thefacebook.com \
--to=kuba@kernel.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=hengqi.chen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=ntspring@fb.com \
--cc=rostedt@goodmis.org \
--cc=yan2228598786@gmail.com \
--cc=yhs@fb.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.