From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1mIstD-0006vh-RR for mharc-grub-devel@gnu.org; Wed, 25 Aug 2021 09:24:23 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54602) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIstC-0006qs-0l for grub-devel@gnu.org; Wed, 25 Aug 2021 09:24:22 -0400 Received: from mx0b-00069f02.pphosted.com ([205.220.177.32]:9052) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mIst9-0001vo-Nn for grub-devel@gnu.org; Wed, 25 Aug 2021 09:24:21 -0400 Received: from pps.filterd (m0246630.ppops.net [127.0.0.1]) by mx0b-00069f02.pphosted.com (8.16.1.2/8.16.0.43) with SMTP id 17PDOBWU029067; Wed, 25 Aug 2021 13:24:18 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2021-07-09; bh=t5VbfqDCVEUEekzyRyNcABHjm6zfqe4htmbiooPUAZc=; b=LYj+qmDiPf/9w+BhH7SwQGc2BfjYNaPmjFCiv3kKJucm3DqmyZISk9mPhK9BC8Cz6/Er GfwiwTS11vQnpnB3YK+8bjXL5V1Kf8CvSmoYCSkKheLnIyjm/ZLvzB6DGvDLUn5kVzOp +8XM5e8PugkFKyv1+wjs5h5D3egNlhY+8thCpBJdkWoXNp6eREXsPf5jHDjDbsnHSRnp /ErcOybM5Vquu+sjbuAQeWKW/Cb94Rjxs7OcHWT3EivBXXynocYFj6rckAAtBuc71ohy 2clrMdLgkpll/nzLhU4Q9h0wntW8DSPR9nuiiiuq2NocqnKl3o2y05CbB5Rn0vW1/uzj bw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=date : from : to : cc : subject : message-id : references : content-type : in-reply-to : mime-version; s=corp-2020-01-29; bh=t5VbfqDCVEUEekzyRyNcABHjm6zfqe4htmbiooPUAZc=; b=k/oP3On2asJW26ugU1sw+qi2Jyn+ZhX+edrz+jzh0cjLCIVerNd8X8qRSXGF4JuyyMmh zjl3qGGKHflmwaBLXVCQU4fdYDjWlqc6Vq+AQ0R3QZ+UiQNlR5kOTrC1iPz6IXTaSTaw n51M+txW7nhktCcxoRDp2LOMQ9BXCgtUSX0L+fCBGaIjIj4cGtZEQwx3Q8KVvXUYAqGn Xu76YS98LCEX0QFPfiKd9ktCUpoJUT54YunuQSbN7ywsLJoZlSd30DWOLUuR95iKUbzL j4OPrid9Dtum2sY2ZEB4ANJEMhYpWWoESMAlmEFHtjTQFTTGEkoeg69su4Z5D5HYGhJb Sw== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by mx0b-00069f02.pphosted.com with ESMTP id 3amwpdbcwm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Aug 2021 13:24:17 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 17PDBOLk130929; Wed, 25 Aug 2021 13:24:16 GMT Received: from nam02-dm3-obe.outbound.protection.outlook.com (mail-dm3nam07lp2044.outbound.protection.outlook.com [104.47.56.44]) by aserp3030.oracle.com with ESMTP id 3ajqhgm40r-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Wed, 25 Aug 2021 13:24:16 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=fGAmxo8aZEwPwTEU1OoeK4KBmtjhwAXtPl+shq+m7RlPWKb+gOL8q3k/Ms5h0ZhXb1TNWeM+cT/0/ryeWdtlhcWyLcf9f2uKZYcnCuCPZRfYgL2+xBFByQCPPxiy8mc2fjYHddlvnExCuguPaHaFZw9vOaW5mkxk/D2KbC0HwMxjWpcHVqRZkorL2zEV8dEUqHDdK8GBwA4a5NX9u4Seqfu2c5HfVECrwUeHrQcabtbSZ3ZAmZss3y7gOpXKEwM6TG6cabOFQnAyuGIQ/RJhK0UeUHAXo7KqYMkKJCSdU8M9ZxNydOw3X7KMPcFdZoovtLEq56HClS5XZJ7/szicig== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t5VbfqDCVEUEekzyRyNcABHjm6zfqe4htmbiooPUAZc=; b=kKoUt/hNoSjGqP9CF/h2gFocc+xndimhveiFZ09EGMCfN9rqzt8oMx+94nDSGrrFAMX66ROZEPbx1qjpq5btVZVDDyGoRjFjfpqrvHV7ftHF/FZXGM5f6AlZA3QkNoiLsHKvXo74LM152v9MC6A1Mr0a92LUXqSYo3cBcR5fxAq7SIegvjbZYWr1OM6vldziw6GdSG7v6wocynL4eF/Uf934v3icqRpqCmgX4g37vZz1rSjXvfaorVU98WXKCednTlg30OTMxIq2k77yVxMd4DtBTW3p1Wg4ToVMSVGX2+VgXKmPrREvDzZLeMI2W41Mp/eyQB25htewdYg1IFPjYw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oracle.com; dmarc=pass action=none header.from=oracle.com; dkim=pass header.d=oracle.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.onmicrosoft.com; s=selector2-oracle-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=t5VbfqDCVEUEekzyRyNcABHjm6zfqe4htmbiooPUAZc=; b=p3afxgLav+kC4LLmAACciEVSVpi2HPhH6cPQQQTzVYz/WE2yaSPEu8H3Kon9Szn8tUfTQVbJJRfAMRhNJ7wahq8kPKRZMmCDrCchUR3svNfBk92a6qArTECbz2JvV4h+HwjknF7TJwaZDtLdOvXAEHH+9zum6X3pOu9W2ubckDg= Authentication-Results: google.com; dkim=none (message not signed) header.d=none;google.com; dmarc=none action=none header.from=oracle.com; Received: from BN6PR1001MB2228.namprd10.prod.outlook.com (2603:10b6:405:2e::38) by BN6PR1001MB2386.namprd10.prod.outlook.com (2603:10b6:405:30::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4436.23; Wed, 25 Aug 2021 13:24:14 +0000 Received: from BN6PR1001MB2228.namprd10.prod.outlook.com ([fe80::d542:dea0:e49e:26c2]) by BN6PR1001MB2228.namprd10.prod.outlook.com ([fe80::d542:dea0:e49e:26c2%6]) with mapi id 15.20.4436.027; Wed, 25 Aug 2021 13:24:14 +0000 Date: Wed, 25 Aug 2021 15:24:08 +0200 From: Daniel Kiper To: Fangrui Song Cc: grub-devel@gnu.org, Alex Burmashev , Vladimir 'phcoder' Serbinenko Subject: Re: [PATCH 2/2] configure: Check -falign-jumps=1 -falign-functions=1 beside -falign-loops=1 Message-ID: <20210825132408.owyrc2gm72zgg5s6@tomti.i.net-space.pl> References: <20210824061838.3569412-1-maskray@google.com> <20210824061838.3569412-3-maskray@google.com> Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210824061838.3569412-3-maskray@google.com> User-Agent: NeoMutt/20170113 (1.7.2) X-ClientProxiedBy: AM0PR01CA0171.eurprd01.prod.exchangelabs.com (2603:10a6:208:aa::40) To BN6PR1001MB2228.namprd10.prod.outlook.com (2603:10b6:405:2e::38) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from tomti.i.net-space.pl (84.10.22.86) by AM0PR01CA0171.eurprd01.prod.exchangelabs.com (2603:10a6:208:aa::40) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4457.18 via Frontend Transport; Wed, 25 Aug 2021 13:24:13 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: c0e2ebd6-e1d4-4ac2-9ce5-08d967cba1f8 X-MS-TrafficTypeDiagnostic: BN6PR1001MB2386: X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: KW1xEdD5q+o2+z28KliJBZ9BV8RnuUJE0YMwrOHI1StXqikYtgolr0M5GMqQUD76Tk+QZ6MkOH27sszNob9L7JO+pc0rBZKTbdgJjVTVag9Cy0Fwcl4MPe3/A8zRSUVKkNUeKGysgZm866Mmb4aS0MUr7T10MfIU/v6UYg2Joh5Lbwjfed4NMZg3HQuS+rN9VS65vKkt6TBvgYbq+MvdCQZ1EKjUaop/zvokFVEAKg178x63Xaii1qanJoILLD/GrLUcaP2um4b+BUtVwvLWRERnybThkvAxAmOcbWnmoIhT+F3IKY6DmIjCPs7tldsajjMezicnVxP8pDEJQoPjSiPLxOFjYfJ5dDFZbrevS35TNftmN+2wzZqde16Y4kYVbR+HOzvEetjfunVt5eeji4rF8gfWlfXqusv5pDiuorkDKeWcEsMk/xxx4NvGOJNaUKMsQPLpvIaMzOAAezOwJST5SD8W75j8eacmrJ7DJfWxcHU9ifODSnWC3Jdb793ouJNNjIeI9Q/B0mYz0su+r/eLDeyic1twBNiq9KUIGFKldewLzlE3Bhpb+qygoCIXOy8CV0iUYhebi8cI25uPLQhXQ4lElM+/NXwUS7uXgH7f1el4ujquGhc1GtChHj1hHfefpipGwPtzhW40GJ6tC2KW2B6CCEh9UbkwWjKlLJIgaCW5aNXz1NICX2VQaM+IBc4jF82aGcpWI58BeNDwCA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:BN6PR1001MB2228.namprd10.prod.outlook.com; PTR:; CAT:NONE; SFS:(376002)(39860400002)(346002)(136003)(396003)(366004)(38100700002)(66946007)(956004)(8676002)(7696005)(83380400001)(8936002)(66476007)(38350700002)(66556008)(9686003)(54906003)(6916009)(186003)(6506007)(52116002)(5660300002)(478600001)(44832011)(1076003)(4326008)(6666004)(55016002)(86362001)(2906002)(26005)(316002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?KGW0ds920hbNcAimkgAvTtqTpzrq+BJ0x2TyRQ3Iq9UZs/bm5UVoh6UkImvV?= =?us-ascii?Q?eyBflD/u2JONNQBcsYad69lDjecPfTl1ME8tDIFeZTohDv5rWu1tN/9ItYGw?= =?us-ascii?Q?3+9ZSur8FMl5CaR0mtaSI9yHMWWERGIdbRE3WYiZ3ja8StFgyN7XDWMMOhFE?= =?us-ascii?Q?CO6GOZR0pBttqi1w8U1yMYoxQliXF4g0Dh5ZeaQ6s7Zfq+3UY0sPG6zxF+sI?= =?us-ascii?Q?U7T8pG9X29tkYxQ4Sf/sOMrRAFGguZcFz4V4Ga0Ar4mImTa/GBdrQWAHhQqn?= =?us-ascii?Q?v8C8VziUvHkBAkeGpuBMFElObp6lAZ5SDRIAhcM6ZzHlO6DbCmRW4VMxAq2W?= =?us-ascii?Q?YVmZDlXX0rxRKEz+wrPlrxs7y2l1oST6LIjjzV1MRjfzkFcbwBbT9ZxIYwaR?= =?us-ascii?Q?2dY0gxJVy342wge1U3sx5jWRCcNCS8gqIo8Jy1/RawKERDFW7tvJshRmu2SR?= =?us-ascii?Q?kfK66TuNorvn9AztYUV4eAmNkt+Z5pdiw0lugcPHMSrZ5u3+ARixT4SkE9os?= =?us-ascii?Q?S2BU9hE+H3LKTmg81Tl2yhOusg4+HzTSISTrZUNS4oncwHhl2XgEp42VkGJQ?= =?us-ascii?Q?cT39eYpSFiMnHzL2XwtnZq5AXbrycfFcp8kdq0ADVfOCkt8bgIBJXcYnNRAp?= =?us-ascii?Q?yzJy+Sr7g/ICNDw/jfYq/51D4eLyJyH5hFASANiYAuNFUFWgvMCNA2R0gn0q?= =?us-ascii?Q?7Ld6kl3FOA/xiomnCwLiFLUGiVJqFR7EvYVbUYIj4jAlfrRefhYS0ZgiEwac?= =?us-ascii?Q?ZekGdChrceHgRSn8lM0ErkzK/+TLJj1DPXIfXkfWcvCRmabreqe836ZCeg7o?= =?us-ascii?Q?2O3QJNJqRWxc7V3kL4poQg4XGqqOE/F/piZypVEqcMYxCRPJaynG1Ij2dET4?= =?us-ascii?Q?23iXWAhp2Tfsiw3SRmi2tZ2gFcOfSdyyI+AZ561/t945d7hFX9k7hhFo5F2B?= =?us-ascii?Q?yZxknA/JX4MATmwao4u2XVeduHQWinjZl8lcOfOgoUVx2FhNXzfh35BWTN0T?= =?us-ascii?Q?5XLxTTlVSk9E9VV2rRogJHvj3WwArXloy86tqUmgJCFRgOUsiHbMW3qb2ezE?= =?us-ascii?Q?FLss5SE18jSH0WeVNvjz5ZT3UZblFa/5I/LFB1FcH5Kjb3fRd9NAhsQK39wy?= =?us-ascii?Q?7IWEyUw+3j8w7cKVUX8JGB2RA/Xn2+OUDmizkbodmMrSJtw4Ghp8Th0jETuw?= =?us-ascii?Q?1g+CV+eaUOMPciRB70nTBVCVcXPPvySJZSGcbABpPROru/Xy/n7livqzabhI?= =?us-ascii?Q?9k9zNOPbE/cwLvEmWoIC6M57Q3Z26WymQvDkevkqCQTmoygqYkK1X3waUdC5?= =?us-ascii?Q?9WFG2EELL/v32ecsr7YcVkC1?= X-OriginatorOrg: oracle.com X-MS-Exchange-CrossTenant-Network-Message-Id: c0e2ebd6-e1d4-4ac2-9ce5-08d967cba1f8 X-MS-Exchange-CrossTenant-AuthSource: BN6PR1001MB2228.namprd10.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 25 Aug 2021 13:24:14.5941 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wFrqqg6mthCLvwyYUEf4uPLfKgpWQl9vKnNKCqWr44Q98FmkXfMcQW7Xr82Bn02rPT8gLf+SigRFltv8mvu0AA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR1001MB2386 X-Proofpoint-Virus-Version: vendor=nai engine=6300 definitions=10086 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 bulkscore=0 malwarescore=0 spamscore=0 adultscore=0 mlxlogscore=999 suspectscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2107140000 definitions=main-2108250080 X-Proofpoint-ORIG-GUID: hgPFugjrs0PaegeXYNj91eHrbyUfzGzV X-Proofpoint-GUID: hgPFugjrs0PaegeXYNj91eHrbyUfzGzV Received-SPF: pass client-ip=205.220.177.32; envelope-from=daniel.kiper@oracle.com; helo=mx0b-00069f02.pphosted.com X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, MSGID_FROM_MTA_HEADER=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 25 Aug 2021 13:24:22 -0000 On Mon, Aug 23, 2021 at 11:18:38PM -0700, Fangrui Song wrote: > Clang does not support -falign-jumps and only recently gained support > for -falign-loops. Test all the alignment options to avoid passing > unrecognized options to Clang: > > clang-14: error: optimization flag '-falign-jumps=1' is not supported [-Werror,-Wignored-optimization-argument] > > When compiled with older Clang, the alignment options are not added, so > just avoid the complexity for each option. > > Signed-off-by: Fangrui Song > --- > configure.ac | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/configure.ac b/configure.ac > index 9a12151bd..8625e6776 100644 > --- a/configure.ac > +++ b/configure.ac > @@ -798,8 +798,9 @@ fi > > # Force no alignment to save space on i386. > if test "x$target_cpu" = xi386; then > - AC_CACHE_CHECK([whether -falign-loops works], [grub_cv_cc_falign_loop], [ > - CFLAGS="$TARGET_CFLAGS -falign-loops=1 -Werror" > + AC_CACHE_CHECK([whether -falign-jumps=1 -falign-loops=1 -falign-functions=1 works], > + [grub_cv_cc_falign_loop], [ > + CFLAGS="$TARGET_CFLAGS -falign-jumps=1 -falign-loops=1 -falign-functions=1 -Werror" I would prefer if you add a separate check for every -falign-* option. Daniel