All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Marek Behún" <marek.behun@nic.cz>
To: Stefan Roese <sr@denx.de>
Cc: u-boot@lists.denx.de, pali@kernel.org,
	"Chris Packham" <judge.packham@gmail.com>,
	"Baruch Siach" <baruch@tkos.co.il>,
	"Dennis Gilmore" <dgilmore@redhat.com>,
	"Mario Six" <mario.six@gdsys.cc>,
	"Jon Nettleton" <jon@solid-run.com>,
	"Marek Behún" <marek.behun@nic.cz>
Subject: [PATCH u-boot-marvell 15/29] tools: kwboot: Allow greater timeout when executing header code
Date: Wed, 25 Aug 2021 15:46:20 +0200	[thread overview]
Message-ID: <20210825134634.3959-16-marek.behun@nic.cz> (raw)
In-Reply-To: <20210825134634.3959-1-marek.behun@nic.cz>

When executing header code (which contains U-Boot SPL in most cases),
wait 10s after every non-xmodem character received (i.e. printed by
U-Boot SPL) before timing out.

Sometimes DDR training, which runs in SPL, may be slow.

Signed-off-by: Marek Behún <marek.behun@nic.cz>
---
 tools/kwboot.c | 44 +++++++++++++++++++++++++++++++++++++++++---
 1 file changed, 41 insertions(+), 3 deletions(-)

diff --git a/tools/kwboot.c b/tools/kwboot.c
index 2e16db83fa..0e60cc8a70 100644
--- a/tools/kwboot.c
+++ b/tools/kwboot.c
@@ -24,6 +24,7 @@
 #include <unistd.h>
 #include <stdint.h>
 #include <termios.h>
+#include <time.h>
 #include <sys/mman.h>
 #include <sys/stat.h>
 
@@ -68,6 +69,7 @@ struct kwboot_block {
 } __packed;
 
 #define KWBOOT_BLK_RSP_TIMEO 1000 /* ms */
+#define KWBOOT_HDR_RSP_TIMEO 10000 /* ms */
 
 static int kwboot_verbose;
 
@@ -381,12 +383,35 @@ _is_xm_reply(char c)
 	return c == ACK || c == NAK || c == CAN;
 }
 
+static uint64_t
+_now(void)
+{
+	struct timespec ts;
+
+	if (clock_gettime(CLOCK_MONOTONIC, &ts)) {
+		static int err_print;
+
+		if (!err_print) {
+			perror("clock_gettime() does not work");
+			err_print = 1;
+		}
+
+		/* this will just make the timeout not work */
+		return -1ULL;
+	}
+
+	return ts.tv_sec * 1000 + (ts.tv_nsec + 500000) / 1000000;
+}
+
 static int
 kwboot_xm_sendblock(int fd, struct kwboot_block *block, int allow_non_xm,
 		    int *done_print)
 {
+	int recv_timeo = allow_non_xm ? KWBOOT_HDR_RSP_TIMEO : blk_rsp_timeo;
 	int non_xm_print = 0;
+	uint64_t timeout = 0;
 	int rc, retries;
+	int err;
 	char c;
 
 	*done_print = 0;
@@ -404,14 +429,22 @@ kwboot_xm_sendblock(int fd, struct kwboot_block *block, int allow_non_xm,
 		}
 
 		do {
-			rc = kwboot_tty_recv(fd, &c, 1, blk_rsp_timeo);
+			err = 0;
+			rc = kwboot_tty_recv(fd, &c, 1, recv_timeo);
 			if (rc) {
-				if (errno != ETIMEDOUT)
+				if (errno != ETIMEDOUT) {
 					return rc;
-				c = NAK;
+				} else if (timeout && timeout < _now()) {
+					errno = ETIMEDOUT;
+					return -1;
+				} else {
+					err = errno;
+					c = NAK;
+				}
 			}
 
 			if (!_is_xm_reply(c) && allow_non_xm) {
+				timeout = _now() + recv_timeo;
 				putchar(c);
 				fflush(stdout);
 				non_xm_print = 1;
@@ -425,6 +458,11 @@ kwboot_xm_sendblock(int fd, struct kwboot_block *block, int allow_non_xm,
 	if (non_xm_print)
 		kwboot_printv("\n");
 
+	if (err) {
+		errno = err;
+		return -1;
+	}
+
 	rc = -1;
 
 	switch (c) {
-- 
2.31.1


  parent reply	other threads:[~2021-08-25 13:50 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-25 13:46 [PATCH u-boot-marvell 00/29] kwboot higher baudrate Marek Behún
2021-08-25 13:46 ` [PATCH u-boot-marvell 01/29] tools: kwbimage: Fix printf format warning Marek Behún
2021-08-25 13:46 ` [PATCH u-boot-marvell 02/29] tools: kwboot: Fix buffer overflow in kwboot_terminal() Marek Behún
2021-08-25 13:46 ` [PATCH u-boot-marvell 03/29] tools: kwboot: Make the quit sequence buffer const Marek Behún
2021-08-25 13:46 ` [PATCH u-boot-marvell 04/29] tools: kwboot: Refactor and fix writing buffer Marek Behún
2021-08-25 13:46 ` [PATCH u-boot-marvell 05/29] tools: kwboot: Print version information header Marek Behún
2021-08-25 13:46 ` [PATCH u-boot-marvell 06/29] tools: kwboot: Fix kwboot_xm_sendblock() function when kwboot_tty_recv() fails Marek Behún
2021-08-25 13:46 ` [PATCH u-boot-marvell 07/29] tools: kwboot: Fix return type of kwboot_xm_makeblock() function Marek Behún
2021-08-25 13:46 ` [PATCH u-boot-marvell 08/29] tools: kwboot: Fix comparison of integers with different size Marek Behún
2021-08-25 13:46 ` [PATCH u-boot-marvell 09/29] tools: kwboot: Fix printing progress Marek Behún
2021-08-25 13:46 ` [PATCH u-boot-marvell 10/29] tools: kwboot: Print newline on error when progress was not completed Marek Behún
2021-08-25 13:46 ` [PATCH u-boot-marvell 11/29] tools: kwboot: Split sending image into header and data stages Marek Behún
2021-08-25 13:46 ` [PATCH u-boot-marvell 12/29] tools: kwboot: Use a function to check whether received byte is a Xmodem reply Marek Behún
2021-08-25 13:46 ` [PATCH u-boot-marvell 13/29] tools: kwboot: Allow non-xmodem text output from BootROM only in a specific case Marek Behún
2021-08-25 13:46 ` [PATCH u-boot-marvell 14/29] tools: kwboot: Print new line after SPL output Marek Behún
2021-08-25 13:46 ` Marek Behún [this message]
2021-08-25 13:46 ` [PATCH u-boot-marvell 16/29] tools: kwboot: Properly finish xmodem transfer Marek Behún
2021-08-25 13:46 ` [PATCH u-boot-marvell 17/29] tools: kwboot: Always call kwboot_img_patch_hdr() Marek Behún
2021-08-25 13:46 ` [PATCH u-boot-marvell 19/29] tools: kwboot: Don't patch image header if signed Marek Behún
2021-08-25 13:46 ` [PATCH u-boot-marvell 20/29] tools: kwboot: Patch source address in image header Marek Behún
2021-08-25 13:46 ` [PATCH u-boot-marvell 21/29] tools: kwboot: Patch destination address to DDR area for SPI image Marek Behún
2021-08-25 13:46 ` [PATCH u-boot-marvell 22/29] tools: kwbimage: Refactor image_version() Marek Behún
2021-08-25 13:46 ` [PATCH u-boot-marvell 23/29] tools: kwbimage: Refactor kwbimage header size determination Marek Behún
2021-08-25 13:46 ` [PATCH u-boot-marvell 24/29] tools: kwboot: Round up header size to 128 B when patching Marek Behún
2021-08-25 13:46 ` [PATCH u-boot-marvell 25/29] tools: kwboot: Support higher baudrates when booting via UART Marek Behún
2021-08-25 16:49   ` Marek Behún
2021-08-26 13:13   ` Marek Behún
2021-08-25 13:46 ` [PATCH u-boot-marvell 26/29] tools: kwboot: Allow any baudrate on Linux Marek Behún
2021-08-25 13:46 ` [PATCH u-boot-marvell 27/29] tools: kwboot: Add Pali and Marek as authors Marek Behún
2021-08-25 13:46 ` [PATCH u-boot-marvell 28/29] doc/kwboot.1: Update man page Marek Behún
2021-08-27  1:37   ` Chris Packham
2021-08-27  8:13     ` Pavol Rohár
2021-08-27  8:36       ` Pali Rohár
2021-08-27 13:35         ` Marek Behún
2021-08-27 13:39           ` Pali Rohár
2021-08-25 13:46 ` [PATCH u-boot-marvell 29/29] MAINTAINERS: Add entry for kwbimage / kwboot tools Marek Behún
2021-08-25 17:01 ` [PATCH u-boot-marvell 18/29] tools: kwbimage: Simplify iteration over version 1 optional headers Marek Behún
2021-08-27  1:16 ` [PATCH u-boot-marvell 00/29] kwboot higher baudrate Chris Packham
2021-08-27  1:32   ` Chris Packham
2021-08-27  1:39   ` Marek Behún
2021-08-27  2:45     ` Chris Packham
2021-08-27  8:32       ` Pali Rohár
2021-08-27 10:59         ` Chris Packham
2021-08-27 12:31       ` Marek Behún
2021-08-27 22:09         ` Chris Packham

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210825134634.3959-16-marek.behun@nic.cz \
    --to=marek.behun@nic.cz \
    --cc=baruch@tkos.co.il \
    --cc=dgilmore@redhat.com \
    --cc=jon@solid-run.com \
    --cc=judge.packham@gmail.com \
    --cc=mario.six@gdsys.cc \
    --cc=pali@kernel.org \
    --cc=sr@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.