From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 917B5C4338F for ; Wed, 25 Aug 2021 14:50:54 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3CB79610CD for ; Wed, 25 Aug 2021 14:50:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3CB79610CD Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=kernel.crashing.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=lists.ozlabs.org Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4GvpnR3sNkz3058 for ; Thu, 26 Aug 2021 00:50:51 +1000 (AEST) Authentication-Results: lists.ozlabs.org; spf=permerror (SPF Permanent Error: Unknown mechanism found: ip:192.40.192.88/32) smtp.mailfrom=kernel.crashing.org (client-ip=63.228.1.57; helo=gate.crashing.org; envelope-from=segher@kernel.crashing.org; receiver=) Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) by lists.ozlabs.org (Postfix) with ESMTP id 4Gvpmw0rZHz2yHP for ; Thu, 26 Aug 2021 00:50:22 +1000 (AEST) Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.14.1) with ESMTP id 17PElF3t003965; Wed, 25 Aug 2021 09:47:15 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id 17PElDpJ003962; Wed, 25 Aug 2021 09:47:13 -0500 X-Authentication-Warning: gate.crashing.org: segher set sender to segher@kernel.crashing.org using -f Date: Wed, 25 Aug 2021 09:47:13 -0500 From: Segher Boessenkool To: Ganesh Subject: Re: [PATCH v2 1/3] powerpc/pseries: Parse control memory access error Message-ID: <20210825144713.GQ1583@gate.crashing.org> References: <20210805092025.272871-1-ganeshgr@linux.ibm.com> <87eeajcpmq.fsf@mpe.ellerman.id.au> <20210824212420.GL1583@gate.crashing.org> <92790955-ce8d-1826-2317-c889038545fc@linux.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <92790955-ce8d-1826-2317-c889038545fc@linux.ibm.com> User-Agent: Mutt/1.4.2.3i X-BeenThere: linuxppc-dev@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mikey@neuling.org, linuxppc-dev@lists.ozlabs.org, mahesh@linux.ibm.com, npiggin@gmail.com Errors-To: linuxppc-dev-bounces+linuxppc-dev=archiver.kernel.org@lists.ozlabs.org Sender: "Linuxppc-dev" On Wed, Aug 25, 2021 at 05:06:29PM +0530, Ganesh wrote: > > On 8/25/21 2:54 AM, Segher Boessenkool wrote: > >On Tue, Aug 24, 2021 at 04:39:57PM +1000, Michael Ellerman wrote: > >>>+ case MC_ERROR_CTRL_MEM_ACCESS_PTABLE_WALK: > >>>+ mce_err.u.ra_error_type = > >>>+ MCE_RA_ERROR_PAGE_TABLE_WALK_LOAD_STORE_FOREIGN; > >>That name is ridiculously long, but I guess that's not your fault :) > >>We can fix it up in a later patch. > >It also has surprisingly little information content for the 47 chars > >length it has :-) What does this even mean?! > > It means control memory access error/real address error is detected during > page > table walk. This isn't obvious from the name. The name contains some words your explanation does not, as well: LOAD, STORE, FOREIGN. Most importantly, the name is just a jumble of words, with no apparent connection between them. I didn't ask for an explanation, sorry if you misunderstood. I was just exploring the many ways this name is baffling :-) Segher