All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcel Ziswiler <marcel@ziswiler.com>
To: u-boot@lists.denx.de
Cc: Fabio Estevam <festevam@gmail.com>,
	Heiko Thiery <heiko.thiery@gmail.com>,
	Stefano Babic <sbabic@denx.de>,
	Frieder Schrempf <frieder.schrempf@kontron.de>,
	Marcel Ziswiler <marcel.ziswiler@toradex.com>,
	"NXP i.MX U-Boot Team" <uboot-imx@nxp.com>
Subject: [PATCH v3 10/10] verdin-imx8mm: fix watchdog pinctrl issue
Date: Wed, 25 Aug 2021 17:14:41 +0200	[thread overview]
Message-ID: <20210825151441.485419-11-marcel@ziswiler.com> (raw)
In-Reply-To: <20210825151441.485419-1-marcel@ziswiler.com>

From: Marcel Ziswiler <marcel.ziswiler@toradex.com>

Finally, found the root cause of the issue already once mentioned back
here [2] which caused the following error message during boot:

imx_wdt watchdog@30280000:
 pinctrl_select_state_full: uclass_get_device_by_phandle_id: err=-19

Turns out while the watchdog node itself was already u-boot,dm-spl its
pinctrl node was not which caused it to be unavailable at that early
stage. Note that any and all other boards I checked also seem to be
missing this. However, I can't judge whether or not they might indeed
need a similar fix or not.

[2] https://marc.info/?l=u-boot&m=161786572422973

Fixes: commit d304e7ace3a6
 ("ARM: imx8m: Fix reset in SPL on Toradex iMX8MM Verdin")
Signed-off-by: Marcel Ziswiler <marcel.ziswiler@toradex.com>
Reviewed-by: Fabio Estevam <festevam@gmail.com>

---

(no changes since v2)

Changes in v2:
- New patch fixing watchdog pinctrl issue.

 arch/arm/dts/imx8mm-verdin-u-boot.dtsi | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/arch/arm/dts/imx8mm-verdin-u-boot.dtsi b/arch/arm/dts/imx8mm-verdin-u-boot.dtsi
index 0e041865021..6962bb40b6e 100644
--- a/arch/arm/dts/imx8mm-verdin-u-boot.dtsi
+++ b/arch/arm/dts/imx8mm-verdin-u-boot.dtsi
@@ -68,6 +68,10 @@
 	u-boot,dm-spl;
 };
 
+&pinctrl_wdog {
+	u-boot,dm-spl;
+};
+
 &{/soc@0/bus@30800000/i2c@30a20000/pmic} {
 	u-boot,dm-spl;
 };
-- 
2.26.2


      parent reply	other threads:[~2021-08-25 15:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-25 15:14 [PATCH v3 00/10] board: toradex: verdin-imx8mm: target refresh Marcel Ziswiler
2021-08-25 15:14 ` [PATCH v3 01/10] imx8m: clean-up kconfig indentation Marcel Ziswiler
2021-08-25 15:14 ` [PATCH v3 02/10] verdin-imx8mm: fix ethernet Marcel Ziswiler
2021-08-25 15:14 ` [PATCH v3 03/10] ARM: dts: imx8mm-verdin: prepare for dek blob encapsulation Marcel Ziswiler
2021-08-25 15:14 ` [PATCH v3 04/10] verdin-imx8mm: switch to use binman to pack images Marcel Ziswiler
2021-08-26  2:50   ` Heiko Schocher
2021-08-25 15:14 ` [PATCH v3 05/10] verdin-imx8mm: enable sleep_moci output Marcel Ziswiler
2021-08-25 15:14 ` [PATCH v3 06/10] verdin-imx8mm: clean-up include order Marcel Ziswiler
2021-08-25 15:14 ` [PATCH v3 07/10] verdin-imx8mm: drop support for v1.0 hardware Marcel Ziswiler
2021-08-25 15:14 ` [PATCH v3 08/10] include/configs: apalis-imx8/verdin-imx8mm: rename kernel image variable Marcel Ziswiler
2021-08-25 15:14 ` [PATCH v3 09/10] verdin-imx8mm: use preboot for fdtfile evaluation Marcel Ziswiler
2021-08-25 15:14 ` Marcel Ziswiler [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210825151441.485419-11-marcel@ziswiler.com \
    --to=marcel@ziswiler.com \
    --cc=festevam@gmail.com \
    --cc=frieder.schrempf@kontron.de \
    --cc=heiko.thiery@gmail.com \
    --cc=marcel.ziswiler@toradex.com \
    --cc=sbabic@denx.de \
    --cc=u-boot@lists.denx.de \
    --cc=uboot-imx@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.