From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D1E6DC4338F for ; Wed, 25 Aug 2021 17:05:03 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 9FE8661058 for ; Wed, 25 Aug 2021 17:05:03 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 9FE8661058 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tgvYNv4get1WzdpHcAMcl6309nxvSx7zy6v+YcoQxuA=; b=EnnZ57eNpJxexH 96Qzx+hRDyjDRYXXHOmWuWonsa6MSo27qZO1pnbdRGI2eUBGBf2i2KM1w+KEnbjl0VtBp/sbx8gqM ApnoNmU00TPh4j1sWuBTmklV0yJJPlV/I2cK2ciIqBjobKqFIYtdl0iTWhVQM04UOMdbK8AQotmbK n7Zq7qP+npIsu3QwPzjWPbAAi8ALMGbzYfxkvzMnbl2NIzYontJsrpl1SZ2azptejejWxb7ATPWl4 T6/BGvRFUzsdw8/BVWM0KIPWuIl7/F8fkI3FRJV183Pym0E8Sog0VCBO8v8NgG36dPtUzbNRYJljx Rw3nmL0jG5GS9RjwHkfw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIwIL-0081XZ-Pi; Wed, 25 Aug 2021 17:02:34 +0000 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mIwI9-0081U8-NS for linux-arm-kernel@lists.infradead.org; Wed, 25 Aug 2021 17:02:25 +0000 Received: by mail-pg1-x52c.google.com with SMTP id r2so322065pgl.10 for ; Wed, 25 Aug 2021 10:02:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to; bh=JPYN58I8iwDjkkaAQ12KQE3dH5zi0iw/ePsmwnZBiis=; b=tHGMjHerhQmn8oEv7FSvMEmdFEbCgP5dCGSbj8/ppUclzaRPE0ykGS5kD+dcCuhoTV 3dAQVbf91qqpoWBDdlM8ZcbAdGaWZw7gKOitbgqrsyHCYeZVs5bL8g15Pc1Ady8jYVYA QyvgDrcYXfKeEOWnzyNW+VpUhRk4CWFwU3KiZfpvLyoQKmaTwoFRkmd/JPCO/KmACCaL 6PqTPFVct3+vo0udr6Lb+mMi0JOLEwV8OV54ArX/E+h8UpyT/Bb4BmSrjCudeJOzpjuF TWKt+mvRfgTJEtD/ZseGbG4IzBgvNlRdaJl1mHbtk8Dm1aU/MfPyRXChZyhJEEpUEe8G u6/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to; bh=JPYN58I8iwDjkkaAQ12KQE3dH5zi0iw/ePsmwnZBiis=; b=jfrQyXRM3nBWn1kKlCf2V8X+cgvptcTC1gniJOgUDyfWYprFV6OVUHCDyzeRidCSCm sQtje60rtdUXbmxFVLQGED4e1vdNxrtdduLgdkghD1ocw2kdn2BpPU7aOhiM+P8/dstD k3xw4qHBMZAZ9zthB+xeAGWJlAJDzC2COfpdNliTNfPBMOUm9LjYLh40pUPMgpm1V/f5 1sbLL+RKOKlCYv71NYKrNBvpV7/6sMum4Ml/0kKyjqimN4dMnCZ2DlXNmYReezzpbtph ob+45RczHO94MHEiAlYgFafv+anh5rQwPR25L4nFI0HnSDE1ximKn4sFbdl6obdk4GmV rZ8g== X-Gm-Message-State: AOAM530Tt/jcEbn+3aZoYbU+PXHC4n/MxvwMc8w8QN8XmCYq8nd9JZDY Fy7sgilIK5CEOqoOHcDEqWd8kA== X-Google-Smtp-Source: ABdhPJyM5l/kLOJcfiP1Y14aCLTzHM4x5bIVas9Yeih96jeQTF3H8dXDvwE3fwZyT5YRRvQl74n13w== X-Received: by 2002:a05:6a00:884:b0:3ef:69c7:1264 with SMTP id q4-20020a056a00088400b003ef69c71264mr4671553pfj.4.1629910936346; Wed, 25 Aug 2021 10:02:16 -0700 (PDT) Received: from p14s (S0106889e681aac74.cg.shawcable.net. [68.147.0.187]) by smtp.gmail.com with ESMTPSA id l14sm6025913pjq.13.2021.08.25.10.02.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 25 Aug 2021 10:02:15 -0700 (PDT) Date: Wed, 25 Aug 2021 11:02:13 -0600 From: Mathieu Poirier To: Daniel Kiss Cc: coresight@lists.linaro.org, denik@google.com, leo.yan@linaro.org, linux-arm-kernel@lists.infradead.org, mike.leach@linaro.org, suzuki.poulose@arm.com, Branislav Rankov Subject: Re: [PATCHv2 2/4] coresight: tmc-etr: Track perf handler. Message-ID: <20210825170213.GA763112@p14s> References: <20210713121532.836244-1-daniel.kiss@arm.com> <20210713121532.836244-3-daniel.kiss@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20210713121532.836244-3-daniel.kiss@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210825_100221_884370_1B025607 X-CRM114-Status: GOOD ( 24.86 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Daniel, On Tue, Jul 13, 2021 at 02:15:30PM +0200, Daniel Kiss wrote: > Keep track of the perf handler that is registred by the first tracer. > This will be used by the update call from polling. > > Signed-off-by: Daniel Kiss > Signed-off-by: Branislav Rankov > --- > drivers/hwtracing/coresight/coresight-tmc-etr.c | 6 ++++-- > drivers/hwtracing/coresight/coresight-tmc.h | 2 ++ > 2 files changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/hwtracing/coresight/coresight-tmc-etr.c b/drivers/hwtracing/coresight/coresight-tmc-etr.c > index 589bb2d56e802..55c9b5fd9f832 100644 > --- a/drivers/hwtracing/coresight/coresight-tmc-etr.c > +++ b/drivers/hwtracing/coresight/coresight-tmc-etr.c > @@ -1503,8 +1503,8 @@ tmc_update_etr_buffer(struct coresight_device *csdev, > > spin_lock_irqsave(&drvdata->spinlock, flags); > > - /* Don't do anything if another tracer is using this sink */ > - if (atomic_read(csdev->refcnt) != 1) { > + /* Serve only the tracer with the leading perf handler */ > + if (drvdata->perf_handle != handle) { In CPU wide trace scenarios the first CPU to enable a sink is not guaranteed to be the same as the last CPU to use it. As far as I understand the above assumes the first and last CPUs to use a sink are the same. > spin_unlock_irqrestore(&drvdata->spinlock, flags); > goto out; > } > @@ -1619,6 +1619,7 @@ static int tmc_enable_etr_sink_perf(struct coresight_device *csdev, void *data) > drvdata->pid = pid; > drvdata->mode = CS_MODE_PERF; > drvdata->perf_buf = etr_perf->etr_buf; > + drvdata->perf_handle = handle; > atomic_inc(csdev->refcnt); > } > > @@ -1666,6 +1667,7 @@ static int tmc_disable_etr_sink(struct coresight_device *csdev) > drvdata->mode = CS_MODE_DISABLED; > /* Reset perf specific data */ > drvdata->perf_buf = NULL; > + drvdata->perf_handle = NULL; > > spin_unlock_irqrestore(&drvdata->spinlock, flags); > > diff --git a/drivers/hwtracing/coresight/coresight-tmc.h b/drivers/hwtracing/coresight/coresight-tmc.h > index b91ec7dde7bc9..81583ffb973dc 100644 > --- a/drivers/hwtracing/coresight/coresight-tmc.h > +++ b/drivers/hwtracing/coresight/coresight-tmc.h > @@ -184,6 +184,7 @@ struct etr_buf { > * @idr_mutex: Access serialisation for idr. > * @sysfs_buf: SYSFS buffer for ETR. > * @perf_buf: PERF buffer for ETR. > + * @perf_handle: PERF handle for ETR. > */ > struct tmc_drvdata { > void __iomem *base; > @@ -207,6 +208,7 @@ struct tmc_drvdata { > struct mutex idr_mutex; > struct etr_buf *sysfs_buf; > struct etr_buf *perf_buf; > + struct perf_output_handle *perf_handle; > }; > > struct etr_buf_operations { > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel